Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-04-02 Thread Ben Hutchings
On Fri, 2010-04-02 at 12:14 +0100, David Woodhouse wrote: > On Thu, 2010-04-01 at 19:38 -0700, David Miller wrote: > > Whatever you submit > > next I'd like to toss into net-next-2.6 so it can cook for a while > > and maybe we'll backport it so that this bug can be fixed for good > > upstream and t

Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-04-02 Thread David Woodhouse
On Thu, 2010-04-01 at 05:34 +0100, Ben Hutchings wrote: > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -188,7 +188,7 @@ struct phy_device* phy_device_create(struct mii_bus *bus, > int addr, int phy_id) > around for long enough for the driver to get loaded.

Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-04-02 Thread David Woodhouse
On Thu, 2010-04-01 at 19:38 -0700, David Miller wrote: > Whatever you submit > next I'd like to toss into net-next-2.6 so it can cook for a while > and maybe we'll backport it so that this bug can be fixed for good > upstream and then perhaps even in -stable. When backporting, note that you'll ne

Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-04-01 Thread David Miller
From: Ben Hutchings Date: Thu, 1 Apr 2010 19:05:12 +0100 > On Thu, Apr 01, 2010 at 06:03:48PM +0100, David Woodhouse wrote: >> On Thu, 2010-04-01 at 05:34 +0100, Ben Hutchings wrote: > [...] >> > Since you've dealt with (a), and (b) is not really as important, I would >> > just like to suggest so

Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-04-01 Thread David Woodhouse
On Thu, 2010-04-01 at 05:34 +0100, Ben Hutchings wrote: > On Wed, 2010-03-31 at 02:18 +0100, David Woodhouse wrote: > > We don't use the normal hotplug mechanism because it doesn't work. It will > > load the module some time after the device appears, but that's not good > > enough for us -- we need

Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-04-01 Thread Ben Hutchings
On Thu, Apr 01, 2010 at 06:03:48PM +0100, David Woodhouse wrote: > On Thu, 2010-04-01 at 05:34 +0100, Ben Hutchings wrote: [...] > > Since you've dealt with (a), and (b) is not really as important, I would > > just like to suggest some minor changes to your patch 1 (see below). > > Feel free to fol

Bug#553024: [PATCH 1/2] phylib: Support phy module autoloading

2010-03-31 Thread Ben Hutchings
On Wed, 2010-03-31 at 02:18 +0100, David Woodhouse wrote: > We don't use the normal hotplug mechanism because it doesn't work. It will > load the module some time after the device appears, but that's not good > enough for us -- we need the driver loaded _immediately_ because otherwise > the NIC dri