From: Ben Hutchings <b...@decadent.org.uk> Date: Thu, 1 Apr 2010 19:05:12 +0100
> On Thu, Apr 01, 2010 at 06:03:48PM +0100, David Woodhouse wrote: >> On Thu, 2010-04-01 at 05:34 +0100, Ben Hutchings wrote: > [...] >> > Since you've dealt with (a), and (b) is not really as important, I would >> > just like to suggest some minor changes to your patch 1 (see below). >> > Feel free to fold them in. Your patch 2 would then need the >> > substitutions s/phy_device_id/mdio_device_id/; s/TABLE(phy/TABLE(mdio/. >> >> I'll tolerate the silly __u32 crap if I must for consistency, but >> normally I prefer to write in C. >> >> I did think about 'mdio:' for the module alias, but I decided that >> 'phy:' probably made more sense since these are PHY driver modules and >> the number is the phy_id. > [...] > > Many multi-layered communication standards have distinct PHY devices, > and they presumably have their own ID spaces. phylib deals only with > management of Ethernet PHYs over an MDIO bus, identified using MDIO > ID registers. Agreed, PHYs exist on so many different kinds of topologies, the ones here are definitely specific to Ethernet and MDIO and therefore that is probably the more useful basis for naming. David can you freshen things up in this area and integrate whatever you deem useful and immediate from Ben's patch? Whatever you submit next I'd like to toss into net-next-2.6 so it can cook for a while and maybe we'll backport it so that this bug can be fixed for good upstream and then perhaps even in -stable. Thanks! -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100401.193810.172601735.da...@davemloft.net
