Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread James Addison
Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Yep, those two issues seem accurate to me: splitting the config file list (a trickier prospect than it seemed it should be, because newlines have been converted into spaces), and then quoting t

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Cyril Brulebois
Cyril Brulebois (2023-05-04): > The problem is the next stage, distributing the relevant files into the > appropriate binary packages. That part is controlled by the defines, and > that's what needs to be adjusted (file format and/or how it's used). > > A quick look suggests files_orig isn't set

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Diederik de Haas
On Thursday, 4 May 2023 12:25:29 CEST Diederik de Haas wrote: > While trying to prepare a MR to fix bug #1029843, I encountered a > failure which seems to be `gencontrol.py`'s inability to deal with > spaces and/or backslashes (used to escape the spaces). Here's the branch that I created: https://

Bug#1029843: Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Cyril Brulebois
James Addison (2023-05-04): > I think that the edits to 'debian/config/brcm80211/defines' may be the cause > of the space-escaping issue (noticed that in your fork on Salsa). > > Building locally without modifications from firmware-nonfree_20230210-5 I get: > lrwxrwxrwx 1 jka jka 44 May 4 1

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread James Addison
Source: firmware-nonfree Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Looks like a silently-handled exception here: https://salsa.debian.org/kernel-team/firmware-nonfree/-/blob/9f189a7f81d40694ee71a36906de5637dada950f/debian/bin/gencontr

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread James Addison
Source: firmware-nonfree Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Hey Diederik, I think that the edits to 'debian/config/brcm80211/defines' may be the cause of the space-escaping issue (noticed that in your fork on Salsa). Building

Bug#1029843: brcmfmac: requested firmware filename inconsistent with linux-firmware.git on non-devicetree systems

2023-05-04 Thread Cyril Brulebois
Hi, Diederik de Haas (2023-05-04): > Assuming the '55' stands for max 55 chars, that could be an issue? That's not how format strings work. :) That happily overflows: $ printf "%-10s and the rest of the line\n" kibi kibi and the rest of the line $ printf "%-10s and the rest

Processed: blocking 1029843 by 1035505

2023-05-04 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > block 1029843 by 1035505 Bug #1029843 [firmware-brcm80211] Missing symlinks for RPi 4 (to brcmfmac43455-sdio.raspberrypi,4-model-b.txt) 1029843 was not blocked by any bugs. 1029843 was not blocking any bugs. Added blocking bug(s) of 1029843: 1035

Bug#1029843: brcmfmac: requested firmware filename inconsistent with linux-firmware.git on non-devicetree systems

2023-05-04 Thread Diederik de Haas
Control: block -1 1035505 On Thursday, 4 May 2023 01:41:12 CEST Cyril Brulebois wrote: > Diederik de Haas (2023-05-04): > > And that makes it a firmware-brcm80211 issue and now it all does make > > sense as it now all does tie together :-) > > Great, that's what it looked like to me but I was af

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Diederik de Haas
Source: firmware-nonfree Version: 20230210-5 Severity: normal X-Debbugs-Cc: 1029...@bugs.debian.org, k...@debian.org -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 While trying to prepare a MR to fix bug #1029843, I encountered a failure which seems to be `gencontrol.py`'s inability to deal with