Re: webkit-1.8.0-2: Patches for review

2012-04-18 Thread Pino Toscano
Alle martedì 17 aprile 2012, Svante Signell ha scritto: > BTW: Doesn't the CString resultString; need to be initialized? > Or something like: > if (result >= 0 && result < sb.st_size) > resultString = CString(readLinkBuffer, result); > else > resultString = CString(); The else branch is not ne

Re: webkit-1.8.0-2: Patches for review

2012-04-18 Thread Svante Signell
On Wed, 2012-04-18 at 09:54 +0200, Pino Toscano wrote: > Alle martedì 17 aprile 2012, Svante Signell ha scritto: > The else branch is not needed, resultString is already initialized. Initialized to the empty string, or? > C++ (just like C99, FWIW) allows to declare variables inside code > block