Re: Update of golang-github-gdamore-cell to 2.*

2021-02-03 Thread Cyril Brulebois
Stephen Gelman (2021-02-02): > First of all I am so sorry for not letting you know! I foolishly > assumed that since we were uploading a new package it would not create > these issues - lesson learned. :D Second, I looked at your branch and > it looks awesome. That's a clever fix for the problem

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Stephen Gelman
Cyril, First of all I am so sorry for not letting you know! I foolishly assumed that since we were uploading a new package it would not create these issues - lesson learned. :D Second, I looked at your branch and it looks awesome. That's a clever fix for the problem - I checked a few similar pack

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Cyril Brulebois
Cyril Brulebois (2021-02-03): > It looks to me this would be better [debian/control]: > > -XS-Go-Import-Path: github.com/gdamore/tcell > +XS-Go-Import-Path: github.com/gdamore/tcell/v2 > > After all, that's what getting declared through go.mod, and what callers > are expecting to embed i

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Cyril Brulebois
Hi, [ Disclaimer: I'm rather new to the Go ecosystem, but I've modified some existing packages in a similar manner before. They couldn't conflict anyway since they changed hosters, but that was looked into at the time. References below. ] Daniel Milde (2021-02-02): > I have noticed, that autopkg

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Cyril Brulebois
Hi Stephen and Daniel, Stephen Gelman (2021-02-02): > I actually looked at this a little last night. I believe the correct > fix, which I uploaded in 2.1.0-4 is to make > golang-github-gdamore-tcell.v2-dev both conflict with and replace > golang-github-gdamore-tcell-dev. Having said that, this wi

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Daniel Milde
Stephen, I think you are right. I have created pull request upstream - https://github.com/antonmedv/expr/pull/160 hopefully they will accept it. Daniel Dne 02. 02. 21 v 17:19 Stephen Gelman napsal(a): Daniel, I actually looked at this a little last night. I believe the correct fix, which I

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Stephen Gelman
Daniel, I actually looked at this a little last night. I believe the correct fix, which I uploaded in 2.1.0-4 is to make golang-github-gdamore-tcell.v2-dev both conflict with and replace golang-github-gdamore-tcell-dev. Having said that, this will break golang-github-antonmedv-expr-dev which de

Re: Update of golang-github-gdamore-cell to 2.*

2021-02-02 Thread Daniel Milde
Hi Stephen, I have noticed, that autopkgtest failed for golang-github-rivo-tview because golang-github-gdamore-tcell.v2 installs gocode into the same directory as golang-github-gdamore-tcell: https://qa.debian.org/excuses.php?package=golang-github-rivo-tview https://ci.debian.net/data/autopkgt

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-24 Thread Daniel Milde
Hi Stephen, I have consulted with another dev (Ondrej Novy) and he told me that they all should be uploaded at once. Thanks Daniel Dne 25. 01. 21 v 1:37 Stephen Gelman napsal(a): OK, I uploaded golang-github-gdamore-tcell.v2. I think that might need to clear NEW before I can upload golang-gi

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-24 Thread Stephen Gelman
Hmm, that one is super weird. I have never really looked at the CI pipeline before. Does anyone else have any ideas? Stephen > On Jan 24, 2021, at 4:04 PM, Daniel Milde wrote: > > Hi Stephen, > I have upgraded gdu to 4.3.0 and noticed that the pipeline is always failing > - https://salsa.debi

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-24 Thread Stephen Gelman
OK, I uploaded golang-github-gdamore-tcell.v2. I think that might need to clear NEW before I can upload golang-github-rivo-tview and therefore gdu. If this is wrong, please, someone correct me and I’ll upload the others now! Stephen > On Jan 24, 2021, at 1:32 PM, Daniel Milde wrote: > > Hi St

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-24 Thread Daniel Milde
Hi Stephen, I have upgraded gdu to 4.3.0 and noticed that the pipeline is always failing - https://salsa.debian.org/go-team/packages/gdu/-/jobs/1377762 Looks like some conflicting config. Does it need some ENV variable to be set for the project? Thanks Daniel Dne 24. 01. 21 v 8:08 Stephen Gel

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-24 Thread Daniel Milde
Hi Stephen, my bad. I was testing it only with gbp and hadn't have clean environment. Fixed now. Thanks Daniel Dne 24. 01. 21 v 8:08 Stephen Gelman napsal(a): Daniel, I am unable to build golang-github-gdamore-tcell.v2 in a clean pbuilder. I get a long list of errors such as: src/gopkg.in/

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-23 Thread Stephen Gelman
Daniel, I am unable to build golang-github-gdamore-tcell.v2 in a clean pbuilder. I get a long list of errors such as: src/gopkg.in/gdamore/tcell.v2/errors.go:21:2: cannot find package "github.com/gdamore/tcell/v2/terminfo" in any of: /usr/lib/go-1.15/src/github.com/gdamore/tcell/v2/term

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-23 Thread Daniel Milde
Ok, changed. Thanks Daniel Dne 23. 01. 21 v 22:47 Stephen Gelman napsal(a): Looking good as a whole. A few small changes before it’s ready to upload: - gdu needs a newer version of golang-github-rivo-tview right? Therefore it should depend on at least that version. - Can you please either add

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-23 Thread Stephen Gelman
Looking good as a whole. A few small changes before it’s ready to upload: - gdu needs a newer version of golang-github-rivo-tview right? Therefore it should depend on at least that version. - Can you please either add yourself to the Uploaders for golang-github-rivo-tview and golang-github-gdamo

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-23 Thread Daniel Milde
Hi Stephen, ITP created: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980863 and changelog updated. Cheers Daniel Dne 23. 01. 21 v 0:20 Stephen Gelman napsal(a): Daniel, I believe now that we are uploading golang-github-gdamore-tcell.v2 as a new package it requires an ITP. If that's wro

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-23 Thread daniel
That's right. I will create one and modify the changelog to close it.ThanksDaniel Původní zpráva Od: Stephen Gelman Datum: 23.01.21 0:39 (GMT+01:00) Komu: Daniel Milde Cc: debian-go@lists.debian.org Předmět: Re: Update of golang-github-gdamore-cell to 2.* Daniel,I be

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-22 Thread Stephen Gelman
Daniel, I believe now that we are uploading golang-github-gdamore-tcell.v2 as a new package it requires an ITP. If that's wrong, someone please correct me! :) Stephen On Fri, Jan 22, 2021 at 1:54 PM Daniel Milde wrote: > > Great, thank you! > > Just pushed all three: > https://salsa.debian.org/

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-22 Thread Daniel Milde
Great, thank you! Just pushed all three: https://salsa.debian.org/go-team/packages/golang-github-gdamore-tcell.v2 https://salsa.debian.org/go-team/packages/golang-github-rivo-tview https://salsa.debian.org/go-team/packages/gdu I will be pleased for your sponsorship! Cheers Daniel Dne 22. 01. 2

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-22 Thread Stephen Gelman
I think the golang-github-gdamore-tcell repo should be renamed to golang-github-gdamore-tcell.v2 and created as a new repo under the golang team. I added you as a member of go-team so you can push the golang-github-rivo-tview changes. For the ones that are new repos, please use “dh-make-golang

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-22 Thread Daniel Milde
Hi all, so I have packed my first batch of 3 packages. * updated https://salsa.debian.org/dundee/golang-github-gdamore-tcell and added .v2 suffix since it brokes some dependencies * updated https://salsa.debian.org/dundee/golang-github-rivo-tview (nothing broken accorgind to ratt) * new packag

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-22 Thread Daniel Milde
Hi Stephen, some packages don't work: 2021/01/22 12:57:14 PASSED: golang-github-antonmedv-expr 2021/01/22 12:57:14 PASSED: aerc 2021/01/22 12:57:14 PASSED: golang-github-alecaivazis-survey 2021/01/22 12:57:14 PASSED: golang-github-hinshun-vt10x 2021/01/22 12:57:14 FAILED: termshark (see buildlogs

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-21 Thread Stephen Gelman
Daniel, Does v2 work automatically with existing packages? I recommend using ratt to test. If not, v2 should be uploaded as a separate package. Stephen On Thu, Jan 21, 2021 at 3:16 PM Daniel Milde wrote: > > Hi all, > I have updated gdamore-tcell to 2.1.0 - > https://salsa.debian.org/dundee/gol

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-21 Thread Daniel Milde
Hi all, I have updated gdamore-tcell to 2.1.0 - https://salsa.debian.org/dundee/golang-github-gdamore-tcell What should I do next? I am not member of the team yet (but request sent), so I cannot push to https://salsa.debian.org/go-team/packages/golang-github-gdamore-tcell Should I create a

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-21 Thread Utkarsh Gupta
Hi Daniel, On Thu, Jan 21, 2021 at 2:13 PM Daniel Milde wrote: > I would like to pack https://github.com/dundee/gdu afterwards which > needs gdamore/tcell (as it uses rivo/tview). You can patch gdu to use the zyedidia's tcell. But of course, whatever you're comfortable with! :)

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-21 Thread Daniel Milde
Hi, ok, I will try. I would like to pack https://github.com/dundee/gdu afterwards which needs gdamore/tcell (as it uses rivo/tview). Thank you! Daniel Dne 21. 01. 21 v 8:11 Utkarsh Gupta napsal(a): Hi Daniel, On Thu, Jan 21, 2021 at 3:47 AM Daniel Milde wrote: I am starting with packagin

Re: Update of golang-github-gdamore-cell to 2.*

2021-01-20 Thread Utkarsh Gupta
Hi Daniel, On Thu, Jan 21, 2021 at 3:47 AM Daniel Milde wrote: > I am starting with packaging Go stuff and would like to update > golang-github-gdamore-tcell to version 2.* > > This version is referenced as github.com/gdamore/tcell/v2 in go.mod and > it's not backwards compatible with version 1.*

Update of golang-github-gdamore-cell to 2.*

2021-01-20 Thread Daniel Milde
Hello Go Team, I am starting with packaging Go stuff and would like to update golang-github-gdamore-tcell to version 2.* This version is referenced as github.com/gdamore/tcell/v2 in go.mod and it's not backwards compatible with version 1.* which is on Salsa - https://salsa.debian.org/dundee/g