Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Ben Hutchings
On Sat, 2016-02-20 at 18:25 +0100, Jérémy Bobbio wrote: > Ian Campbell: > > So I'm afraid I'm still not clear exactly what issue you are seeing. > > > > Please can you post: > > > >  * the contents of your /boot/cmdline.txt > >  * the contents of the flash kernel db entry you have added for the >

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Jérémy Bobbio
Ian Campbell: > So I'm afraid I'm still not clear exactly what issue you are seeing. > > Please can you post: > > * the contents of your /boot/cmdline.txt > * the contents of the flash kernel db entry you have added for the >RPi2 > * the resulting generated boot.scr. > * a full serial con

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Ian Campbell
On Sat, 2016-02-20 at 16:58 +0100, Jérémy Bobbio wrote: > > Did you ever see an actual problem related to the lack of quoting this > > bug is about or did you just spot what looked like an error by > > inspection? > > I stumbled on it because I had put in /etc/default/flash-kernel: > > LINUX

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Jérémy Bobbio
Ian Campbell: > On Sat, 2016-02-20 at 14:41 +0100, Jérémy Bobbio wrote: > > Ian Campbell: > > > On Sat, 2016-02-20 at 13:29 +0100, Jérémy Bobbio wrote: > > > > Ian Campbell: > > > > > Lunar -- which platform did you see an issue on and what do the > > > > > above > > > > > test commands give in tha

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Ian Campbell
On Sat, 2016-02-20 at 14:41 +0100, Jérémy Bobbio wrote: > Ian Campbell: > > On Sat, 2016-02-20 at 13:29 +0100, Jérémy Bobbio wrote: > > > Ian Campbell: > > > > Lunar -- which platform did you see an issue on and what do the > > > > above > > > > test commands give in that case? > > > > > > The ver

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Jérémy Bobbio
Ian Campbell: > On Sat, 2016-02-20 at 13:29 +0100, Jérémy Bobbio wrote: > > Ian Campbell: > > > Lunar -- which platform did you see an issue on and what do the > > > above > > > test commands give in that case? > > > > The version in Debian: https://packages.debian.org/sid/u-boot-rpi > > and how

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Ian Campbell
On Sat, 2016-02-20 at 13:29 +0100, Jérémy Bobbio wrote: > Ian Campbell: > > Lunar -- which platform did you see an issue on and what do the > > above > > test commands give in that case? > > The version in Debian: https://packages.debian.org/sid/u-boot-rpi and how does it behave in the tests comp

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Jérémy Bobbio
Ian Campbell: > Lunar -- which platform did you see an issue on and what do the above > test commands give in that case? The version in Debian: https://packages.debian.org/sid/u-boot-rpi > I'm going to push a change relating to the other suggestion here (the > ability to set a defaults before ${b

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Ian Campbell
Control: tag -1 +moreinfo On Thu, 2016-01-28 at 16:36 +, Ian Campbell wrote: > > > having no quotes should not be a problem for the u-boot setenv command: > > > > => setenv foo a b c d e > > => printenv foo > > foo=a b c d e > > => setenv foo ${foo} bar baz > > => printenv foo > > foo=a b c

Processed: Re: Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-02-20 Thread Debian Bug Tracking System
Processing control commands: > tag -1 +moreinfo Bug #813023 [flash-kernel] flash-kernel: quoting error with bootargs in generic U-Boot boot script Added tag(s) moreinfo. -- 813023: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813023 Debian Bug Tracking System Contact ow...@bugs.debian.org w

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-01-29 Thread Jérémy Bobbio
Ian Campbell: > On Thu, 2016-01-28 at 16:36 +, Ian Campbell wrote: > > > > While, I am at it, I wonder if it would not make more sense to > > > > reverse the order when setting that variable so it reads: > > > > > > > > setenv bootargs "@@LINUX_KERNEL_CMDLINE@@ ${bootargs}" > > > > > > >

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-01-29 Thread Ian Campbell
On Thu, 2016-01-28 at 16:36 +, Ian Campbell wrote: > > > While, I am at it, I wonder if it would not make more sense to > > > reverse the order when setting that variable so it reads: > > > > > > setenv bootargs "@@LINUX_KERNEL_CMDLINE@@ ${bootargs}" > > > > > > That way, it's possible to

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-01-28 Thread Ian Campbell
On Thu, 2016-01-28 at 17:30 +0100, Karsten Merker wrote: > On Thu, Jan 28, 2016 at 04:19:27PM +0100, Jérémy Bobbio wrote: > > Package: flash-kernel > > Version: 3.56 > > Tag: patch > > > > Hi! > > > > There's a small quoting mistake in the generic U-Boot script. It > > probably hasn't been notice

Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script

2016-01-28 Thread Jérémy Bobbio
Package: flash-kernel Version: 3.56 Tag: patch Hi! There's a small quoting mistake in the generic U-Boot script. It probably hasn't been noticed so far because the default LINUX_KERNEL_CMDLINE doesn't contain spaces. See the attached patch. While, I am at it, I wonder if it would not make more s