Bug#454493: Display PCI slot for nics, if available

2007-12-31 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: >> I think that code might be more clear if you change the cleanup step >> to be a funtion and it will make simpler to spot what is being done in >> each case. > > Yes, this does improve readability. And it did, indeed. This lastest version is much easier

Bug#454493: Display PCI slot for nics, if available

2007-12-31 Thread dann frazier
On Mon, Dec 31, 2007 at 09:43:15AM -0200, Otavio Salvador wrote: > dann frazier <[EMAIL PROTECTED]> writes: > > >> imo, the best and more widly solution would be the 2. That shouldn't > >> be too hard and would allow us to reduce the memory footprint not only > >> on your user case but in general

Bug#454493: Display PCI slot for nics, if available

2007-12-31 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: >> imo, the best and more widly solution would be the 2. That shouldn't >> be too hard and would allow us to reduce the memory footprint not only >> on your user case but in general usage too. > > Might be vearing off topic for this bug, but here's a wrappe

Bug#454493: Display PCI slot for nics, if available

2007-12-31 Thread dann frazier
On Thu, Dec 27, 2007 at 07:15:01PM -0200, Otavio Salvador wrote: > dann frazier <[EMAIL PROTECTED]> writes: > > Yeah. Options here would be: > > 1) big hammer - write a modprobe wrapper that cleans > > unused/unloadable modules after every load > > 2) smaller hammer - write a modprobe wrapper

Bug#454493: Display PCI slot for nics, if available

2007-12-27 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: > On Thu, Dec 27, 2007 at 05:09:38PM -0200, Otavio Salvador wrote: >> dann frazier <[EMAIL PROTECTED]> writes: >> >> > [1] Of course, acpiphp has module dependencies, and if these aren't >> > cleaned up after a failed load, memory will still be lost to

Bug#454493: Display PCI slot for nics, if available

2007-12-27 Thread dann frazier
On Thu, Dec 27, 2007 at 05:09:38PM -0200, Otavio Salvador wrote: > dann frazier <[EMAIL PROTECTED]> writes: > > > [1] Of course, acpiphp has module dependencies, and if these aren't > > cleaned up after a failed load, memory will still be lost to those > > modules > > It means that we'd n

Bug#454493: Display PCI slot for nics, if available

2007-12-27 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: > [1] Of course, acpiphp has module dependencies, and if these aren't > cleaned up after a failed load, memory will still be lost to those > modules It means that we'd need to find a way to get those dependencies and walk throught them removing the

Bug#454493: Display PCI slot for nics, if available

2007-12-27 Thread dann frazier
(Good discussion so far, sorry for the late response..) On Sunday 09 December 2007, Frans Pop wrote: > On Friday 07 December 2007, dann frazier wrote: > > Understood. Note that this implementation doesn't *require* the > > module, it just takes advantage of it if its available. And, if > > other >

Bug#454493: Display PCI slot for nics, if available

2007-12-09 Thread Frans Pop
On Sunday 09 December 2007, Joey Hess wrote: > Debconf would display the above example as: > > eth0: foo bar description > eth0: mac address: xxx:xxx... [slot 1] Ah, so basically just have two lines and two effectively identical choices per NIC. Guess that could work. Maybe we could e

Bug#454493: Display PCI slot for nics, if available

2007-12-09 Thread Joey Hess
Frans Pop wrote: > > eth0: foo bar description, eth0: mac address: xxx:xxx... [slot 1] > > > > That would be one way to do it without modifying debconf. You could also > > get rid of the "eth0: " prefix if you wanted to by using Choices-C. > > I'm probably just being thick, but what exactly are yo

Bug#454493: Display PCI slot for nics, if available

2007-12-09 Thread Frans Pop
On Friday 07 December 2007, dann frazier wrote: > On Thu, Dec 06, 2007 at 01:34:25AM +0100, Frans Pop wrote: > > On Wednesday 05 December 2007, dann frazier wrote: > > > This patch to hw-detect adds slot information, if available, to the > > > network device name. Its not uncommon for HP (or our cu

Bug#454493: Display PCI slot for nics, if available

2007-12-09 Thread Frans Pop
On Friday 07 December 2007, Otavio Salvador wrote: > > In fact, as to Otavio's point, it probably makes sense to do the > > module loading outside of hw-detect (e.g. his acpi-support-udeb > > suggestion), and just let hw-detect use the interface if its > > available. > > Yes, I think it's starting

Bug#454493: Display PCI slot for nics, if available

2007-12-09 Thread Frans Pop
On Friday 07 December 2007, Joey Hess wrote: > dann frazier wrote: > > * Modify cdebconf to support multi-line choice fields. Make each > >interface choice be a multi-lined option that includes things like > >vendor, model, mac, slot. > > eth0: foo bar description, eth0: mac address: xxx:x

Bug#454493: Display PCI slot for nics, if available

2007-12-07 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: <...> > In fact, as to Otavio's point, it probably makes sense to do the > module loading outside of hw-detect (e.g. his acpi-support-udeb > suggestion), and just let hw-detect use the interface if its > available. Yes, I think it's starting to makes sense

Bug#454493: Display PCI slot for nics, if available

2007-12-06 Thread Joey Hess
dann frazier wrote: > * Modify cdebconf to support multi-line choice fields. Make each >interface choice be a multi-lined option that includes things like >vendor, model, mac, slot. eth0: foo bar description, eth0: mac address: xxx:xxx... [slot 1] That would be one way to do it without m

Bug#454493: Display PCI slot for nics, if available

2007-12-06 Thread dann frazier
On Thu, Dec 06, 2007 at 01:34:25AM +0100, Frans Pop wrote: > On Wednesday 05 December 2007, dann frazier wrote: > > This patch to hw-detect adds slot information, if available, to the > > network device name. Its not uncommon for HP (or our customers) to > > have systems with many network devices,

Bug#454493: Display PCI slot for nics, if available

2007-12-05 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: <...> > I believe that currently the only way to know if a machine supports > acpiphp is to load it. This seems to match up pretty well with my > observations of other acpi drivers. acpid seems to take ownership of > loading acpi modules like battery, fan,

Bug#454493: Display PCI slot for nics, if available

2007-12-05 Thread Frans Pop
On Wednesday 05 December 2007, dann frazier wrote: > This patch to hw-detect adds slot information, if available, to the > network device name. Its not uncommon for HP (or our customers) to > have systems with many network devices, and knowing the physical slot > number of an adapter makes configur

Bug#454493: Display PCI slot for nics, if available

2007-12-05 Thread dann frazier
On Wed, Dec 05, 2007 at 05:03:41PM -0200, Otavio Salvador wrote: > dann frazier <[EMAIL PROTECTED]> writes: > > > Currently this patch only attempts to load the acpiphp driver - it > > should probably try and load others as well (e.g. pciehp & shchp, and > > the future possible pci_slot). > > Why

Bug#454493: Display PCI slot for nics, if available

2007-12-05 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: > Currently this patch only attempts to load the acpiphp driver - it > should probably try and load others as well (e.g. pciehp & shchp, and > the future possible pci_slot). Why acpihp isn't loaded by udev automaticaly? -- O T A V I OS A L V

Bug#454493: Display PCI slot for nics, if available

2007-12-05 Thread dann frazier
Package: hw-detect Version: 1.58 Severity: wishlist Tags: patch The linux kernel may expose slot information for PCI devices in sysfs. Currently slot info is only exposed if the PCI device is hotpluggable and the associated hotplug driver is loaded. However, work is underway[1] to expose slot info