Bug#442236: updated patch

2008-02-29 Thread Guido Günther
On Fri, Feb 29, 2008 at 01:53:00AM +0100, Frans Pop wrote: > On Friday 29 February 2008, Otavio Salvador wrote: > > Better: > > _Description: Multipath %s, partition #%s > > > > looks more logical and follows rest of templates. > > Agreed. Feel free to commit (with changelog entry) after that. Tha

Bug#442236: updated patch

2008-02-28 Thread Frans Pop
On Friday 29 February 2008, Otavio Salvador wrote: > Better: > _Description: Multipath %s, partition #%s > > looks more logical and follows rest of templates. Agreed. Feel free to commit (with changelog entry) after that. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubsc

Bug#442236: updated patch

2008-02-28 Thread Otavio Salvador
Guido Günther <[EMAIL PROTECTED]> writes: <...> > +Template: partman/text/multipath_partition > +Type: text > +_Description: Multipath %s Partition #%s > + lowercase? Better: _Description: Multipath %s, partition #%s looks more logical and follows rest of templates

Bug#442236: updated patch

2008-02-28 Thread Guido Günther
On Tue, Feb 26, 2008 at 06:38:27PM +0100, Frans Pop wrote: > On Tuesday 26 February 2008, Guido Günther wrote: > > I've attached an updated patch. Thanks for the comments. > > Thanks for the update, but I'm afraid I have one more. > > Please define variables used inside functions with 'local', es

Bug#442236: updated patch

2008-02-26 Thread Frans Pop
On Tuesday 26 February 2008, Guido Günther wrote: > I've attached an updated patch. Thanks for the comments. Thanks for the update, but I'm afraid I have one more. Please define variables used inside functions with 'local', especially when defining variables with common names like "type". Partm

Bug#442236: updated patch

2008-02-26 Thread Guido Günther
Hi Frans On Tue, Feb 26, 2008 at 04:53:52PM +0100, Frans Pop wrote: > On Tuesday 26 February 2008, Guido Günther wrote: > > attached is an updated patch against current partman-base. I attach an > > updated version for review since it contains a template which might be > > interesting for translato

Bug#442236: updated patch

2008-02-26 Thread Frans Pop
On Tuesday 26 February 2008, Guido Günther wrote: > attached is an updated patch against current partman-base. I attach an > updated version for review since it contains a template which might be > interesting for translators There are two (minor) issues in: + if [ "$type" != multipath ] -a

Bug#442236: updated patch

2008-02-26 Thread Guido Günther
Hi, attached is an updated patch against current partman-base. I attach an updated version for review since it contains a template which might be interesting for translators Template: partman/text/multipath Type: text _Description: Multipath %s (WWID %s) Template: partman/text/multipath_partition