On Tuesday 26 February 2008, Guido Günther wrote: > I've attached an updated patch. Thanks for the comments.
Thanks for the update, but I'm afraid I have one more. Please define variables used inside functions with 'local', especially when defining variables with common names like "type". Partman is very modular and will sometimes function calls can be very nested, so there is a real risk that variables on higher levels will get clobbered if 'local' is not used, which of course could result in unexpected errors that are very hard to trace.