Re: Bug#402450: #402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Frans Pop
On Thursday 21 December 2006 19:06, Eddy Petrișor wrote: > done and attached I still have some reservations regarding this patch. - netcfg's base-installer script already copies the /etc/network/* files to the target system; what does the interfaces file in the d-i environment contain if ppp-u

Re: Bug#402450: #402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Eddy Petrișor
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frans Pop wrote: > On Thursday 21 December 2006 18:36, Eddy Petrișor wrote: >> The reason I placed it in there was that it seemed the most appropriate >> place since that is finish-install info. Do you think that >> /usr/lib/ppp-udeb/ is a better place

Re: Bug#402450: #402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Frans Pop
On Thursday 21 December 2006 18:36, Eddy Petrișor wrote: > The reason I placed it in there was that it seemed the most appropriate > place since that is finish-install info. Do you think that > /usr/lib/ppp-udeb/ is a better place? > > If the fact that the script is in /usr/lib/finish-install.d/ is

Re: Bug#402450: #402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Eddy Petrișor
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frans Pop wrote: > On Thursday 21 December 2006 17:08, Eddy Petrișor wrote: >>> The hostname issue is not tackled with yet since ppp-udeb's >>> functionality should be merged into (or called from) netcfg somehow >>> and I didn't had the time to investi

Re: Bug#402450: #402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Frans Pop
On Thursday 21 December 2006 17:08, Eddy Petrișor wrote: > > The hostname issue is not tackled with yet since ppp-udeb's > > functionality should be merged into (or called from) netcfg somehow > > and I didn't had the time to investigate that yet. > > > > Please include this in the next release of

Re: Bug#402450: #402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Eddy Petrișor
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Eddy Petrișor wrote: > tag 402450 patch > thanks > > Hello, > > Attached is a patch (against ppp 2.4.4rel-4) that takes care to add the > correct snippets in the > target's /etc/network/interfaces so that the loopback and the pppoe > connection is

#402450: a patch for this bug (pppoe not up after restart) and the depends issue

2006-12-21 Thread Eddy Petrișor
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 tag 402450 patch thanks Hello, Attached is a patch (against ppp 2.4.4rel-4) that takes care to add the correct snippets in the target's /etc/network/interfaces so that the loopback and the pppoe connection is brought up after restart. The hostname