On Thursday 21 December 2006 19:06, Eddy Petrișor wrote: > done and attached
I still have some reservations regarding this patch. - netcfg's base-installer script already copies the /etc/network/* files to the target system; what does the interfaces file in the d-i environment contain if ppp-udeb is run? as the netcfg base-installer script will still be run, this is relevant. - The 50config-target-ppp script is not idempotent: it will add the same section again and again if it is run more than once. IMO it would probably be better to make sure that the /etc/network/interfaces file in the d-i environment is correct and just let netcfg's base-installer script take care of copying it into /target. The only reason not to do that would be if file really has to be different in the d-i environment. If that is the case, the 50config-target-ppp script should take responsibility of correctly creating the file from scratch (i.e, not use ">>"). Also, please provide a patch that applies cleanly against the current version in the archive.
pgpdHGfEkVLRr.pgp
Description: PGP signature
