Re: [darktable-dev] Code reformatting...

2023-01-23 Thread Matthias Andree
Am 23.01.23 um 08:40 schrieb Pascal Obry: Hello devs, As we are not ready to have an automatic reformatting of the code I have started at least making the function headers a bit more readable. From: void dt_gui_presets_show_edit_dialog(const char *name_in, const char *module_name, int rowid,

Re: [darktable-dev] Code reformatting...

2023-01-23 Thread Heiko Bauke
Dear Pascal, Am 23.01.23 um 08:40 schrieb Pascal Obry: Hello devs, As we are not ready to have an automatic reformatting of the code I have started at least making the function headers a bit more readable. From: void dt_gui_presets_show_edit_dialog(const char *name_in, const char *module_na

Re: [darktable-dev] Code reformatting...

2023-01-23 Thread Heiko Bauke
Hi, Am 23.01.23 um 22:12 schrieb Matthias Andree: Am 23.01.23 um 08:40 schrieb Pascal Obry: While the idea is sound, 80 character wide lines seem so... 1980's. Do people still need to read and edit darktable source code on 640x480 displays? today's developers have not only wider screens than i

Re: [darktable-dev] Code reformatting...

2023-01-23 Thread Pascal Obry
Le lundi 23 janvier 2023 à 22:12 +0100, Matthias Andree a écrit : > > While the idea is sound, 80 character wide lines seem so... 1980's. > Do > people still need to read and edit darktable source code on 640x480 > displays? This has nothing to do with display size. Do you know why news paper has

Re: [darktable-dev] Code reformatting...

2023-01-23 Thread Pascal Obry
Le lundi 23 janvier 2023 à 22:30 +0100, Heiko Bauke a écrit : > Also working with code in Github, > Bitbucket etc., e.g. during code review, becomes rather uncomfortable > when the column width exceeds 80 characters significantly. Ok, 90 is still fine by me. --   Pascal Obry /  Magny Les Hameau