Fwd: [darktable-dev] advanced mask adjustments

2018-11-15 Thread Björn Sozumschein
Hi Heiko, Currently I think the following approach is reasonable: > > * There are to sliders in the UI, one for a Gaussian blur radius, one > for the guided filter radius. > > * The toggle box tho choose the filter is removed. > > * A new toggle box is added to choose the guide (module input or >

Re: [darktable-dev] advanced mask adjustments

2018-11-11 Thread Heiko Bauke
Hi Björn, Am 10.11.18 um 11:22 schrieb Björn Sozumschein: So, aside from the better conformity with the user's intuitive understanding, maybe inverting the mask at the end of the pipeline would benefit usability. for better user experience I revised the code that constructs the mask accordi

Re: Fwd: [darktable-dev] advanced mask adjustments

2018-11-11 Thread rawfiner
Hi Heiko I do not have a very detailed feedback to give for now, as I only played with it a little (maybe latter) ;-) Still, I wanted to say that I am very impressed, as I obtained great results very easily. This is awesome! Thanks a lot! rawfiner Le sam. 10 nov. 2018 à 20:07, Heiko Bauke a écrit

Re: Fwd: [darktable-dev] advanced mask adjustments

2018-11-10 Thread Heiko Bauke
Hi Björn, many thanks for your feedback. Am 10.11.18 um 11:24 schrieb Björn Sozumschein: I also believe that a proper explanation would prevent confusion regarding the inversion behavior. However, I have concerns with respect to the usability, based on my initial experience: In most cases, I u

Fwd: [darktable-dev] advanced mask adjustments

2018-11-10 Thread Björn Sozumschein
Hi Heiko, at first, the feathering using a guide filter works really great! I've tried it with a recent portrait shooting and it delivers awesome results for applying edits to the head independently from the background. I also believe that a proper explanation would prevent confusion regarding th

[darktable-dev] advanced mask adjustments

2018-11-09 Thread Heiko Bauke
Hi, currently I have an open pull request, see https://github.com/darktable-org/darktable/pull/1809 This pull request has some aspect which may lead to confusion by some users in some situations. I would like to draw your attention to this issue and would be thankful for feedback. The pull