Hi Björn, Am 10.11.18 um 11:22 schrieb Björn Sozumschein:
So, aside from the better conformity with the user's intuitive understanding, maybe inverting the mask at the end of the pipeline would benefit usability.
for better user experience I revised the code that constructs the mask accordingly, i.e., having mask inversion at the very end.
While doing so I also found a bug which has been fixed. (The possible/rare case that input and output rois have different sizes was not taken into account.) Currently these changes have only been only applied to the CPU code path. Fixes for OpenCL will follow as soon as possible. See https://github.com/rabauke/darktable/tree/guided_filter
Heiko -- -- Number Crunch Blog @ https://www.numbercrunch.de -- Cluster Computing @ https://www.clustercomputing.de -- Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org