Re: [darktable-dev] compilation error

2016-05-15 Thread johannes hanika
https://github.com/darktable-org/darktable/commit/5eeddc9f2415e31475e8d6b89630fcde7e7a34f7 On Mon, May 16, 2016 at 5:34 AM, johannes hanika wrote: > can you kids stop :) ? > > i don't have gcc6, but am happy to push a couple of white spaces to > make silly compilers happy.. > > fwiw i think -Werr

Re: [darktable-dev] weird colours when using several color modules

2016-05-15 Thread johannes hanika
hi, On Mon, May 16, 2016 at 4:19 AM, Marc Cousin wrote: > Hi, > > > I have something wrong in latests git versions: colours are completely > wrong as soon as I touch anything in several modules. The most obvious > one is color zones: touch anything and the color is completely wrong > (everything

Re: [darktable-dev] compilation error

2016-05-15 Thread johannes hanika
can you kids stop :) ? i don't have gcc6, but am happy to push a couple of white spaces to make silly compilers happy.. fwiw i think -Werror is a good idea in general (i think we take it out for release tarballs, if not we should probably). -jo On Mon, May 16, 2016 at 4:29 AM, Pedro Côrte-Real

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
see https://github.com/darktable-org/darktable/pull/1202 j. On Mon, May 16, 2016 at 5:02 AM, Martijn Kruiten wrote: > Yes, I thought it was amazing too. Thanks for looking into it! > > Op zo 15 mei 2016 om 17:40 schreef johannes hanika : >> >> oh, right. thanks for pointing that out. amazing wh

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread Martijn Kruiten
Yes, I thought it was amazing too. Thanks for looking into it! Op zo 15 mei 2016 om 17:40 schreef johannes hanika : > oh, right. thanks for pointing that out. amazing what a difference > this small change makes. i shall look into pushing that into > rawspeed's camera.xml then. > > -j. > > On Mon,

Re: [darktable-dev] compilation error

2016-05-15 Thread Pedro Côrte-Real
On Sun, May 15, 2016 at 5:23 PM, Roman Lebedev wrote: > Probably the fact that rawspeed is the separate project, and > into darktable's sourcecode that -werror was added exclusively by you? Yeah, git doesn't have shared commits yet so it would be done by a single person. > You break it, you fix

Re: [darktable-dev] compilation error

2016-05-15 Thread Roman Lebedev
On Sun, May 15, 2016 at 5:13 PM, Pedro Côrte-Real wrote: > On Sun, May 15, 2016 at 12:47 PM, Roman Lebedev wrote: >> On Sun, May 15, 2016 at 2:36 PM, Pedro Côrte-Real wrote: >>> It's not my code and I don't have that compiler so I don't have a way >>> of fixing it. >> Sure, but it would not be a

[darktable-dev] weird colours when using several color modules

2016-05-15 Thread Marc Cousin
Hi, I have something wrong in latests git versions: colours are completely wrong as soon as I touch anything in several modules. The most obvious one is color zones: touch anything and the color is completely wrong (everything seems to become purple). I don't know exactly when it started, as I ha

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
oh, right. thanks for pointing that out. amazing what a difference this small change makes. i shall look into pushing that into rawspeed's camera.xml then. -j. On Mon, May 16, 2016 at 3:14 AM, Martijn Kruiten wrote: > Correction: it obviously varies with ISO /and/ some other variables. > > Op zo

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread Martijn Kruiten
Correction: it obviously varies with ISO /and/ some other variables. Op zo 15 mei 2016 om 17:10 schreef Martijn Kruiten : > Your blackpoint was not the same as the value that was reported in the > Google Groups issue. I changed it to be the same and that fixed it, so > that's definitely where the

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread Martijn Kruiten
Your blackpoint was not the same as the value that was reported in the Google Groups issue. I changed it to be the same and that fixed it, so that's definitely where the issue is ( https://www.dropbox.com/s/d3h5uwwoj7xe4w7/DSCF3831-Darktable_blackpointfix.png?dl=0 ). Quote from the group: "Camcon

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
well, we're not using dcraw and the black point (as you can see in the screenshot) is the same as the one in the google groups issue you posted after the fix. possibly the black point is a red herring here. j. On Mon, May 16, 2016 at 2:32 AM, Martijn Kruiten wrote: > Hi Johannes, > > I only push

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread Martijn Kruiten
Hi Johannes, I only pushed a few stops to exaggerate it. I'm seeing green shadows even in well lit daylight ISO 1600 shots without exposure compensation, but i felt this image could demonstrate it much better. Also, in your screenshot the shadows are still green, just less obvious because they are

Re: [darktable-dev] compilation error

2016-05-15 Thread Pedro Côrte-Real
On Sun, May 15, 2016 at 12:47 PM, Roman Lebedev wrote: > On Sun, May 15, 2016 at 2:36 PM, Pedro Côrte-Real wrote: >> It's not my code and I don't have that compiler so I don't have a way >> of fixing it. > Sure, but it would not be an error if not for your -Werror: > https://github.com/darktable-

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
hey, i believe our black point is correct (see screenshot below [0]). it's just a bit much to ask to push a 3200 ISO image by 3 stops and get useful colour rendition out of the box. the rawtherapee shot looks like a different whitebalance/colour profile/curve has been applied? anyways, you're al

[darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread Martijn Kruiten
Hi, There seems to be an issue with the blackpoint for some Fujifilm cameras, or at least the X100 model. I'm not sure if you're using DCRaw as the decoder, but it had and may still have an issue that causes this, which has been patched by RawTherapee after I reported it back in 2013 (https://code

Re: [darktable-dev] compilation error

2016-05-15 Thread Roman Lebedev
On Sun, May 15, 2016 at 2:36 PM, Pedro Côrte-Real wrote: > On Sun, May 15, 2016 at 8:42 AM, Roman Lebedev wrote: >> Or is there no more interest in fixing rawspeed issues? > > It's not my code and I don't have that compiler so I don't have a way > of fixing it. Sure, but it would not be an error

Re: [darktable-dev] compilation error

2016-05-15 Thread Pedro Côrte-Real
On Sun, May 15, 2016 at 8:42 AM, Roman Lebedev wrote: > Or is there no more interest in fixing rawspeed issues? It's not my code and I don't have that compiler so I don't have a way of fixing it. Pedro ___ darktable develope

[darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF

2016-05-15 Thread Matthias Bodenbinder
I re-posted my question on the user list. I think it better placed there. Am 14.05.2016 um 15:34 schrieb Matthias Bodenbinder: > Hi, > > I am struggling with my presets (DT 2.0.4). I have a basecurve preset that is > applied to all my RAW (CR2). Unfortunately the same preset is also applied to

Re: [darktable-dev] Compilation error on Majaro XFCE

2016-05-15 Thread Sebastian
Known issue, see the previous mail thread from today: http://article.gmane.org/gmane.comp.graphics.darktable.devel/7466 and this issue: https://redmine.darktable.org/issues/11009 As temporary fix, you can remove -Werror from the gcc's parameters. Sebastian On 05/15/2016 11:12 AM, João Horta wro

[darktable-dev] Compilation error on Majaro XFCE

2016-05-15 Thread João Horta
darktable-git release.2.1.0.r1031.gdf4eb00-1 (Dom Mai 15 10:10:07 WEST 2016) [ 10%] Building CXX object src/external/rawspeed/CMakeFiles/rawspeed.dir/RawSpeed/OrfDecoder.cpp.o /tmp/yaourt-tmp-jmhorta/aur-darktable-git/src/darktable/src/external/rawspeed/RawSpeed/OrfDecoder.cpp: In member function

Fwd: [darktable-dev] compilation error

2016-05-15 Thread Roman Lebedev
Hi. -- Forwarded message -- From: Marc Cousin Date: Sun, May 15, 2016 at 9:39 AM Subject: [darktable-dev] compilation error To: darktable-dev@lists.darktable.org Hi, this new compilation error has appeared… (gcc 6.1.1 on arch, this has just been upgraded from 5.3) I could simp