Re: [PATCH 0/1] Cygwin: pty: Fix select() with pseudo console support.

letions(-) > > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 1/1] Cygwin: pty: Fix potential state mismatch regarding pseudo console.

Cygwin. He'll build and upload Cygwin test releases during my absence. Please don't hesitate to send more patches as required, Ken will review and eventually push them. Ken, if you like, please generate a new Cygwin test release now. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

ty content, IIRC, but it still seems artificial to enforce a clear screen. Is there no other way to make the pseudo console happy? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Provide more COM devices

here, it will also add some code. Which, unfortunately, raise the size of devices.cc, especially troubling the 32 bit version. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

Hi Takashi, On Oct 19 08:50, Takashi Yano wrote: > Hi Corinna, > > On Fri, 18 Oct 2019 16:33:06 +0200 > Corinna Vinschen wrote: > > Sorry, but this doesn't look feasible. > > > > You can't base the behaviour on the name of an application. What about &

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

On Oct 21 19:55, Takashi Yano wrote: > On Mon, 21 Oct 2019 11:43:56 +0200 > Corinna Vinschen wrote: > > So it seems cmd.exe is the only (or one of few) native CLI tools > > actually trying to manipulate the screen buffer. And what it does is > > not so much clearing

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

On Oct 22 09:09, Takashi Yano wrote: > On Mon, 21 Oct 2019 11:43:56 +0200 > Corinna Vinschen wrote: > > So it seems cmd.exe is the only (or one of few) native CLI tools > > actually trying to manipulate the screen buffer. And what it does is > > not so much clearing

Re: [PATCH] Cygwin: Provide more COM devices

On Oct 21 20:10, Achim Gratz wrote: > Corinna Vinschen writes: > > That's not the right way to patch this. devices.cc gets generated from > > devices.in by the gendevices script which in turn calls shilka from the > > cocom package. > > Now that you mention it I

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

On Oct 22 16:23, Takashi Yano wrote: > On Tue, 22 Oct 2019 08:55:06 +0200 > Corinna Vinschen wrote: > > On Oct 22 09:09, Takashi Yano wrote: > > > I confirmed the dwSize has right screen size and dwCursorPosition > > > is (0,0) just after creating pty even though the

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

t to quickly provide > a test case with pty.openpty() combined with all the tty settings used there. > > I've started to extract the important bits, but that may take a while. OTOH, > this is an open source project if you like to try yourself: prefix.gentoo.org > > Thanks! > /haubi/ In terms of clearing the screen at all, what's your opinion, Michael? Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

On Oct 22 18:24, Takashi Yano wrote: > On Tue, 22 Oct 2019 10:02:42 +0200 > Corinna Vinschen wrote: > > On Oct 22 16:23, Takashi Yano wrote: > > > On Tue, 22 Oct 2019 08:55:06 +0200 > > > Corinna Vinschen wrote: > > > > On Oct 22 09:09, Takashi Yano w

Re: [PATCH] Cygwin: Provide more COM devices

On Oct 22 19:36, Achim Gratz wrote: > Corinna Vinschen writes: > >> So how about we only do this on 64bit as an added bonus for folks who > >> "get it"? > > > > I'm not hot on doing that, and I'm not sure shilka likes ifdef's >

Re: [PATCH] Cygwin: Provide more COM devices

evices.in: Provide for 128 COM devices since Windows > likes to create lots of these over time (one per identifiable device > and USB port). Pushed with regenerated devices.cc. I took the liberty to tweak the log message a bit. We don't do CVS-style log entries for quite some t

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

Hi Takashi, On Oct 23 12:27, Takashi Yano wrote: > On Tue, 22 Oct 2019 15:40:48 +0200 > Corinna Vinschen wrote: > > Am I doing something wrong? This code crashes mintty on my > > installation. At start, a string of "6n6n6n6n..." appears and then > > mintty e

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

On Oct 24 10:01, Takashi Yano wrote: > Hi Corinna, > > On Wed, 23 Oct 2019 14:05:42 +0200 > Corinna Vinschen wrote: > > In my limited testing it seems to work nicely. > > Isn't the screen contents before opening pty cleared when cmd.exe is > executed? Well, what

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

On Oct 24 19:17, Takashi Yano wrote: > On Thu, 24 Oct 2019 11:38:17 +0200 > Corinna Vinschen wrote: > > Well, what I see when starting cmd.exe with this patch is a short > > flicker in the existing output in mintty, but the cursor position > > stays the same. and cmd.e

Re: [PATCH] Cygwin: getpriority() consistent with process priority

gt; case PRIO_PGRP: >if (!who) > -- > 2.8.3 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Provide more COM devices

On Nov 3 20:13, Achim Gratz wrote: > Corinna Vinschen writes: > […] > > ttyS%(0-255) takes another 23K btw. Even that should be ok, if > > the need arises. Alternatively we could shortcut shilka as for > > /dev/sd*, but that involved much bigger numbers. >

Re: [PATCH] Cygwin: console, pty: Prevent error in legacy console mode.

if (reg.error ()) > +error = true; > + if (reg.get_dword (L"ForceV2", 1) == 0) > +error = true; > + if (error) > +{ >CloseHandle (from_master); >CloseHandle (to_slave); > from_master = from_master_cyg; > -- > 2.21.0 Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Change how to determine if running as service or not.

lEqualSid (well_known_interactive_sid, pGroupInfo->Groups[i].Sid)) > - return false; > - return true; > + return check_token_membership (well_known_service_sid) > +|| cygheap->user.saved_sid () == well_known_system_sid; > } > > bool > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

winsup/cygwin/fhandler.h | 1 + > winsup/cygwin/fhandler_console.cc | 46 --- > winsup/cygwin/fhandler_tty.cc | 14 ++ > 4 files changed, 46 insertions(+), 17 deletions(-) Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Raise dumpstack frame limit to 32

r\n"); > } >small_printf ("End of stack trace%s\n", > - i == 16 ? " (more stack frames may be present)" : ""); > + i == DUMPSTACK_FRAME_LIMIT ? > + " (more stack frame

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

Hi Takashi, On Oct 24 15:33, Corinna Vinschen wrote: > On Oct 24 19:17, Takashi Yano wrote: > > On Thu, 24 Oct 2019 11:38:17 +0200 > > Corinna Vinschen wrote: > > > Well, what I see when starting cmd.exe with this patch is a short > > > flicker in the existing

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

On Nov 8 21:01, Takashi Yano wrote: > Hi Corinna, > > On Fri, 8 Nov 2019 10:22:30 +0100 > Corinna Vinschen wrote: > > Pushed, albeit I'm still missing a bit of description here. Just a one > > liner is a bit low on info during `git log'. I'd really appre

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

is something you just expected to work but then didn't. With your patch it now works as you expected. So it's kind of a bugfix, rather than a change of behaviour the user needs to learn about. The above text is, IMHO, more confusing than helpful to a user just asking for regtool --help. I'd just drop it. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Disable clear screen for ssh sessions with -t option.

Hi Takashi, On Nov 8 22:42, Takashi Yano wrote: > Hi Corinna, > > On Fri, 8 Nov 2019 12:09:55 +0100 > Corinna Vinschen wrote: > > On Oct 24 15:33, Corinna Vinschen wrote: > > > On Oct 24 19:17, Takashi Yano wrote: > > > > On Thu, 24 Oct 2019 11:38:

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

On Nov 11 10:13, Corinna Vinschen wrote: > Hi Brian, > > > The patch idea is nice. Two nits, though. > > Please shorten the commit msg summary line and add a bit of descriptive > text instead. > > > On Nov 10 09:14, Brian Inglis wrote: > > -

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

On Nov 11 08:30, Brian Inglis wrote: > On 2019-11-11 02:19, Corinna Vinschen wrote: > > On Nov 11 10:13, Corinna Vinschen wrote: > >> On Nov 10 09:14, Brian Inglis wrote: > >> The patch idea is nice. Two nits, though. > >> Please shorten the commit msg summa

Re: [PATCH] regtool: allow /proc/registry{,32,64}/ registry path prefix

's the reasoning? This should either be a patch on its own or at least this should be mentioned in the commit message. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] regtool: Ignore /proc/registry{,32,64}/ prefix, with forward or backslashes, allowing path completion

On Nov 11 13:47, Brian Inglis wrote: > On 2019-11-11 09:28, Corinna Vinschen wrote: > > Ok, we can add something to the help text, but the text still sounds > > confusing, even the altenative one. I think the reason is the negative > > expression "ignore" here. Why

Re: [PATCH] Cygwin: pty: Use redraw screen instead of clear screen.

| 2 +- > winsup/cygwin/tty.h | 2 +- > 3 files changed, 18 insertions(+), 16 deletions(-) Great! Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: console: Revise the code checking if the console is legacy.

sg00099.html > --- > winsup/cygwin/fhandler_console.cc | 29 +++-- > 1 file changed, 15 insertions(+), 14 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: cygrunsrv patch

://cygwin.com/git/cygwin-apps/cygrunsrv.git Patches to cygrunsrv should be sent to the cygwin-apps ML, though, not to cygwin-patches, but given the low traffic here anyway, that's ok, too. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] regtool: allow /proc/registry{,32,64}/ registry path prefix

On Nov 13 09:46, Corinna Vinschen wrote: > Hi Brian, > > On Nov 11 10:29, Brian Inglis wrote: > > The user can supply the registry path prefix /proc/registry{,32,64}/ to > > use path completion. > > The git commit message does not outline why you're changing

Re: [PATCH] Cygwin: pty: Trigger redraw screen if ESC[?3h or ESC[?3l is sent.

+ nlen && isdigit (*p0)) > + arg = arg * 10 + (*p0 ++) - '0'; > + if (arg == 3) > + get_ttyp ()->need_redraw_screen = true; > + if (p0 < buf + nlen && *p0 == ';') > + p0 ++; > + } > + p0 ++; >

Re: [PATCH] Cygwin: pty: Trigger redraw screen if ESC[?3h or ESC[?3l is sent.

On Nov 14 10:35, Corinna Vinschen wrote: > Hi Takashi, > > On Nov 13 19:49, Takashi Yano wrote: > > - Pseudo console clears console screen buffer if ESC[?3h or ESC[?3l > > is sent. However, xterm/vt100 does not clear screen. This cause Btw., this is not pseudo console beha

Re: [PATCH] cygrunsrv: Added options -T and -X; fixed a couple minor issues

ed, 115 insertions(+), 34 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Trigger redraw screen if ESC[?3h or ESC[?3l is sent.

On Nov 14 20:51, Takashi Yano wrote: > Hi Corinna, > > On Thu, 14 Nov 2019 10:35:41 +0100 > Corinna Vinschen wrote: > > This is only correct if xterm hasn't been started with the c132 widget > > resource set to 'true'. This resource specifies whether the ES

Re: [PATCH] Cygwin: pty: Convert CamelCase names to snake_case names.

c | 8 ++-- > winsup/cygwin/spawn.cc| 18 > winsup/cygwin/tty.cc | 2 +- > winsup/cygwin/tty.h | 8 ++-- > 8 files changed, 60 insertions(+), 60 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer

Re: newlib/libc/include/sys/features.h: Cygwin Unicode level

gt; version 10/11/12: Sure, please go ahead! Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] newlib/libc/include/sys/features.h: update __STDC_ISO_10646__

TDC_ISO_10646__ 200910L > +/* > + * newlib's wide char conversion functions were updated on > + * 2019-01-12 > + * to UNICODE version: > + * 11.0.0 released 2018-06-05 > + */ > +#define __STDC_ISO_10646__ 201806L > > #endif /* __CYGWIN__ */ > >

Re: [PATCH] Cygwin: /proc/[PID]/stat to pull process priority correctly

Re: [PATCH] Cygwin: pty: Fix a bug regarding ESC[?3h and ESC[?3l handling.

f (arg == 3) > - get_ttyp ()->need_redraw_screen = true; > + exist_arg_3 = true; > if (p0 < buf + nlen && *p0 == ';') > p0 ++; > } > + if (p0 < buf + nlen && exist_arg_3 && (*p0 == 'h&#x

Re: [PATCH] Cygwin: pty: Fix ESC[?3h and ESC[?3l handling again.

7;)) > { > int arg = 0; > while (p0 < buf + nlen && isdigit (*p0)) > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: FIFO: use FILE_PIPE_REJECT_REMOTE_CLIENTS flag

gt;FILE_PIPE_BYTE_STREAM_TYPE = 0, > - FILE_PIPE_MESSAGE_TYPE = 1 > + FILE_PIPE_MESSAGE_TYPE = 1, > + FILE_PIPE_REJECT_REMOTE_CLIENTS = 2 > }; > > typedef struct _FILE_PIPE_PEEK_BUFFER { > -- > 2.21.0 Thanks, please push. Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2 0/3] Support opening a symlink with O_PATH | O_NOFOLLOW

map(2)) ^ fail with the error EBADF. ^ ^ That'd from the current F31 man pages. > Am I missing something? Good question. Let me ask in return, did *I* now miss something? Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: fhandler_socket::open: support the O_PATH flag

gt; + set_flags (flags); Shouldn't that only work with AF_LOCAL/AF_UNIX sockets? This looks like it will return a valid descriptor even for IP sockets. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: Add missing Linux #define of CPU_SETSIZE

CPU_EQUAL_S(sizeof (cpu_set_t), src1, src2) > > +#define CPU_SETSIZE __CPU_SETSIZE > #endif /* __GNU_VISIBLE */ > > #ifdef __cplusplus > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Fixed crash on wine by adding NULL check after memchr

onst uint8_t *movedi = pushedi + 1; > -- > 2.17.1 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Fix the issue regarding open and close multiple PTYs.

handle leakage we had in execve lately. But then again, given that Cygwin uses EXTENDED_STARTUPINFO_PRESENT anyway, wouldn't it makes sense to pass the required handles with PROC_THREAD_ATTRIBUTE_HANDLE_LIST to avoid having to open the parent with PROCESS_DUP_HANDLE? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Add missing CloseHandle() calls.

ease move this struct to some header? Even if it's not a really close match, maybe ntdll.h works best, combined with a short comment what this is about... Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Remove destructor for fhandler_pty_master class.

s wait, helper process for pseudo console > - sometimes remains running after the pty session is > - closed. The reason is not clear. */ > - if (to_master && from_master) > -Sleep (20); > -} > - > int > fhandler_pty_master::open (int flags, mode_t) > { > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Revise the code for setting code page of pseudo console.

On Jan 1 15:50, Takashi Yano wrote: > - Fix the problem which overrides the code page setting, reported > in https://www.cygwin.com/ml/cygwin/2019-12/msg00292.html. > --- Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: console: Disable xterm mode for non cygwin process only.

MINAL_INPUT */ > + I think it's about time to move these definitions into a header, rather than defining them in three different places. winlean.h might be the right place for them. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: console: Add workaround for broken CSI3J in Win10 1809.

tion = true; > + /* Workaround for broken CSI3J (ESC[3J) support in kterm compatible mode. > */ ^^^^^ xterm? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: console: Add code to restore console mode on close.

le they work fine again in the first cmd when returning to it. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: console: Make suspending process work properly.

{ > stat = input_signalled; > -- > 2.21.0 Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: select: Speed up select() call for pty, pipe and fifo.

s patch > applies same strategy to them as well. Pushed. And thanks for testing, Marco! Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2 0/3] Support opening a symlink with O_PATH | O_NOFOLLOW

On Jan 13 16:53, Ken Brown wrote: > On 1/13/2020 10:28 AM, Corinna Vinschen wrote: > > On Dec 29 17:56, Ken Brown wrote: > >> [...] > >> Note: The man page mentions fchownat and linkat also. linkat already > >> supports the AT_EMPTY_PATH flag, so nothing

Re: [PATCH v2 0/3] Support opening a symlink with O_PATH | O_NOFOLLOW

On Jan 13 19:34, Corinna Vinschen wrote: > On Jan 13 16:53, Ken Brown wrote: > > On 1/13/2020 10:28 AM, Corinna Vinschen wrote: > > > On Dec 29 17:56, Ken Brown wrote: > > >> [...] > > >> Note: The man page mentions fchownat and linkat also. linkat alre

Re: [PATCH] Cygwin: select: Speed up select() call for pty, pipe and fifo.

On Jan 13 22:17, Marco Atzeri wrote: > Am 13.01.2020 um 17:33 schrieb Corinna Vinschen: > > On Jan 6 23:38, Takashi Yano wrote: > > > - The slowing down issue of X11 forwarding using ssh -Y, reported > > >in https://www.cygwin.com/ml/cygwin/2019-12/msg00295.html, &g

Re: [PATCH] Cygwin: console: Add code to restore console mode on close.

On Jan 14 10:37, Takashi Yano wrote: > Hi Corinna, welcome back! > > On Mon, 13 Jan 2020 17:25:53 +0100 > Corinna Vinschen wrote: > > On Jan 2 22:17, Takashi Yano wrote: > > > - The console with 24bit color support has a problem that console > > > mode is c

Re: [PATCH] Cygwin: normalize_win32_path: allow drive without trailing backslash

;src += 4; > - if (isdrive (src) && isdirsep (src[2])) > + if (isdrive (src) && (isdirsep (src[2]) || !src[2])) > beg_src_slash = false; >else if (!strncmp (src, "UNC", 3) && isdirsep (src[3])) > /* native UNC path */ > -- > 2.21.0 Looks good, please push. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: allow opening an AF_LOCAL/AF_UNIX socket with O_PATH

perform some basic testing? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: allow opening an AF_LOCAL/AF_UNIX socket with O_PATH

On Jan 17 10:48, Corinna Vinschen wrote: > On Jan 16 18:34, Ken Brown wrote: > > If that flag is not set, or if an attempt is made to open a different > > type of socket, the errno is now EOPNOTSUPP instead of ENXIO. This is > > consistent with POSIX, starting with the 2

Re: [PATCH v3 2/3] Cygwin: readlinkat, fchownat: allow pathname to be empty

gt; + __leave; > + if (!(cfd->issymlink () > + && cfd->get_flags () & O_PATH > + && cfd->get_flags () & O_NOFOLLOW)) > + __leave; > + strcpy (path, cfd->get_name ()); > + } >return readlink (path, buf, bufsize); > } >__except (EFAULT) {} > -- > 2.21.0 Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: allow opening an AF_LOCAL/AF_UNIX socket with O_PATH

On Jan 19 20:25, Ken Brown wrote: > On 1/17/2020 4:51 AM, Corinna Vinschen wrote: > > On Jan 17 10:48, Corinna Vinschen wrote: > >> On Jan 16 18:34, Ken Brown wrote: > >>> If that flag is not set, or if an attempt is made to open a different > >>> t

Re: [PATCH v4 0/4] Support opening a symlink with O_PATH | O_NOFOLLOW

++- > winsup/doc/new-features.xml | 19 +++ > 3 files changed, 94 insertions(+), 12 deletions(-) This looks good to me. Please push. I just wonder if this isn't new feature enough to bump the Cygwin version to 3.2... Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

quires an addition to the documentation in winsup/doc/cygwinenv.xml. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Revise code waiting for forwarding by master_fwd_thread.

erimental value or is that based on knowledge of implementation details? The real question is, isn't there any other, more reliable indicator to see if forwarding will work? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v4 0/4] Support opening a symlink with O_PATH | O_NOFOLLOW

On Jan 20 14:57, Ken Brown wrote: > On 1/20/2020 4:56 AM, Corinna Vinschen wrote: > > On Jan 17 16:10, Ken Brown wrote: > >> Currently, opening a symlink with O_NOFOLLOW fails with ELOOP. > >> Following Linux, the first patch in this series allows the call to >

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding by master_fwd_thread.

, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Fix reopening slave in push_to_pcon_screenbuffer().

1.html. This > patch fixes the issue. Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Remove close() call just before reopening slave.

ffer (const > char *ptr, size_t len) > { >termios_printf ("GetConsoleMode failed, %E"); >/* Re-open handles */ > - this->close (); >this->open (0, 0); >/* Fix pseudo console window size */ >this->ioctl (TIOCSWINSZ,

Re: [PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

ures1, 4, "rdpru");/* user level rd proc reg */ > /* ftcprint (features1, 6, "mba"); */ /* memory BW alloc */ > ftcprint (features1, 9, "wbnoinvd"); /* wbnoinvd instruction */ > /* ftcprint (features1, 12, "

Re: [PATCH] Cygwin: pty: Add missing console API hooks.

nsoleScreenBufferA() > * ScrollConsoleScreenBufferW() Which Cygwin programs are doing that? They wouldn't work correctly in ptys anyway, isn't it? Does it really make sense to make them happy rather than requesting to change them? Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

this change, but isn't there any other way to detect if the pseudo console being ready? E. g., something in the HPCON_INTERNAL struct or so? Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Add missing console API hooks.

Hi Takashi, On Jan 23 22:05, Takashi Yano wrote: > On Thu, 23 Jan 2020 13:48:13 +0100 > Corinna Vinschen wrote: > > On Jan 23 13:33, Takashi Yano wrote: > > > - Following console APIs are additionally hooked for cygwin programs > > &

Re: [PATCH 0/3] Fix the O_PATH support for FIFOs

; Cygwin: re-implement fhandler_fifo::open with O_PATH > Cygwin: FIFO: tweak fcntl and dup when O_PATH is set > > winsup/cygwin/fhandler.cc | 3 +++ > winsup/cygwin/fhandler_fifo.cc | 15 ++- > 2 files changed, 9 insertions(+), 9 deletions(-) > > -- > 2.21.0 Pushed. I'll create new developer snapshots. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

On Jan 23 23:16, Takashi Yano wrote: > On Thu, 23 Jan 2020 13:51:54 +0100 > Corinna Vinschen wrote: > > On Jan 23 13:30, Takashi Yano wrote: > > > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of > > > cygwin programs which call both p

Re: [PATCH] Cygwin: console: Share readahead buffer within the same process.

se those accessor methods throughout: > - else if ((newrabuf = (char *) realloc (rabuf, rabuflen += 32))) > - rabuf = newrabuf; else if ((newrabuf = (char *) realloc (rabuf (), rabuflen () += 32))) rabuf () = newrabuf; etc. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.

On Jan 27 13:22, Takashi Yano wrote: > On Mon, 27 Jan 2020 11:38:22 +0900 > Takashi Yano wrote: > > On Sun, 26 Jan 2020 22:33:19 +0900 > > Takashi Yano wrote: > > > On Sat, 25 Jan 2020 20:38:37 +0900 > > > Takashi Yano wrote: > > > > On Fri, 24

Re: [PATCH v2] Cygwin: console: Share readahead buffer within the same process.

ygwin/fhandler_console.cc | 40 +- > winsup/cygwin/fhandler_termios.cc | 35 +-- > winsup/cygwin/fhandler_tty.cc | 2 +- > 5 files changed, 111 insertions(+), 55 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v5] Cygwin: pty: Revise code waiting for forwarding again.

gt; winsup/cygwin/fhandler_tty.cc | 37 +-- > winsup/cygwin/tty.cc | 1 + > winsup/cygwin/tty.h | 1 + > 4 files changed, 34 insertions(+), 6 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 0/3] Some O_PATH fixes

ated on new FIFOs and frixed that (I think). However, Cygwin doesn't actually return the real permissions in stat(), only the constant perms 0666, kind of like for symlinks. I didn't have time to look into that yet, but it would be great if we could fix that, too. Thanks, Corinna -- Cori

Re: [PATCH 0/3] Some O_PATH fixes

On Jan 29 03:08, Ken Brown wrote: > On 1/28/2020 3:48 PM, Ken Brown wrote: > > On 1/28/2020 2:01 PM, Ken Brown wrote: > >> On 1/28/2020 12:06 PM, Corinna Vinschen wrote: > >>> On Jan 27 13:21, Ken Brown wrote: > >>>> Ken Brown (3): > >>>>

Re: [PATCH 0/3] Some O_PATH fixes

On Jan 29 10:52, Corinna Vinschen wrote: > On Jan 29 03:08, Ken Brown wrote: > > On 1/28/2020 3:48 PM, Ken Brown wrote: > > > On 1/28/2020 2:01 PM, Ken Brown wrote: > > >> On 1/28/2020 12:06 PM, Corinna Vinschen wrote: > > >>> As outlined on IRC, I

Re: [PATCH v2 4/5] Cygwin: AF_LOCAL: fix fcntl and dup if O_PATH is set

t_wsock::close (); > } > > +int > +fhandler_socket_local::fcntl (int cmd, intptr_t arg) > +{ > + if (get_flags () & O_PATH) > +return fhandler_base::fcntl (cmd, arg); > + else > + return fhandler_socket_wsock::fcntl (cmd, arg); > +} > + > int __reg2 > fhandler_socket_local::fstat (struct stat *buf) > { > -- > 2.21.0 -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: fstat_helper: always use handle in call to get_file_attribute

pc.fai (); > + HANDLE h = get_stat_handle (); /* Should always be pc.handle(). */ > + pfile_all_information pfai = pc.fai (); This lower-casing PFILE_ALL_INFORMATION looks like a typo. Other than that the patch looks ok. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: console: Revise color setting codes in legacy console mode.

2 +- > winsup/cygwin/fhandler_console.cc | 47 ++- > 2 files changed, 28 insertions(+), 21 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Remove meaningless pointer increment.

riteFile (to_slave, "\003", 1, &n, 0); > } > > - line_edit_status status = line_edit (p++, len, ti, &ret); > + line_edit_status status = line_edit (p, len, ti, &ret); >if (status > line_edit_signalled && status != line_edit_pipe_full) >

Re: [PATCH] Cygwin: pty: Use pinfo() rather than kill() with signal 0.

etd. This > patch avoids the issue by not using kill(). Pushed. I'm inclined to release 3.1.3 next week. Is that ok with you or do you anticipate more patches which should go into 3.1.3? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH 0/4] Remove debug codes and organize with some fixes.

initialization for struct pipe_reply. > > winsup/cygwin/fhandler.h | 12 +-- > winsup/cygwin/fhandler_tty.cc | 144 +++--- > winsup/cygwin/select.cc | 23 -- > 3 files changed, 67 insertions(+), 112 deletions(-) > > -- > 2.21.0

Re: [PATCH] Cygwin: pty: Inherit typeahead data between two input pipes.

d, 329 insertions(+), 91 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH] Cygwin: pty: Fix state mismatch caused in mintty.

gt; winsup/cygwin/fhandler_tty.cc | 16 ++-- > winsup/cygwin/fork.cc | 2 ++ > 2 files changed, 16 insertions(+), 2 deletions(-) Pushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

On Feb 8 18:13, Thomas Wolff wrote: > On 22.01.2020 11:06, Corinna Vinschen wrote: > > On Jan 21 22:25, Takashi Yano wrote: > > > - For programs which does not work properly with pseudo console, > > >disable_pcon in environment CYGWIN is introduced. If disable_p

Re: [PATCH] Cygwin: pty: Prevent potential errno overwriting.

rno_save = errno; >/* Re-open handles */ >this->open (0, 0); >/* Fix pseudo console window size */ >this->ioctl (TIOCSWINSZ, &get_ttyp ()->winsize); > + if (errno != errno_save) > + set_errno (errno_save); >if (++r

Re: [PATCH] Cygwin: pty: Add error handling in setup_pseudoconsoe().

ng: return false; } I wouldn't expect that all functions in Cygwin follow this approach yet, but for new code I'd rather see it like this. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

Re: [PATCH v2] Cygwin: pty: Add error handling in setup_pseudoconsole().

ushed. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc Description: PGP signature

<    5   6   7   8   9   10   11   12   13   14   >