On Nov 11 10:13, Corinna Vinschen wrote:
> Hi Brian,
>
>
> The patch idea is nice. Two nits, though.
>
> Please shorten the commit msg summary line and add a bit of descriptive
> text instead.
>
>
> On Nov 10 09:14, Brian Inglis wrote:
> > ---
> > winsup/utils/regtool.cc | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/winsup/utils/regtool.cc b/winsup/utils/regtool.cc
> > index a44d90768..ddb1304cd 100644
> > --- a/winsup/utils/regtool.cc
> > +++ b/winsup/utils/regtool.cc
> > @@ -167,7 +167,9 @@ usage (FILE *where = stderr)
> > " users HKU HKEY_USERS\n"
> > "\n"
> > "If the keyname starts with a forward slash ('/'), the forward slash
> > is used\n"
> > - "as separator and the backslash can be used as escape character.\n");
> > + "as separator and the backslash can be used as escape character.\n"
> > + "If the keyname starts with /proc/registry{,32,64}/, using forward
> > or backward\n"
> > + "slashes, allowing path completion, that part of the prefix is
> > ignored.\n");
>
> Is that really essential user information?
>
> I assume this behaviour is something you just expected to work but then
> didn't. With your patch it now works as you expected. So it's kind of
> a bugfix, rather than a change of behaviour the user needs to learn about.
>
> The above text is, IMHO, more confusing than helpful to a user just
> asking for regtool --help. I'd just drop it.In fact, a descriptive sentence like the above would better serve as part of the commit message, methinks :) Corinna -- Corinna Vinschen Cygwin Maintainer
signature.asc
Description: PGP signature
