Re: FW: special font characters in rxvt

2010-03-31 Thread Christopher Faylor
On Wed, Mar 31, 2010 at 06:31:50PM -0400, Charles Wilson wrote: >On 3/31/2010 4:50 PM, Nellis, Kenneth wrote: >> If rxvt use is to be discouraged, maybe it should be deemphasized >> in the User's Guide under Console Programs: >> >> http://cygwin.com/cygwin-ug-net/using-effectively.html#using-cons

Re: FW: special font characters in rxvt

2010-03-31 Thread Christopher Faylor
On Wed, Mar 31, 2010 at 10:24:23PM -0400, Charles Wilson wrote: >On 3/31/2010 8:27 PM, Christopher Faylor wrote: >> On Wed, Mar 31, 2010 at 06:31:50PM -0400, Charles Wilson wrote: >>> Good idea. How about this (followup to cygwin-patches): >> >> I think you need to

Re: CFA: pseudo-reloc v2

2010-05-05 Thread Christopher Faylor
On Wed, May 05, 2010 at 05:54:29PM +0100, Dave Korn wrote: >[ redirected from cygwin-developers. ] >On 04/10/2009 05:11, Charles Wilson wrote: >[ thread seriously necro'd! ] >> Dave Korn wrote: >>> Charles Wilson wrote: 120 void 121 _pei386_runtime_relocator () 122 { 123

Re: CFA: pseudo-reloc v2

2010-05-05 Thread Christopher Faylor
On Wed, May 05, 2010 at 07:58:20PM +0100, Dave Korn wrote: >On 05/05/2010 18:56, Christopher Faylor wrote: > >> I like the idea but I have a few problems with this, some stylistic and >> some implementation. >> >> Stylistic: > > Those all make sense to me, b

Re: CFA: pseudo-reloc v2

2010-05-05 Thread Christopher Faylor
On Wed, May 05, 2010 at 08:48:28PM +0100, Dave Korn wrote: >On 05/05/2010 20:13, Christopher Faylor wrote: > >> Yeah, I realized that two seconds after sending the message. However, >> is this particular problem really an issue for DLLs? DLLs should get >> thei

Re: CFA: pseudo-reloc v2

2010-05-06 Thread Christopher Faylor
On Wed, May 05, 2010 at 11:07:33PM -0400, Charles Wilson wrote: >On 5/5/2010 3:13 PM, Christopher Faylor wrote: > >> That's basically it and I have it more-or-less coded but I haven't >> finished thinking about DLLs. Maybe that's more complication than is >>

Re: CFA: pseudo-reloc v2

2010-05-07 Thread Christopher Faylor
On Fri, May 07, 2010 at 12:57:13AM -0400, Charles Wilson wrote: >==Aside: >After all my talk about keeping pseudo_reloc.c synchronized, I'm >considering adapting Dave's implementation for MSYS, because I'm pretty >sure that whatever cgf comes up with for "inside cygwin-1.7.6" isn't >going to work v

Re: CFA: pseudo-reloc v2

2010-05-07 Thread Christopher Faylor
I've checked in the change to cause _pei386_runtime_relocator() to be called from the DLL rather than the program. This function is only called by the DLL when the per_process data indicates that it is ok to do so. Otherwise it defaults to the old behavior. Fixing the behavior reported in the cy

Re: [PATCH] fix build warnings for functions without return value

2010-07-28 Thread Christopher Faylor
On Wed, Jul 28, 2010 at 02:11:33PM -0700, Daniel Colascione wrote: >Stop warnings about function not returning a value; the value is meaningless >anyway, but the compiler can't know that. I don't see why this is needed. Cygwin uses -Werror by default so, if gcc 4.3.4 emitted warnings we wouldn't

Re: [PATCH] fix build warnings for functions without return value

2010-07-28 Thread Christopher Faylor
On Wed, Jul 28, 2010 at 04:19:22PM -0700, Daniel Colascione wrote: >> From: cygwin-patches-owner >> >>I don't see why this is needed. Cygwin uses -Werror by default so, if >>gcc 4.3.4 emitted warnings we wouldn't be able to build a release or >>make a snapshot. > >It's because Cygwin uses -Werror

Re: [PATCH] POSIX monotonic clock

2010-08-02 Thread Christopher Faylor
On Mon, Aug 02, 2010 at 03:49:08PM -0500, Yaakov (Cygwin/X) wrote: >Here is an attempt to implement POSIX.1-2004+ Monotonic Clock: > >http://www.opengroup.org/onlinepubs/9699919799/functions/clock_getres.html > >In summary, I took hires_us and changed the resolution to nanoseconds. I >dropped systi

Re: [PATCH] POSIX monotonic clock

2010-08-03 Thread Christopher Faylor
On Tue, Aug 03, 2010 at 09:32:47AM +0200, V??clav Haisman wrote: >This looks like you could get monotonic clock going backwards. That's a good point. We have that very problem here where I work. However, Yaakov isn't adding anything new here so, if this is a problem, it would be a long-standing o

Re: [PATCH] POSIX monotonic clock

2010-08-08 Thread Christopher Faylor
On Sun, Aug 08, 2010 at 12:06:18AM -0500, Yaakov (Cygwin/X) wrote: >On Tue, 2010-08-03 at 10:04 -0400, Christopher Faylor wrote: >> On Tue, Aug 03, 2010 at 09:32:47AM +0200, V??clav Haisman wrote: >> >This looks like you could get monotonic clock going backwards. >> >

Re: [PATCH] implement /proc/filesystems

2010-08-09 Thread Christopher Faylor
On Mon, Aug 09, 2010 at 10:20:53AM +0200, Corinna Vinschen wrote: >On Aug 9 01:22, Yaakov S wrote: >> * fhandler_proc.cc: Add /proc/filesystems virtual file. >> (format_proc_filesystems): New function. >> * mount.cc (fs_names): Move to global scope. Redefine as array >> of { "n

Re: [PATCH] adjust to mingw sysroot

2010-08-09 Thread Christopher Faylor
On Mon, Aug 09, 2010 at 05:38:36PM -0500, Yaakov (Cygwin/X) wrote: >winsup/utils/mingw will break once mingw-* moves into a sysroot. The >attached patch allows for the sysroot without (hopefully) breaking >pre-sysroot installations. > >It may be a bit premature to commit this, but this transition

Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0

2010-08-17 Thread Christopher Faylor
On Tue, Aug 17, 2010 at 02:23:32PM -0500, Yaakov (Cygwin/X) wrote: >On Mon, 2009-08-10 at 04:11 +0100, Dave Korn wrote: >> I tried compiling winsup with GCC-4.5.0 HEAD, and it finds a bunch of >> things >> to complain about (which then break the -Werror build). They are mostly >> "dereferencing

Re: [PATCH] Faster process initialization

2010-09-01 Thread Christopher Faylor
On Wed, Sep 01, 2010 at 08:16:49PM +0200, Magnus Holmgren wrote: >This patch speeds up process initialization on 64-bit systems. Maybe >the comment "Initialize signal processing here ..." should be re-worded >or removed completely. Yes, the fact that the comment makes no sense when moved would be

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

2010-09-06 Thread Christopher Faylor
Thanks for the patch and for all of the work you put into it. On Mon, Sep 06, 2010 at 03:24:09PM +0200, Corinna Vinschen wrote: >The patch is also missing a ChangeLog entry. I only took a quick glance >over the patch itself. The code doesn't look correctly formatted in GNU >style. Also, using t

Re: Mounting /tmp at TMP or TEMP as a last resort

2010-09-08 Thread Christopher Faylor
On Wed, Sep 08, 2010 at 03:27:14PM -0700, Earl Chew wrote: >We have an installation that we deploy to a bunch of workstations. We prefer >if the installation uses the temporary file directory that Windows has already >allocated for the user. > >The entry for /tmp in /etc/fstab, or the directory /tm

Re: Mounting /tmp at TMP or TEMP as a last resort

2010-09-09 Thread Christopher Faylor
On Thu, Sep 09, 2010 at 04:06:34PM -0700, Earl Chew wrote: >On 09/09/2010 2:16 PM, Pierre A. Humblet wrote: >>So, for example, if the user logs in interactively while a cron job (or >>another service) is running, /tmp may be mapped differently than if no >>cron job is running, because TMP may be de

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

2010-09-10 Thread Christopher Faylor
On Fri, Sep 10, 2010 at 05:08:40PM +0200, Corinna Vinschen wrote: >What I'm still mulling over is a good idea to re-use the results of a >former call to readdir in a stat call. One problem here is to make sure >that a subsequent stat call is *really* accessing the same file as the >former readdir

Re: [PATCH] Add fenv.h and support.

2010-09-10 Thread Christopher Faylor
On Fri, Sep 10, 2010 at 09:53:28PM +0100, Dave Korn wrote: > > >Hi folks, > > This patch adds fenv.h and the related support routines in the Cygwin DLL. >It's an entirely unencumbered implementation that I wrote from scratch using >only the public docs for reference. We've been missing this f

Re: [PATCH] Add fenv.h and support.

2010-09-10 Thread Christopher Faylor
On Sat, Sep 11, 2010 at 01:42:49AM +0100, Dave Korn wrote: >On 10/09/2010 22:43, Christopher Faylor wrote: > >> Looks nice to me with one HUGE caveat: Please maintain the pseudo-sorted >> order in cygwin.din. Sorry to have to impose this burden on you. > > No, that'

[ADMINISTRIVIA] mailing list problems

2010-09-13 Thread Christopher Faylor
Apologies to anyone who has tried to send email to the cygwin lists and gotten a "local subject" bounce. This was supposed to only kick in when a keyword in the subject matched a list of blocked keywords but the regex match was screwed up. So a few valid messages (like John Morrison's recent mail

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

2010-09-22 Thread Christopher Faylor
On Wed, Sep 22, 2010 at 07:50:14AM +0200, Yoni Londner wrote: >Hi, > > > I'm not exactly concerned about Linux being way faster accessing an NTFS > > drive. After all it's the OS itself and comes with it's own NTFS driver > > which obviously is streamlined for typical POSIX operations. > >I did no

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

2010-09-28 Thread Christopher Faylor
On Tue, Sep 28, 2010 at 08:56:18AM -0600, Warren Young wrote: >On 9/22/2010 7:44 AM, Christopher Faylor wrote: >> >> What is /mnt/hgfs/C in this case? How is it mounted? > >HGFS is the Host-Guest File System, a VMware technology that lets it >export host volumes to the g

Re: Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

2010-09-28 Thread Christopher Faylor
It's time to move this discussion out of cygwin-patches and into cygwin-developers. I'd appreciate it if people continued over there. cgf

Re: patch to add C99 complex

2010-10-08 Thread Christopher Faylor
On Fri, Oct 08, 2010 at 12:56:56PM +0200, Corinna Vinschen wrote: >On Oct 6 08:01, Marco Atzeri wrote: >> here is the cygwin follow up of the patch >> sent to newlib mailing list. >> >> Marco >> >> +* cygwin.din ( cacos cacosf cacosh cacoshf carg cargf >> + casin casinf casinh ca

Re: missing math functions

2010-10-18 Thread Christopher Faylor
On Mon, Oct 18, 2010 at 04:07:59PM +0100, Marco Atzeri wrote: >llround and llroundf are available in newlib but not >exported in cygwin. > >http://www.cygwin.com/ml/cygwin/2010-10/msg00351.html > >simple path attached to solve the problem. > >changelog: > >* winsup/cygwin/cygwin.din : added l

Re: "regtool -m set" writes 2 extra bytes at the end

2010-10-30 Thread Christopher Faylor
[Apologies for previously sending this as private email. Don't know how that happened] On Sun, Oct 31, 2010 at 03:37:31AM +0300, Dmitry Potapov wrote: >Hi, > >The easiest way to demonstrate the problem is to run the following shell >script: > > >8 --- >regtool -m set /HKEY_LOCAL_MACHINE/SOFTWA

Re: [PATCH] define _PATH_VARTMP

2010-11-02 Thread Christopher Faylor
On Tue, Nov 02, 2010 at 12:06:22PM -0500, Yaakov (Cygwin/X) wrote: >Another glibc-ish define. Patch attached. Looks good. Please apply. I think it's getting to be time for a 1.7.8 release... cgf

Re: [PATCH] cygcheck -s should not imply -d

2011-01-10 Thread Christopher Faylor
On Mon, Jan 10, 2011 at 01:51:02PM +0100, Corinna Vinschen wrote: >On Jan 5 19:50, Jon TURNEY wrote: >> >> Currently, for cygcheck -s implies -d. This seems rather unhelpful. >> >> I'm afraid I've lost the thread which inspired this, but in it the reporter >> provided cygcheck -svr output as re

Re: [PATCH] cygcheck -s should not imply -d

2011-01-13 Thread Christopher Faylor
On Thu, Jan 13, 2011 at 01:33:36PM +0100, Corinna Vinschen wrote: >On Jan 11 14:26, Jon TURNEY wrote: >> On 11/01/2011 08:10, Corinna Vinschen wrote: >> > I wasn't quite sure either, but while running cygcheck with Jon's patch >> > it started to make more sense. We can also change the docs to ask

Re: [PATCH] Crosscompiling cygserver fix

2011-01-28 Thread Christopher Faylor
On Fri, Jan 28, 2011 at 05:54:20PM -0500, John Foley Junk Mail wrote: >I've submitted a fix for a problem I came across while trying to build a >Linux-hosted Cygwin cross compiler. Some of the code in winsup/cygwin relies >on winsup/cygserver/libcygserver.a, which is currently only compiled on >Cyg

Re: [PATCH] Fix bogus fsync() error

2011-02-01 Thread Christopher Faylor
On Tue, Feb 01, 2011 at 09:47:15AM +0100, Corinna Vinschen wrote: >On Jan 31 20:44, Christian Franke wrote: >> If used on raw devices like /dev/sda fsync() always fails with >> EBADRQC (54) because FlushFileBuffers() always fails with >> ERROR_INVALID_FUNCTION (1). >> >> The attached patch fixes t

Re: provide __xpg_strerror_r

2011-02-05 Thread Christopher Faylor
On Sat, Feb 05, 2011 at 01:04:16PM -0700, Eric Blake wrote: >Our strerror_r is lousy (it doesn't even match glibc's behavior); see my >request to the newlib list. We really should just implement strerror_r in errno.cc. It doesn't make sense to have two different implementations cgf

Re: [PATCH] Crosscompiling configure fix

2011-02-07 Thread Christopher Faylor
On Mon, Feb 07, 2011 at 12:58:57PM +0100, Corinna Vinschen wrote: >On Feb 5 21:34, Peter Foley wrote: >> I've submitted a fix for a problem I came across while trying to build a >> Linux-hosted Cygwin cross compiler. While bootstrapping Cygwin the autoconf >> scripts in winsup/cygwin and winsup/

Re: provide __xpg_strerror_r

2011-02-09 Thread Christopher Faylor
On Wed, Feb 09, 2011 at 05:20:59PM -0700, Eric Blake wrote: >On 02/06/2011 02:54 AM, Corinna Vinschen wrote: >>> We already provide our own strerror() (it provides a better experience >>> for out-of-range values that the newlib interface), but we're currently >>> using the newlib strerror_r() (in s

Re: [PATCH] pthread_yield

2011-02-09 Thread Christopher Faylor
On Wed, Feb 09, 2011 at 11:49:58PM -0600, Yaakov (Cygwin/X) wrote: >pthread_yield(3) was part of the POSIX.1c drafts but never made it into >the final standard. Nevertheless, it is provided by Linux[1], >FreeBSD[2], OpenBSD[3], AIX[4], and possibly other *NIXes. > >"On Linux, this function is im

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 03:15:15PM +0100, Corinna Vinschen wrote: >On Feb 10 21:47, jojelino wrote: >> On 2011-02-10 19:02, Corinna Vinschen wrote: >> >> >Also, it would be nice if you would add more words to explain what your >> >patch is doing. Just a patch with no explanation is not very invit

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 11:56:52PM +0900, jojelino wrote: >i am sorry for extra line feed. corrected. >requesting review. >Index: winsup/cygwin/dcrt0.cc >=== >RCS file: /cvs/src/src/winsup/cygwin/dcrt0.cc,v >retrieving revision 1.390

Re: provide __xpg_strerror_r

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 10:50:54AM +0100, Corinna Vinschen wrote: >On Feb 9 21:15, Christopher Faylor wrote: >> On Wed, Feb 09, 2011 at 05:20:59PM -0700, Eric Blake wrote: >> >+/* Newlib's provides declarations for two strerror_r >> >+ variants, according to

Re: provide __xpg_strerror_r

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 10:37:45AM -0700, Eric Blake wrote: >Pushed, and squashed into minor version 236. I've also updated >new-features.sgml. Thanks Eric. cgf

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-03-15 Thread Christopher Faylor
On Tue, Mar 15, 2011 at 08:53:13AM +0100, Corinna Vinschen wrote: >On Mar 14 22:02, Jon TURNEY wrote: >> On 13/03/2011 15:21, Corinna Vinschen wrote: >> > Thanks for the patch, but afaics you don't have a copyright assignment >> > on file with Red Hat. It's unfortunately required for substantial >

Re: [PATCH] Export strchrnul (pending newlib patch)

2011-03-28 Thread Christopher Faylor
On Sun, Mar 27, 2011 at 10:38:16PM -0500, Yaakov (Cygwin/X) wrote: >Here's the Cygwin patch to export strchrnul(3) once accepted in newlib. Cygwin already has an implementation of this named strechr written in assembly language. Maybe we should be exporting that. cgf

Re: [PATCH] Fix return value and errno set by sem_init(), sem_destroy() and sem_close()

2011-03-28 Thread Christopher Faylor
On Mon, Mar 28, 2011 at 11:14:03PM +0100, Jon TURNEY wrote: > >While looking into some mysterious failures of sem_init() in python, I was >somewhat surprised to find the following comment in python/thread_pthread.h: > >> /* >> * As of February 2002, Cygwin thread implementations mistakenly report

Re: patch for icmp.h

2011-03-30 Thread Christopher Faylor
On Wed, Mar 30, 2011 at 11:37:31AM -0700, John Paul Morrison wrote: >This patch adds missing icmp types and definitions needs for source >compatibility, and it seems to work for raw icmp sockets. >My only changes is renaming __USE_BSD which is used by Linux. It doesn't >look like cygwin has an eq

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-03-30 Thread Christopher Faylor
On Wed, Mar 30, 2011 at 11:15:56PM +0200, Corinna Vinschen wrote: >Hi Jon, > >On Mar 15 16:46, Corinna Vinschen wrote: >> On Mar 15 11:04, Christopher Faylor wrote: >> > On Tue, Mar 15, 2011 at 08:53:13AM +0100, Corinna Vinschen wrote: >> > >On Mar 14 22:02, Jon

Re: [PATCH] implement /proc/sysvipc/*

2011-04-01 Thread Christopher Faylor
On Fri, Apr 01, 2011 at 12:05:56PM +0200, Corinna Vinschen wrote: >Chris, do you think there's anything speaking against rearranging this >so that the FH_FS and FH_NETDRIVE definitions are separate from the >stuff under /proc? Or, hang on, we should change all PROC values, >along these lines: > >

Re: [PATCH] make compatible with glibc

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 06:37:25PM -0500, Yaakov (Cygwin/X) wrote: >When building Qt Creator, I encountered a compile error because its code >uses 'major' and 'minor' as variable names. Looking at the current >, which is pulled in automatically by , >makes it obvious why that doesn't work. > >Sinc

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 05:37:38PM -0500, Yaakov (Cygwin/X) wrote: >If you run make clean in winsup/cygwin followed by make -jX, the build >fails because devices.cc is not found; it was removed by make clean but >nothing forced it to be regenerated in time. > >Patch attached. > > >Yaakov > >2011-0

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 07:22:42PM -0500, Yaakov (Cygwin/X) wrote: >On Sun, 2011-04-03 at 19:03 -0400, Christopher Faylor wrote: >> This can't be right. In all of the times that I've run a "make clean", >> I have never needed this. A .o relying on .cc is a gi

Re: [PATCH] make compatible with glibc

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 07:11:51PM -0500, Yaakov (Cygwin/X) wrote: >On Sun, 2011-04-03 at 19:55 -0400, Christopher Faylor wrote: >> >+#define __INSIDE_CYGWIN_GNU_DEV__ >> >> I'd prefer a more descriptive name like "__DONT_DEFINE_INLINE_GNU_DEV" > >The

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 01:07:27AM -0400, Christopher Faylor wrote: >I *am* building on Linux, though, so maybe that's the difference. Nope. It works fine on Windows too. cgf

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 01:34:27AM -0400, Christopher Faylor wrote: >On Mon, Apr 04, 2011 at 01:07:27AM -0400, Christopher Faylor wrote: >>I *am* building on Linux, though, so maybe that's the difference. > >Nope. It works fine on Windows too. I wonder if maybe you somehow

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 01:42:54PM +0100, Jon TURNEY wrote: >On 30/03/2011 22:29, Christopher Faylor wrote: >> On Wed, Mar 30, 2011 at 11:15:56PM +0200, Corinna Vinschen wrote: >>> Chris, are you going to take a look into this patch? >> >> yep. > >Attached is a

Re: [PATCH] fix make after clean

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 02:13:36AM -0500, Yaakov (Cygwin/X) wrote: >On Mon, 2011-04-04 at 00:56 -0500, Yaakov (Cygwin/X) wrote: >> No, I duplicated this on Linux as well (after I tracked down a cocom >> RPM), but that did make me think of other possibilities. The difference >> seems to be if you p

Re: [PATCH] make compatible with glibc

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 04:42:26PM +0200, Corinna Vinschen wrote: >On Apr 4 07:41, Yaakov (Cygwin/X) wrote: >> * include/cygwin/types.h: Move #include to >> end of header so the latter get the dev_t typedef. >> * include/sys/sysmacros.h (gnu_dev_major, gnu_dev_minor, >> gnu_de

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 09:45:09AM -0700, Tor Perkins wrote: > > >I think I've found two problems in fhandler_termios::bg_check(): > > * Cygwin's tcsetpgrp function will return EIO when the process >group for the calling process has no leader. > > * This appears to be caused by a leaderless p

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-04-05 Thread Christopher Faylor
On Tue, Apr 05, 2011 at 05:03:43PM +0100, Jon TURNEY wrote: >On 04/04/2011 15:39, Christopher Faylor wrote: >> On Mon, Apr 04, 2011 at 01:42:54PM +0100, Jon TURNEY wrote: >>> Attached is an updated version of the patch which fixes the warning >>> identified >&

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-04-06 Thread Christopher Faylor
On Wed, Apr 06, 2011 at 12:54:42PM +0100, Jon TURNEY wrote: >On 05/04/2011 17:21, Christopher Faylor wrote: >> On Tue, Apr 05, 2011 at 05:03:43PM +0100, Jon TURNEY wrote: >>> On 04/04/2011 15:39, Christopher Faylor wrote: >> I'm trying to imagine a scenario where it

Re: [PATCH] fix make after clean

2011-04-07 Thread Christopher Faylor
On Wed, Apr 06, 2011 at 07:53:02PM -0500, Yaakov (Cygwin/X) wrote: >On Mon, 2011-04-04 at 10:52 -0400, Christopher Faylor wrote: >> The last time I reported that I was using relative paths in the >> gcc/binutils/winsup directory I was told "Don't do that. It isn't

Re: [PATCH] implement /proc/swaps

2011-04-10 Thread Christopher Faylor
On Sun, Apr 10, 2011 at 08:59:56PM -0500, Yaakov (Cygwin/X) wrote: >This patch implements /proc/swaps, as found on Linux[1]: > >$ cat /proc/swaps >Filename TypeSizeUsedPriority >/cygdrive/c/pagefile.sysfile4192440 16376

Re: [PATCH] Fix for strace manpage

2011-04-12 Thread Christopher Faylor
On Tue, Apr 12, 2011 at 08:17:51PM +0100, Jon TURNEY wrote: > >'man strace' contains the rather confusing text: > >>-T, --toggle >> toggle tracing in a process already being >> >>-u, --usecs >> toggle printing of microseconds timestamp traced. Requires -

Re: [PATCH] pthread_getattr_np, pthread_setschedprio

2011-04-14 Thread Christopher Faylor
On Thu, Apr 14, 2011 at 10:00:32PM -0500, Yaakov (Cygwin/X) wrote: >On Sun, 2011-04-10 at 21:30 -0500, Yaakov (Cygwin/X) wrote: >> This patch adds two pthread functions which appear to be "low-hanging >> fruit". >> >> pthread_setschedprio(3) is a POSIX function[1][2] which changes the >> schedulin

Re: [PATCH] pthread_attr_getstack{,addr}, pthread_getattr_np

2011-05-02 Thread Christopher Faylor
On Mon, May 02, 2011 at 10:33:09AM -0500, Yaakov (Cygwin/X) wrote: >This implements pthread_attr_getstack(), pthread_attr_getstackaddr, and >pthread_getattr_np(), which I need for webkitgtk. > >In essence, I added a stackaddr member to pthread_attr, which is >accessed (slightly differently) by pthr

Re: [PATCH] pthread_attr_getstack{,addr}, pthread_getattr_np

2011-05-03 Thread Christopher Faylor
On Tue, May 03, 2011 at 09:56:35AM +0200, Corinna Vinschen wrote: >On May 2 16:11, Christopher Faylor wrote: >> On Mon, May 02, 2011 at 10:33:09AM -0500, Yaakov (Cygwin/X) wrote: >> >This implements pthread_attr_getstack(), pthread_attr_getstackaddr, and >> >pthread_get

Re: initialize local variable wait_return

2011-05-03 Thread Christopher Faylor
On Wed, May 04, 2011 at 11:11:52AM +0800, Chiheng Xu wrote: >2011-05-04 Chiheng Xu > > * fhandler.cc (fhandler_base_overlapped::wait_overlapped): initialize >local variable wait_return , otherwise, gcc-4.3.4 will not compile it. Sorry but this is the wrong solution to this problem. I rew

Re: initialize local variable wait_return

2011-05-04 Thread Christopher Faylor
On Wed, May 04, 2011 at 05:17:31AM -0500, Yaakov (Cygwin/X) wrote: >On Wed, 2011-05-04 at 02:03 -0400, Christopher Faylor wrote: >> On Wed, May 04, 2011 at 11:11:52AM +0800, Chiheng Xu wrote: >> >2011-05-04 Chiheng Xu >> > >> > * fhandler.cc (fhand

Re: [PATCH] psignal, psiginfo, sys_siglist

2011-05-04 Thread Christopher Faylor
On Wed, May 04, 2011 at 01:18:26PM +0200, Corinna Vinschen wrote: >On May 4 05:52, Yaakov (Cygwin/X) wrote: >> This patch exports psignal() from newlib (once my corresponding patch is >> accepted) and implements psiginfo() and sys_siglist[]. The first two >> are POSIX.1-2008, the latter is in BSD

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-05-05 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 12:23:00PM -0700, Tor Perkins wrote: > >> Thanks for the patch and the report. I'll take a look at this in detail >> in the next couple of days. However, unfortunately, I think this is a >> large enough submission that it requires an assignment form. > >Thanks for looking

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-05-05 Thread Christopher Faylor
On Thu, May 05, 2011 at 08:19:24PM +0200, Corinna Vinschen wrote: >On May 5 19:23, Corinna Vinschen wrote: >> On May 5 13:10, Christopher Faylor wrote: >> > On Mon, Apr 04, 2011 at 12:23:00PM -0700, Tor Perkins wrote: >> > > >> > >> Thanks for the pa

Re: [PATCH] sysinfo

2011-05-06 Thread Christopher Faylor
On Fri, May 06, 2011 at 12:43:22PM +0200, Corinna Vinschen wrote: >Please check in. When you do that, please add ,2010 to the list of copyright dates in sysconf.cc since the file was changed in 2010. cgf

Re: Improvements to fork handling

2011-05-11 Thread Christopher Faylor
On Wed, May 11, 2011 at 10:21:14AM -0400, Ryan Johnson wrote: >On 11/05/2011 10:13 AM, Christopher Faylor wrote: >> On Wed, May 11, 2011 at 09:59:53AM +0200, Corinna Vinschen wrote: >>> On May 11 02:18, Ryan Johnson wrote: >>>> Please find attached five patches [...

Re: Improvements to fork handling (1/5)

2011-05-17 Thread Christopher Faylor
On Tue, May 17, 2011 at 07:14:12AM -0400, Ryan Johnson wrote: >Any feedback on these patches? I'll get to them eventually but I have some other Cygwin stuff which is occupying my attention currently. cgf

Re: [PATCH] error.h

2011-05-17 Thread Christopher Faylor
On Tue, May 17, 2011 at 07:20:47PM -0500, Yaakov (Cygwin/X) wrote: >This patch series adds error.h and the error(3) functions, a GNU >extension: > >http://www.kernel.org/doc/man-pages/online/pages/man3/error.3.html > >I implemented this within Cygwin itself instead of newlib, because it is >a GNU e

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-21 Thread Christopher Faylor
On Sat, May 21, 2011 at 07:26:37PM -0600, Eric Blake wrote: >POSIX says that no other function in the standard should clobber the >strerror buffer. Our strerror_r is a GNU extension, so it can get away >with clobbering the buffer (but if we wanted to fix it, we would have to >separate _my_tls.loca

Re: Improvements to fork handling (1/5)

2011-05-21 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: >Hi all, > >This is the first of a series of patches, sent in separate emails as >requested. > >The first patch allows a child which failed due to address space >clobbers to report cleanly back to the parent. As a result, DLL_LINK >wh

Re: Improvements to fork handling (2/5)

2011-05-21 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: >Hi all, > >This patch has the parent sort its dll list topologically by >dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling >in dependencies automatically, and the latter would then not benefit >from the code wh

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Christopher Faylor
On Sun, May 22, 2011 at 09:04:40AM -0400, Ryan Johnson wrote: >On 21/05/2011 9:41 PM, Christopher Faylor wrote: >> On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: >>> Hi all, >>> >>> This is the first of a series of patches, sent in separate emails

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Christopher Faylor
On Sun, May 22, 2011 at 04:29:18PM -0400, Christopher Faylor wrote: >...I'd prefer that the testing be done in frok:parent when the >child_copy happens for static and dynamic dlls, maybe by adding a dll >function which first checks that the data/bss can be copied to the same &g

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-23 Thread Christopher Faylor
On Mon, May 23, 2011 at 02:45:43PM -0600, Eric Blake wrote: >Just for the record, I'm having a problem self-building cygwin right >now, from what looks like mingw issues: > >/home/eblake/src/winsup/utils/mingw gcc-4 -B./ -shared >-Wl,--image-base,0x6FBC -Wl,--entry,_DllMainCRTStartup@12 mthr.o

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-23 Thread Christopher Faylor
On Mon, May 23, 2011 at 02:52:12PM -0600, Eric Blake wrote: >On 05/23/2011 02:45 PM, Eric Blake wrote: >> On 05/21/2011 07:35 PM, Christopher Faylor wrote: >>> On Sat, May 21, 2011 at 07:26:37PM -0600, Eric Blake wrote: >>>> POSIX says that no other function in t

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Christopher Faylor
On Tue, May 24, 2011 at 12:47:36PM -0400, Ryan Johnson wrote: >The best way to improve performance of this part of fork() would be to >figure out how to force a dll to load in the right place on the first >try. Achieving this admittedly "difficult" task would eliminate multiple >syscalls per dll

Problems with: Improvements to fork handling (2/5)

2011-05-28 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: >This patch has the parent sort its dll list topologically by >dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling >in dependencies automatically, and the latter would then not benefit >from the code which "encour

Re: Improvements to fork handling (3/5)

2011-05-28 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:32:09PM -0400, Ryan Johnson wrote: >This patch fixes a bug in the reserve_at function which caused it to >sometimes reserve space needed by the dll it was supposed to help land. >This happens when the dll tries to land in a free region which overlaps >the desired locat

Re: Problems with: Improvements to fork handling (2/5)

2011-05-28 Thread Christopher Faylor
On Sat, May 28, 2011 at 06:40:30PM -0400, Ryan Johnson wrote: >On 28/05/2011 4:50 PM, Christopher Faylor wrote: >> On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: >>> This patch has the parent sort its dll list topologically by >>> dependencies. Pre

Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Sat, May 28, 2011 at 09:37:49PM -0700, Daniel Colascione wrote: >On 5/28/11 7:35 PM, Ryan Johnson wrote: >> On 28/05/2011 8:23 PM, Christopher Faylor wrote: >>> On Sat, May 28, 2011 at 06:40:30PM -0400, Ryan Johnson wrote: >>>> On 28/05/2011 4:50 PM, Christopher F

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Sun, May 29, 2011 at 01:51:35AM -0400, Ryan Johnson wrote: >So, I defined this small function: > >static void break_cmalloc(int depth, int maxdepth) { > void* x = cmalloc (HEAP_2_DLL, 32); > cfree(x); > if (depth < maxdepth) > break_cmalloc(depth+1, maxdepth); >} > >and calle

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Sun, May 29, 2011 at 12:27:45PM -0400, Christopher Faylor wrote: >On Sun, May 29, 2011 at 01:51:35AM -0400, Ryan Johnson wrote: >>So, I defined this small function: >> >>static void break_cmalloc(int depth, int maxdepth) { >> void* x = cmalloc (HEAP_2_DLL, 32);

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Mon, May 30, 2011 at 02:24:49AM -0400, Christopher Faylor wrote: >On Sun, May 29, 2011 at 12:27:45PM -0400, Christopher Faylor wrote: >>On Sun, May 29, 2011 at 01:51:35AM -0400, Ryan Johnson wrote: >>>So, I defined this small function: >>> >>>static void b

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-05-29 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 09:45:09AM -0700, Tor Perkins wrote: >2011-03-28 Tor Perkins > > * fhandler_termios.cc (fhandler_termios::bg_check): Do not return EIO > when a process group has no leader as this is allowed and does not imply > an orphaned process group. Add a test for orphaned proce

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-30 Thread Christopher Faylor
On Mon, May 30, 2011 at 02:53:51AM -0400, Christopher Faylor wrote: >Actually, I checked in patch 2/5. That completes the set, I think. Nope. I still have to do 4/5. I WILL do that when after sleeping first. cgf

Re: do some adjustment

2011-06-06 Thread Christopher Faylor
On Mon, Jun 06, 2011 at 06:27:25PM +0800, Chiheng Xu wrote: > * dcrt0.cc (dll_crt0_1): remove call to fork_init(). > * fork.cc (fork_init): remove. > * globals.cc (fork_init): add user_data global variable. > * perprocess.h (fork_init): change user_data from macro to variabl

Re: pthread_sigmask bug

2011-07-09 Thread Christopher Faylor
On Sat, Jul 09, 2011 at 07:19:35AM -0600, Eric Blake wrote: >On 07/09/2011 12:58 AM, Corinna Vinschen wrote: >> On Jul 8 17:16, Eric Blake wrote: >>> The current implementation of pthread_sigmask violates POSIX: >> >> PTC? > > winsup/cygwin/ChangeLog |6 ++ > winsup/cygwin/signal.cc | 10

Re: [PATCH] fix for sigsegv in gcc 4.6

2011-07-14 Thread Christopher Faylor
On Wed, Jul 13, 2011 at 04:40:21AM +0900, jojelino wrote: >i think it's about 5 month between preceeding one. >missing WINAPI(__stdcall) which should had been added for function >pointer type is now cause of SIGSEGV. hence it is added. >this changes applies to winsup/cygwin/environ,autoload.cc >w

Re: [PATCH] update sysconf, confstr, limits

2011-07-18 Thread Christopher Faylor
On Mon, Jul 18, 2011 at 05:26:51PM -0500, Yaakov (Cygwin/X) wrote: >This patch adds return values for recent additions to sysconf() and >confstr(), and adds a couple of missing defines required by >POSIX. > >This patch, plus the one just posted to newlib@, are required for my >next patch, a getcon

Re: [PATCH] add getconf(1)

2011-07-19 Thread Christopher Faylor
On Tue, Jul 19, 2011 at 09:43:43AM +0200, Corinna Vinschen wrote: >On Jul 18 21:20, Yaakov (Cygwin/X) wrote: >> This patch adds getconf(1) as required by POSIX: > >This looks good. I'm just wondering... on one hand the code seems to >have nothing Cygwin-specifc and could be packed as an external p

Re: [PATCH] clock_nanosleep(2)

2011-07-20 Thread Christopher Faylor
On Wed, Jul 20, 2011 at 09:56:54AM +0200, Corinna Vinschen wrote: >I haven't much time right now. If cgf doesn't beat me to it, I'll >review the function later. I have a couple of PriA problems to look into at work so I don't have much time either. cgf

Re: [PATCH] workaround for sigproc_init

2011-07-30 Thread Christopher Faylor
On Fri, Jul 29, 2011 at 08:41:10PM +0900, jojelino wrote: >As sigproc_init is called during dll initialization, wait_sig thread is >not created as soon as possible.(this is known in msdn createthread >reference. http://msdn.microsoft.com/en-us/library/ms682453(v=vs.85).aspx) >And then wait_sig st

  1   2   3   4   5   6   7   8   9   10   >