Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Corinna Vinschen
Hi Takashi, looks good, but... On Apr 6 19:57, Takashi Yano wrote: > @@ -1685,7 +1700,15 @@ pthread_key::~pthread_key () > */ >if (magic != 0) > { > - keys.remove (this); > + LONG64 seq = keys[key_idx].seq; > + assert (pthread_key::keys_list::ready (seq) > +

Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Takashi Yano
On Tue, 8 Apr 2025 12:23:24 +0200 Corinna Vinschen wrote: > looks good, but... > > On Apr 6 19:57, Takashi Yano wrote: > > @@ -1685,7 +1700,15 @@ pthread_key::~pthread_key () > > */ > >if (magic != 0) > > { > > - keys.remove (this); > > + LONG64 seq = keys[key_idx].seq; > >

[PATCH] Cygwin: faq: add lssparse to sparse file example

2025-04-08 Thread Christian Franke
From 3944b5b21502e65821a4c30d568207273320347a Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 8 Apr 2025 13:34:02 +0200 Subject: [PATCH] Cygwin: faq: add lssparse to sparse file example Signed-off-by: Christian Franke --- winsup/doc/faq-using.xml | 5 + 1 file changed, 5 insert

Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Corinna Vinschen
On Apr 8 19:37, Takashi Yano wrote: > On Tue, 8 Apr 2025 12:23:24 +0200 > Corinna Vinschen wrote: > > looks good, but... > > > > On Apr 6 19:57, Takashi Yano wrote: > > > @@ -1685,7 +1700,15 @@ pthread_key::~pthread_key () > > > */ > > >if (magic != 0) > > > { > > > - keys.remo

Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Corinna Vinschen
On Apr 8 10:26, Jeremy Drake via Cygwin-patches wrote: > On Sun, 6 Apr 2025, Takashi Yano wrote: > > > Revised. > > Sorry to be late to the party (I didn't open the attachment before, and > only saw the commit): > > > + static class keys_list { > > +LONG64 seq; > > +LONG64 busy_cnt; >

Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Jeremy Drake via Cygwin-patches
On Tue, 8 Apr 2025, Corinna Vinschen wrote: > On Apr 8 10:26, Jeremy Drake via Cygwin-patches wrote: > > On Sun, 6 Apr 2025, Takashi Yano wrote: > > > > > Revised. > > > > Sorry to be late to the party (I didn't open the attachment before, and > > only saw the commit): > > > > > + static class k

[PATCH] Cygwin: termios: Implement tcflow(), tcdrain(), TCXONC, TIOCINQ

2025-04-08 Thread Takashi Yano
Previously, tcflow() and tcdrain() were missing from console and pty. ioctl() command: TCXONC, TIOCINQ, and TCFLSH were also missing. Due to this, "stress-ng --pty 1" failed. This patch implements them. Signed-off-by: Takashi Yano --- winsup/cygwin/fhandler/console.cc | 30

Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Jeremy Drake via Cygwin-patches
On Sun, 6 Apr 2025, Takashi Yano wrote: > Revised. Sorry to be late to the party (I didn't open the attachment before, and only saw the commit): > + static class keys_list { > +LONG64 seq; > +LONG64 busy_cnt; Should these be `volatile`? busy_cnt is probably OK, it only seems to be dea

Re: [PATCH] Cygwin: thread: Allow fast_mutex to be acquired multiple times.

2025-04-08 Thread Takashi Yano
On Tue, 8 Apr 2025 13:52:49 +0200 Corinna Vinschen wrote: > On Apr 8 19:37, Takashi Yano wrote: > > On Tue, 8 Apr 2025 12:23:24 +0200 > > Corinna Vinschen wrote: > > > looks good, but... > > > > > > On Apr 6 19:57, Takashi Yano wrote: > > > > @@ -1685,7 +1700,15 @@ pthread_key::~pthread_key ()

Re: [PATCH] Cygwin: faq: add lssparse to sparse file example

2025-04-08 Thread Corinna Vinschen
On Apr 8 13:51, Christian Franke wrote: > From 3944b5b21502e65821a4c30d568207273320347a Mon Sep 17 00:00:00 2001 > From: Christian Franke > Date: Tue, 8 Apr 2025 13:34:02 +0200 > Subject: [PATCH] Cygwin: faq: add lssparse to sparse file example > > Signed-off-by: Christian Franke > --- > winsu