Re: [PATCH v2 5/5] Cygwin: add find_fast_cwd_pointer_aarch64.

2025-03-27 Thread Corinna Vinschen
On Mar 27 10:28, Jeremy Drake via Cygwin-patches wrote: > > Naah, I don't know. > > > > If you ask me, I would introduce a new directory aarch64 and > > move the fastcwd_aarch64.cc file into that dir. Then rename > > them both to fastcwd.cc. > > > > Makefile.am should add the file to TARGET_FILES=

Re: [PATCH v2 4/5] Cygwin: use udis86 to find fast cwd pointer on x64

2025-03-27 Thread Corinna Vinschen
On Mar 27 10:26, Jeremy Drake via Cygwin-patches wrote: > On Thu, 27 Mar 2025, Corinna Vinschen wrote: > > > Hi Jeremy, > > > > ok, three questions... > > > > Q1: How does it compare performancewise to the old code? Fortunately > > it's only called once per process tree, so this shoudn't have

Re: [PATCH v2 4/5] Cygwin: use udis86 to find fast cwd pointer on x64

2025-03-27 Thread Jeremy Drake via Cygwin-patches
On Thu, 27 Mar 2025, Corinna Vinschen wrote: > On Mar 27 10:26, Jeremy Drake via Cygwin-patches wrote: > > comment, it seems 8.0 is the odd-version-out here. > > Yeah, but we don't support 8.0 anymore, only 8.1. > > > BTW, something I would *like* to do but haven't figured out how to > > accomplis

Re: [PATCH v2 4/5] Cygwin: use udis86 to find fast cwd pointer on x64

2025-03-27 Thread Jeremy Drake via Cygwin-patches
On Thu, 27 Mar 2025, Corinna Vinschen wrote: > Hi Jeremy, > > ok, three questions... > > Q1: How does it compare performancewise to the old code? Fortunately > it's only called once per process tree, so this shoudn't have much > impact, but still nice to know... How would you go about fi

Re: [PATCH v2 5/5] Cygwin: add find_fast_cwd_pointer_aarch64.

2025-03-27 Thread Jeremy Drake via Cygwin-patches
> Naah, I don't know. > > If you ask me, I would introduce a new directory aarch64 and > move the fastcwd_aarch64.cc file into that dir. Then rename > them both to fastcwd.cc. > > Makefile.am should add the file to TARGET_FILES= for x86_64, i.e. > > If/when we later add a native aarch64 target, yo

Re: [PATCH v2 4/5] Cygwin: use udis86 to find fast cwd pointer on x64

2025-03-27 Thread Jeremy Drake via Cygwin-patches
On Thu, 27 Mar 2025, Corinna Vinschen wrote: > > comment, it seems 8.0 is the odd-version-out here. > > Yeah, but we don't support 8.0 anymore, only 8.1. Should I drop the else if case that only handled 8.0 then?

Re: [PATCH v2 5/5] Cygwin: add find_fast_cwd_pointer_aarch64.

2025-03-27 Thread Corinna Vinschen
On Mar 26 16:53, Jeremy Drake via Cygwin-patches wrote: > From: Jeremy Drake > > This works for aarch64 hosts when the target is aarch64, x86_64, or i686, > with only a small #if block in one function that needs to care. > > Signed-off-by: Jeremy Drake > --- > winsup/cygwin/Makefile.am

Re: [PATCH v2 0/5] find_fast_cwd_pointer rewrite

2025-03-27 Thread Corinna Vinschen
On Mar 26 16:45, Jeremy Drake via Cygwin-patches wrote: > v2 splits the vendoring of libudis86 into importing the original files and > then patching them (and adding them to Makefile.am at that point). It > also has both x86_64 and aarch64 implementations exit loops on rets or > unconditional jump

[PATCH] Cygwin: pipe: Fix hang due to inadvertent 0-length raw_write()

2025-03-27 Thread Johannes Schindelin
It is possible for `NtQueryInformationFile()` to report a 0-length `InboundQuota` when obtaining `FilePipeLocalInformation`. This seems to be the case e.g. when a pipe was created on the other side and its quota information is not available on the client side. This can lead to a situation where th

Re: [PATCH v2 4/5] Cygwin: use udis86 to find fast cwd pointer on x64

2025-03-27 Thread Corinna Vinschen
Hi Jeremy, ok, three questions... Q1: How does it compare performancewise to the old code? Fortunately it's only called once per process tree, so this shoudn't have much impact, but still nice to know... Q2: Would you mind to add more comments? On Mar 26 16:52, Jeremy Drake via Cygwin-

Re: [PATCH 2/4] Cygwin: vendor libudis86 1.7.2

2025-03-27 Thread Corinna Vinschen
On Mar 26 10:49, Jeremy Drake via Cygwin-patches wrote: > On Mon, 24 Mar 2025, Corinna Vinschen wrote: > > > Hi Jeremy, > > > > On Mar 21 16:47, Jeremy Drake via Cygwin-patches wrote: > > > From: Jeremy Drake > > > > > > This does not include the source files responsible for generating AT&T- > >

[PATCH] Cygwin: Fix compatibility with GCC 15

2025-03-27 Thread Thirumalai Nagalingam
Hello, Please find my patch attached for review. Summary of Changes: - GCC 15 defaults to `-std=gnu23`, causing build failures in `testsuite` due to outdated C function declarations. This patch updates the function declarations to align with modern standards. - Introduced `cpu_relax.h` to su