On Mar 26 16:53, Jeremy Drake via Cygwin-patches wrote:
> From: Jeremy Drake <cyg...@jdrake.com>
> 
> This works for aarch64 hosts when the target is aarch64, x86_64, or i686,
> with only a small #if block in one function that needs to care.
> 
> Signed-off-by: Jeremy Drake <cyg...@jdrake.com>
> ---
>  winsup/cygwin/Makefile.am        |   1 +
>  winsup/cygwin/fastcwd_aarch64.cc | 203 +++++++++++++++++++++++++++++++
>  winsup/cygwin/path.cc            |  27 +++-
>  3 files changed, 225 insertions(+), 6 deletions(-)
>  create mode 100644 winsup/cygwin/fastcwd_aarch64.cc

Naah, I don't know.

If you ask me, I would introduce a new directory aarch64 and
move the fastcwd_aarch64.cc file into that dir.  Then rename
them both to fastcwd.cc.

Makefile.am should add the file to TARGET_FILES= for x86_64, i.e.

if TARGET_X86_64
TARGET_FILES= \
        x86_64/bcopy.S \
        x86_64/fastcwd.cc \
        aarch/fastcwd.cc \
        [...]
#endif

If/when we later add a native aarch64 target, you should have
only one file aarch/fastcwd.cc, which is built into Cygwin if
TARGET_X86_64 and in a second block defining TARGET_FILES= for
TARGET_AARCH64.

Make sense?


Thanks,
Corinna

Reply via email to