On Feb 11 16:13, Jeremy Drake via Cygwin-patches wrote:
> On Tue, 11 Feb 2025, Corinna Vinschen wrote:
>
> > On Feb 10 17:13, Jeremy Drake via Cygwin-patches wrote:
> > > make mappings linked list in order rather than reverse order.
> >
> > Why? I'm not asking for myself, but for the commit messa
Hi Jeremy,
your patch is basically fine, and I was about to push it, when I
realized that I don't quite understand this:
On Feb 12 10:56, Jeremy Drake via Cygwin-patches wrote:
> struct mntent *
> mount_info::getmntent (int x)
> {
>if (x < 0 || x >= nmounts)
> -return cygdrive_getmnten
On Wed, 12 Feb 2025, Jeremy Drake via Cygwin-patches wrote:
> On Wed, 12 Feb 2025, Jeremy Drake via Cygwin-patches wrote:
>
> > It was *supposed* to not return the second one. Maybe I broke it when
> > trying to break out of the loop early... I will test this scenario and
> > see why it doesn't
The existing code only stored the first mount for each volume, but now
we store the complete list, and split it into a linked list. This will
be used in a subsequent commit to populate cygdrive mount entries.
Signed-off-by: Jeremy Drake
---
winsup/cygwin/local_includes/mount.h | 11 ---
win
They are exposed via the getmntent API and proc filesystem entries
dealing with mounts. This allows things like `df` to show volumes
that are only mounted on directories, not on drive letters.
Addresses: https://cygwin.com/pipermail/cygwin/2025-February/257251.html
Signed-off-by: Jeremy Drake
--
Previously, if there was an explicit mount entry for a drive letter
(say, C:), the output of the corresponding cygdrive mntent (like
/cygdrive/c) would be suppressed. Once Windows directory mounts were
added to cygdrive mounts, the de-duplication code got more complicated.
Instead, always output t
On Wed, 12 Feb 2025, Corinna Vinschen wrote:
> Hi Jeremy,
>
> your patch is basically fine, and I was about to push it, when I
> realized that I don't quite understand this:
>
> What exactly is de-duplicated here?
>
> I have a drive mounted under C:\drvmount.
> I create an additional mount entry:
On 2025-02-12 05:33, Corinna Vinschen wrote:
On Feb 11 16:13, Jeremy Drake via Cygwin-patches wrote:
On Tue, 11 Feb 2025, Corinna Vinschen wrote:
On Feb 10 17:13, Jeremy Drake via Cygwin-patches wrote:
make mappings linked list in order rather than reverse order.
Why? I'm not asking for myse
The existing code only stored the first mount for each volume, but now
we store the complete list, and split it into a linked list. This will
be used in a subsequent commit to populate cygdrive mount entries.
Signed-off-by: Jeremy Drake
---
winsup/cygwin/local_includes/mount.h | 11 ---
win
They are exposed via the getmntent API and proc filesystem entries
dealing with mounts. This allows things like `df` to show volumes
that are only mounted on directories, not on drive letters.
Addresses: https://cygwin.com/pipermail/cygwin/2025-February/257251.html
Signed-off-by: Jeremy Drake
--
On Wed, 12 Feb 2025, Jeremy Drake via Cygwin-patches wrote:
> It was *supposed* to not return the second one. Maybe I broke it when
> trying to break out of the loop early... I will test this scenario and
> see why it doesn't work as expected.
Yeah, I never actually looked at how posix_sorted w
11 matches
Mail list logo
