Re: [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency

Hi Anton, I pushed the first two patches. However... On Jan 14 17:10, Anton Lavrentiev via Cygwin-patches wrote: > --- > winsup/cygwin/libc/minires.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) ...would you mind to shorten your commit caption (aka sub

Re: [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency

On Jan 17 11:39, Corinna Vinschen wrote: > Hi Anton, > > I pushed the first two patches. However... > > On Jan 14 17:10, Anton Lavrentiev via Cygwin-patches wrote: > > --- > > winsup/cygwin/libc/minires.c | 28 ++-- > > 1 file changed, 18 insertions(+), 10 deletions(-) >

[no subject]

Resubmitting the patches with the requested commit message changes

[PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

--- winsup/cygwin/libc/minires.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/libc/minires.c b/winsup/cygwin/libc/minires.c index 0cf9efd9b..fdc6087f5 100644 --- a/winsup/cygwin/libc/minires.c +++ b/winsup/cygwin/libc/minires.c @@ -86,12 +86,12 @@ Re

[PATCH 1/5] Cygwin: resolver: Debug to output both IP and port # in native b.o.

Also, change a few other debug output spots for consitency --- winsup/cygwin/libc/minires.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/winsup/cygwin/libc/minires.c b/winsup/cygwin/libc/minires.c index 0979daae3..0cf9efd9b 100644 --- a

[PATCH 3/5] Cygwin: resolver: Format spec consitency for Windows errors

--- winsup/cygwin/libc/minires-os-if.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/libc/minires-os-if.c b/winsup/cygwin/libc/minires-os-if.c index 6e17de0b8..f71178b96 100644 --- a/winsup/cygwin/libc/minires-os-if.c +++ b/winsup/cygwin/libc/minires-os

[PATCH 5/5] Cygwin: resolver: Added processing of AAAA records

records returned from Windows resolver were flagged as "No structure" in debug output because of being processed (although correctly) in the default catch-all case. This patch makes the records properly recognized. --- winsup/cygwin/libc/minires-os-if.c | 15 +++ 1 file chan

[PATCH 4/5] Cygwin: resolver: A little more consitency in debug messages

--- winsup/cygwin/libc/minires-os-if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/winsup/cygwin/libc/minires-os-if.c b/winsup/cygwin/libc/minires-os-if.c index f71178b96..6b4c5e33e 100644 --- a/winsup/cygwin/libc/minires-os-if.c +++ b/winsup/cygwin/libc/min

RE: resolver //Was: [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency

Hi Corinna, > Other than that, the remaining patches look good, except, adding a short > description what patch 7 does to the commit message would be great for > later readers of the git log. I resubmitted the patches with a little improvement and a better description to the #7 (now #5) as reques

RE: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

> It is reported by 'configure --help', at the appropriate level (although > since enable is the default, I probably should have written > '--disable-doc' here). Can you please make it show as --disable-doc ? Also, can you please make it visible in the top-level configure? Thanks, Anton Lavrent

[PATCH] path_conv: do not get confused by a directory with `.lnk` suffix

When trying to create a directory called `xyz` in the presence of a directory `xyz.lnk`, the Cygwin runtime errors out with an `ENOENT`. The root cause is actually a bit deeper: the `symlink_info::check()` method tries to figure out whether the given path refers to a symbolic link as emulated via

[PATCH] Cygwin: fhandler_base: Fix double free caused when open() fails.

- When open fails, archetype stored in archetypes[] is not cleared. This causes double free when next open fail. This patch fixes the issue. Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250518.html --- winsup/cygwin/fhandler.cc | 4 ++-- winsup/cygwin/release/3.3.4 | 3 +++