On Jan 17 11:39, Corinna Vinschen wrote: > Hi Anton, > > I pushed the first two patches. However... > > On Jan 14 17:10, Anton Lavrentiev via Cygwin-patches wrote: > > --- > > winsup/cygwin/libc/minires.c | 28 ++++++++++++++++++---------- > > 1 file changed, 18 insertions(+), 10 deletions(-) > > ...would you mind to shorten your commit caption (aka subject), at least > to less than 80 chars, and outline your patch in the remainder of the > commit message, please? > > In fact, a short subject and a bit of explaining text in the commit > message is preferrable in general. See the DISCUSSION section in the > git-commit(1) man page.
Oh, and, while we're at it, please add a prefix to the subjects of your remaining patches, i .e. Cygwin: resolver: blah I forget that for the first two patches, but we should do this a bit more thorough. Other than that, the remaining patches look good, except, adding a short description what patch 7 does to the commit message would be great for later readers of the git log. Thanks, Corinna
