Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-07 Thread Christopher Faylor
On Wed, Oct 07, 2009 at 11:49:49AM -0400, Charles Wilson wrote: >Christopher Faylor wrote: > >>> OK. But now...do we need any additional discussion of the patch itself, >>> or did we cover that sufficiently on cygwin-developers? >> >> If you've, as you say "tested" this, > >Yep, and no scare-quote

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-07 Thread Charles Wilson
Christopher Faylor wrote: >> OK. But now...do we need any additional discussion of the patch itself, >> or did we cover that sufficiently on cygwin-developers? > > If you've, as you say "tested" this, Yep, and no scare-quotes needed . > I think we should get this in ASAP. OK. Committed as pos

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-07 Thread Christopher Faylor
On Wed, Oct 07, 2009 at 09:32:10AM -0400, Charles Wilson wrote: >Corinna Vinschen wrote: >> Make the checkin and the ChangeLog one lump. The ChangeLog entry is >> about the work done to put this stuff into Cygwin, which was your work. >> Don't repeat the mingw entry, rather just say that you impor

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-07 Thread Charles Wilson
Corinna Vinschen wrote: > Make the checkin and the ChangeLog one lump. The ChangeLog entry is > about the work done to put this stuff into Cygwin, which was your work. > Don't repeat the mingw entry, rather just say that you imported from > there and credit Kai with that entry. > > Something like

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-07 Thread Corinna Vinschen
On Oct 6 23:03, Christopher Faylor wrote: > On Tue, Oct 06, 2009 at 08:14:59PM -0400, Charles Wilson wrote: > >I just figured it made sense to split up the ChangeLog, because I didn't > >want to take credit for Kai's changes, but I did want to document what I > >did, beyond the mingw/ version (whi

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-06 Thread Christopher Faylor
On Tue, Oct 06, 2009 at 08:14:59PM -0400, Charles Wilson wrote: >> On Tue, Oct 06, 2009 at 07:53:54PM -0400, Charles Wilson wrote: >>>Hence, three separate "entries". One question: when it comes time to >>>commit this to CVS, should it be done all in one lump, or 1-2-3 very >>>quick separate commit

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-06 Thread Charles Wilson
> On Tue, Oct 06, 2009 at 07:53:54PM -0400, Charles Wilson wrote: >>Hence, three separate "entries". One question: when it comes time to >>commit this to CVS, should it be done all in one lump, or 1-2-3 very >>quick separate commits (even though the tree would be broken between, >>say, #1 and #2)?

Re: Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

2009-10-06 Thread Christopher Faylor
On Tue, Oct 06, 2009 at 07:53:54PM -0400, Charles Wilson wrote: >As discussed on cygwin-developers... >http://cygwin.com/ml/cygwin-developers/2009-10/msg00052.html >and thread. Please refer to that thread for the justification of this >patch, and some of the details of its evolution. > >The changel