Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-27 Thread Corinna Vinschen
On Nov 27 16:44, Christian Franke wrote: > Corinna Vinschen wrote: > > And I think your patch here should go in as is, just with the release > > message in release/3.5.5 so we can cherry-pick it to the 3.5 branch. > > Attached. Message moved to 3.5.5 and "Fixes:" changed as suggested. > > From 8

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-27 Thread Christian Franke
Corinna Vinschen wrote: On Nov 27 10:14, Christian Franke wrote: Corinna Vinschen wrote: On Nov 25 21:20, Christian Franke wrote: Corinna Vinschen wrote: - Isn't returning SCHED_FIFO sched_getscheduler() just as wrong? Definitly. SCHED_FIFO is a non-preemptive(!) real-time policy. Windows do

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-27 Thread Corinna Vinschen
On Nov 27 10:14, Christian Franke wrote: > Corinna Vinschen wrote: > > On Nov 25 21:20, Christian Franke wrote: > > > Corinna Vinschen wrote: > > > > - Isn't returning SCHED_FIFO sched_getscheduler() just as wrong? > > > Definitly. SCHED_FIFO is a non-preemptive(!) real-time policy. Windows > > >

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-27 Thread Christian Franke
Corinna Vinschen wrote: On Nov 25 21:20, Christian Franke wrote: Hi Corinna, Corinna Vinschen wrote: Hi Christian, On Nov 25 15:00, Christian Franke wrote: Corinna Vinschen wrote: Fixes: ...? ... the very first commit (cgf 2001) of sched.cc :-) New patch attached. From e95fc1aceb5287f9

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-26 Thread Corinna Vinschen
On Nov 25 21:20, Christian Franke wrote: > Hi Corinna, > > Corinna Vinschen wrote: > > Hi Christian, > > > > On Nov 25 15:00, Christian Franke wrote: > > > Corinna Vinschen wrote: > > > > Fixes: ...? > > > ... the very first commit (cgf 2001) of sched.cc :-) > > > > > > New patch attached. > > >

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-25 Thread Jon Turney
On 25/11/2024 19:15, Corinna Vinschen wrote: Hi Christian, On Nov 25 15:00, Christian Franke wrote: Corinna Vinschen wrote: Fixes: ...? ... the very first commit (cgf 2001) of sched.cc :-) New patch attached. From e95fc1aceb5287f9ad65c6c078125fecba6c6de9 Mon Sep 17 00:00:00 2001 From: Chr

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-25 Thread Christian Franke
Hi Corinna, Corinna Vinschen wrote: Hi Christian, On Nov 25 15:00, Christian Franke wrote: Corinna Vinschen wrote: Fixes: ...? ... the very first commit (cgf 2001) of sched.cc :-) New patch attached. From e95fc1aceb5287f9ad65c6c078125fecba6c6de9 Mon Sep 17 00:00:00 2001 From: Christian Fr

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-25 Thread Corinna Vinschen
Hi Christian, On Nov 25 15:00, Christian Franke wrote: > Corinna Vinschen wrote: > > Fixes: ...? > > ... the very first commit (cgf 2001) of sched.cc :-) > > New patch attached. > > From e95fc1aceb5287f9ad65c6c078125fecba6c6de9 Mon Sep 17 00:00:00 2001 > From: Christian Franke > Date: Mon, 25

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-25 Thread Christian Franke
Corinna Vinschen wrote: Hi Christian, can you please add a Fixes: to the commit messages of both of your patches? On Nov 23 19:56, Christian Franke wrote: sched_setscheduler(pid, sched_getscheduler(pid), param) should behave like sched_setparam(pid, param). -- Regards, Christian From a67e6

Re: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority

2024-11-25 Thread Corinna Vinschen
Hi Christian, can you please add a Fixes: to the commit messages of both of your patches? On Nov 23 19:56, Christian Franke wrote: > sched_setscheduler(pid, sched_getscheduler(pid), param) should behave like > sched_setparam(pid, param). > > -- > Regards, > Christian > > From a67e6679cc2bb19