Hi Christian,

On Nov 25 15:00, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Fixes: ...?
> 
> ... the very first commit (cgf 2001) of sched.cc :-)
> 
> New patch attached.
> 
> From e95fc1aceb5287f9ad65c6c078125fecba6c6de9 Mon Sep 17 00:00:00 2001
> From: Christian Franke <christian.fra...@t-online.de>
> Date: Mon, 25 Nov 2024 14:51:04 +0100
> Subject: [PATCH] Cygwin: sched_setscheduler: allow changes of the priority
> 
> Behave like sched_setparam() if the requested policy is identical
> to the fixed value (SCHED_FIFO) returned by sched_getscheduler().
> 
> Fixes: 6b2a2aa4af1e ("Add missing files.")

Huh, yeah, this is spot on.  I wonder if it would make sense to change
that to 9a08b2c02eea ("* sched.cc: New file.  Implement sched*.")
though, given that was the patch intended to add sched.cc :)))

Sorry, but I have to ask two more questions:

- Isn't returning SCHED_FIFO sched_getscheduler() just as wrong?
  Shouldn't that be SCHED_OTHER, and sched_setscheduler() should check
  for that instead?  Cygwin in a real-time scenario sounds a bit
  far-fetched...

- Don't you want this patch in 3.5.5?  I'd merge the other patch
  into 3.5.5 anyway...


Thanks,
Corinna

Reply via email to