Re: [PATCH v3 0/3] use wincap in format_proc_cpuinfo for user_shstk

2023-06-16 Thread Brian Inglis
On 2023-06-16 13:51, Corinna Vinschen wrote: Hi Brian, On Jun 16 11:17, Brian Inglis wrote: v Fixes: 41fdb869f998 "fhandler/proc.cc(format_proc_cpuinfo): Add Linux 6.3 cpuinfo" ^^

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Philippe Cerfon
On Fri, Jun 16, 2023 at 9:49 PM Corinna Vinschen wrote: > Even a SSD has "disk" in it's name :) That actually stands for drive :-) > Let's keep it at that. I pushed your patchset. Thanks for merging! :-) Any rough estimate when this will be in a live release? Regards and best wishes, Philipp

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Corinna Vinschen
On Jun 16 17:43, Philippe Cerfon wrote: > Hey. > > On Fri, Jun 16, 2023 at 5:04 PM Corinna Vinschen > wrote: > > Oh well. Now that I see it in real life, my idea to use the entire > > expression inline wasn't that great, it seems... > > ^^ > > > > I didn't want to keep MAX_EA_NAME_LEN because

Re: [PATCH v3 0/3] use wincap in format_proc_cpuinfo for user_shstk

2023-06-16 Thread Corinna Vinschen
Hi Brian, On Jun 16 11:17, Brian Inglis wrote: > Fixes: 41fdb869f998 "fhandler/proc.cc(format_proc_cpuinfo): Add Linux 6.3 > cpuinfo" > > In test for for AMD/Intel Control flow Enforcement Technology user mode > shadow stack support replace Windows version tests with test of wincap > member addi

[PATCH v3 3/3] fhandler/proc.cc: use wincap.has_user_shstk

2023-06-16 Thread Brian Inglis
Signed-off-by: Brian Inglis --- winsup/cygwin/fhandler/proc.cc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/fhandler/proc.cc b/winsup/cygwin/fhandler/proc.cc index 3c79762e0fbd..cbc49a12a417 100644 --- a/winsup/cygwin/fhandler/proc.cc +++ b/winsup/cygw

[PATCH v3 2/3] wincap.cc: set wincap member has_user_shstk true for 2004+

2023-06-16 Thread Brian Inglis
Signed-off-by: Brian Inglis --- winsup/cygwin/wincap.cc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/winsup/cygwin/wincap.cc b/winsup/cygwin/wincap.cc index 91d5d9df8889..30d9c14e8d3b 100644 --- a/winsup/cygwin/wincap.cc +++ b/winsup/cygwin/wincap.cc @@ -31,6 +31,7 @@ static co

[PATCH v3 1/3] wincap.h: add wincap member has_user_shstk

2023-06-16 Thread Brian Inglis
Signed-off-by: Brian Inglis --- winsup/cygwin/local_includes/wincap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winsup/cygwin/local_includes/wincap.h b/winsup/cygwin/local_includes/wincap.h index 29a7a63de7f6..c14872787ca2 100644 --- a/winsup/cygwin/local_includes/wincap.h +++ b/wins

[PATCH v3 0/3] use wincap in format_proc_cpuinfo for user_shstk

2023-06-16 Thread Brian Inglis
Fixes: 41fdb869f998 "fhandler/proc.cc(format_proc_cpuinfo): Add Linux 6.3 cpuinfo" In test for for AMD/Intel Control flow Enforcement Technology user mode shadow stack support replace Windows version tests with test of wincap member addition has_user_shstk with Windows version dependent value Si

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Philippe Cerfon
Hey. On Fri, Jun 16, 2023 at 5:04 PM Corinna Vinschen wrote: > Oh well. Now that I see it in real life, my idea to use the entire > expression inline wasn't that great, it seems... ^^ > I didn't want to keep MAX_EA_NAME_LEN because now that we have an > official name for the value, having an u

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Corinna Vinschen
Hi Philippe, On Jun 16 16:09, Philippe Cerfon wrote: > Hey Corinna. > > On Wed, Jun 7, 2023 at 12:06 PM Corinna Vinschen > wrote: > > Hmm, the comparisons would have to check for XATTR_NAME_MAX anyway, > > so maybe inlining is cleaner in this case. > > Please have a look at the updated and atta

Re: [PATCH] include/cygwin/limits.h: add XATTR_{NAME,SIZE,LIST}_MAX

2023-06-16 Thread Philippe Cerfon
Hey Corinna. On Wed, Jun 7, 2023 at 12:06 PM Corinna Vinschen wrote: > Hmm, the comparisons would have to check for XATTR_NAME_MAX anyway, > so maybe inlining is cleaner in this case. Please have a look at the updated and attached patches. Thanks, Philippe. From 82e2ff6f52d7401210247ae396ce3f1f

Re: [PATCH v3 3/3] fhandler/proc.cc: use wincap.has_user_shstk

2023-06-16 Thread Corinna Vinschen
On Jun 16 10:28, Corinna Vinschen wrote: > Hi Brain, > > > thanks for the patch. Sorry to hassle you again, but I forget to mention > this yesterday and I'm still only partially available. So, here goes: > > It would be really great if you could resend your patchset with three > changes in the

Re: [PATCH v3 3/3] fhandler/proc.cc: use wincap.has_user_shstk

2023-06-16 Thread Corinna Vinschen
Hi Brain, thanks for the patch. Sorry to hassle you again, but I forget to mention this yesterday and I'm still only partially available. So, here goes: It would be really great if you could resend your patchset with three changes in the commit message: - For obvious reasons, the message text