On Dec 20 17:48, Ken Brown wrote:
> On 12/20/2024 10:37 AM, Corinna Vinschen wrote:
> > No worries. The expression
> >
> >size_t commit_len = u_len - (start_addr - u_addr);
> >
> > may be right, but it's not generally intelligible. If you'd like
> > to take a stab of changing the code to be
On 12/20/2024 10:37 AM, Corinna Vinschen wrote:
No worries. The expression
size_t commit_len = u_len - (start_addr - u_addr);
may be right, but it's not generally intelligible. If you'd like
to take a stab of changing the code to be more clear, I'm happy.
I'll give it a try.
By the way, t
On Dec 20 10:12, Ken Brown wrote:
> On 12/20/2024 8:13 AM, Corinna Vinschen wrote:
> > In case we're called via fhandler_base::raw_read():
> >
> >Assuming the region to read is enclosing the noreserve() region...
> >
> >- addr = 0x1, len = 256K
> >- rec->get_address() = 0x1000
On 12/20/2024 8:13 AM, Corinna Vinschen wrote:
On Dec 19 18:36, Ken Brown wrote:
I think I'm seeing a similar confusion in
mmap_is_attached_or_noreserve(). I'm tired now and am having trouble
sorting out exactly what that function is doing.
noreserve() pages are MAP_RESERVE pages. Trying to
On Dec 19 18:36, Ken Brown wrote:
> Hi Corinna,
>
> I plan to keep working on mmap issues while you're on vacation. A few
> questions have come up while I've been looking at the code.
>
> 1. The function is_mmapped_region() doesn't seem to be used anywhere. Is it
> OK to remove it?
Yes. Commit
Hi Corinna,
I plan to keep working on mmap issues while you're on vacation. A few
questions have come up while I've been looking at the code.
1. The function is_mmapped_region() doesn't seem to be used anywhere.
Is it OK to remove it?
2. I can't find any uses of filler pages, in spite of t
