Re: mkshortcut (cygutils-1.4.14) free error

2015-10-28 Thread Mark Geisert
Corinna Vinschen writes: > On Oct 28 04:49, Mark Geisert wrote: > > Anthony Heading writes: > > > On the build I made on Windows 10, however, I hit the problem on the > > > very first invocation. I imagine you therefore are building on Windows 7 > > > or earlier, which seems to produce binaries tha

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-28 Thread Corinna Vinschen
On Oct 28 04:49, Mark Geisert wrote: > Anthony Heading writes: > > On the build I made on Windows 10, however, I hit the problem on the > > very first invocation. I imagine you therefore are building on Windows 7 > > or earlier, which seems to produce binaries that work OK. > > Yes, I'm building o

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-27 Thread Mark Geisert
Anthony Heading writes: > > The second issue with the non-absolute path is more problematic. > > Without your second patch, I do see the issue but only on the 2nd or > > later invocation. In other words, if the xyzzy.lnk file does not > > initially exist, the command 'src/mkshortcut/.libs/mkshortcu

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-27 Thread Anthony Heading
On Tue, Oct 27, 2015, at 01:29 AM, Mark Geisert wrote: > I really appreciate the leads and code you've provided. Could we > please discuss only on the Cygwin mailing list? That's the convention > we have, barring extraordinary circumstances :) . It allows for > public review. I believe I did send

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-26 Thread Mark Geisert
Anthony Heading writes: > I didn't hit any explicit configure issue myself, rather a bunch of > unrecognized case-invariant strcmp variants, which took about 10 seconds > to fix but did make me wonder about the source code.And then this > below was the slightly trickier issue: > > % src/mksho

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-26 Thread Anthony Heading
On Mon, Oct 26, 2015, at 03:54 PM, Mark Geisert wrote: > There are configure errors from this process, at least on my > machine. I'll take on maintenance of this package. Give me a short > while to get my sea legs. Thanks Ken for the pointers and Corinna > for the nudge. Thanks Mark. I would t

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-26 Thread Anthony Heading
On Sun, Oct 25, 2015, at 11:57 PM, Mark Geisert wrote: > ...if tmp_str is not modified after the above line, ... Indeed. Unfortunately it is modified. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-26 Thread Mark Geisert
Ken Brown writes: > Anthony Heading wrote: > > Hi, > > I see the cygutils package has been orphaned, perhaps explaining the > > lack of response to the below. > > A related question then is that the vanilla mkshortcut built from the > > latest source package does not > > seem to perfectly match the

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-26 Thread Ken Brown
On 10/25/2015 9:45 PM, Anthony Heading wrote: Hi, I see the cygutils package has been orphaned, perhaps explaining the lack of response to the below. A related question then is that the vanilla mkshortcut built from the latest source package does not seem to perfectly match the behaviour of the b

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-26 Thread Corinna Vinschen
On Oct 26 03:57, Mark Geisert wrote: > Anthony Heading writes: > > I see the cygutils package has been orphaned, perhaps explaining the > > lack of response to the below. > > A related question then is that the vanilla mkshortcut built from the > > latest source package does not > > seem to perfe

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-25 Thread Mark Geisert
Anthony Heading writes: > I see the cygutils package has been orphaned, perhaps explaining the > lack of response to the below. > A related question then is that the vanilla mkshortcut built from the > latest source package does not > seem to perfectly match the behaviour of the binary.Is the

Re: mkshortcut (cygutils-1.4.14) free error

2015-10-25 Thread Anthony Heading
Hi, I see the cygutils package has been orphaned, perhaps explaining the lack of response to the below. A related question then is that the vanilla mkshortcut built from the latest source package does not seem to perfectly match the behaviour of the binary.Is there any way to review or reprod

mkshortcut (cygutils-1.4.14) free error

2015-10-17 Thread Anthony Heading
Seems free() is being called on an adjusted pointer, causing general misbehaviour. A minimal patch below. Anthony --- src/mkshortcut/mkshortcut.c.Orig2015-10-17 21:57:08.0 -0400 +++ src/mkshortcut/mkshortcut.c 2015-10-17 22:16:41.269357400 -0400 @@ -412,7 +412,7 @@ char* exe_nam