Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-25 Thread Takashi Yano
Hi Corinna, On Mon, 23 Mar 2015 11:08:23 +0100 Corinna Vinschen wrote: > With this out of the way, I'm just looking through your patch and it > looks good to me. I have only a few minor style nits: > > + rc ++; > > No space between the variable and the increment operator,

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-24 Thread Corinna Vinschen
Hi Takashi, On Mar 23 11:08, Corinna Vinschen wrote: > On Mar 21 10:40, Takashi Yano wrote: > > Hi Corinna, > > > > On Fri, 20 Mar 2015 20:12:32 +0100 > > Corinna Vinschen wrote: > > > > > > For the time being, can you send your assignment as PDF via email > > > > to my company email address j

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-23 Thread Corinna Vinschen
Hi Takashi, On Mar 21 10:40, Takashi Yano wrote: > Hi Corinna, > > On Fri, 20 Mar 2015 20:12:32 +0100 > Corinna Vinschen wrote: > > > > For the time being, can you send your assignment as PDF via email > > > to my company email address just so > > > we make sure it arrived in *some* way? > >

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-20 Thread Takashi Yano
Hi Corinna, On Fri, 20 Mar 2015 20:12:32 +0100 Corinna Vinschen wrote: > > For the time being, can you send your assignment as PDF via email > > to my company email address just so > > we make sure it arrived in *some* way? > > Even better. We got legal approval that we can use signed PDFs vi

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-20 Thread Corinna Vinschen
Hi Eric, On Mar 20 13:21, Eric Blake wrote: > On 03/20/2015 01:12 PM, Corinna Vinschen wrote: > > Even better. We got legal approval that we can use signed PDFs via > > email alone, and that sending snail mail isn't required anymore. > > Just sendthe PDF to . > > Awesome news! Shouldn't we updat

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-20 Thread Eric Blake
On 03/20/2015 01:12 PM, Corinna Vinschen wrote: > Even better. We got legal approval that we can use signed PDFs via > email alone, and that sending snail mail isn't required anymore. > Just sendthe PDF to . Awesome news! Shouldn't we update the contributor guideline html to match? -- Eric Blak

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-20 Thread Corinna Vinschen
Hi Takashi, On Mar 19 09:34, Corinna Vinschen wrote: > On Mar 19 07:49, Takashi Yano wrote: > > Corinna Vinschen wrote: > > > Just to let you know I didn't forget about you, but your copyright > > > assignment still didn't make it to our office for some reason. > > > [...] > > On 5 March, I sent C

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-19 Thread Corinna Vinschen
Hi Takashi, On Mar 19 07:49, Takashi Yano wrote: > Hi Corrina, s/rrin/rinn/ :) > On Wed, 18 Mar 2015 15:58:54 +0100 > Corinna Vinschen wrote: > > > Just to let you know I didn't forget about you, but your copyright > > assignment still didn't make it to our office for some reason. We > > check

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-18 Thread Takashi Yano
Hi Corrina, On Wed, 18 Mar 2015 15:58:54 +0100 Corinna Vinschen wrote: > Just to let you know I didn't forget about you, but your copyright > assignment still didn't make it to our office for some reason. We > checked late yesterday again. I guess postal service is using rowboats > these days

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-18 Thread Corinna Vinschen
On Mar 18 16:16, Bengt-Arne Fjellner wrote: > On 3/18/15 3:58 PM, Corinna Vinschen wrote: > >Hi Takashi, > > > >On Mar 2 21:05, Takashi Yano wrote: > >>On Sat, 28 Feb 2015 14:59:47 +0100 > >>Corinna Vinschen wrote: > >> > >>>As soon as we have your CA, we can discuss this patch further. > >> > >>

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-18 Thread Bengt-Arne Fjellner
On 3/18/15 3:58 PM, Corinna Vinschen wrote: Hi Takashi, On Mar 2 21:05, Takashi Yano wrote: On Sat, 28 Feb 2015 14:59:47 +0100 Corinna Vinschen wrote: As soon as we have your CA, we can discuss this patch further. Can I send CA form by e-mail? Or should I send it as a postal mail? For t

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-18 Thread Corinna Vinschen
Hi Takashi, On Mar 2 21:05, Takashi Yano wrote: > On Sat, 28 Feb 2015 14:59:47 +0100 > Corinna Vinschen wrote: > > > As soon as we have your CA, we can discuss this patch further. > > Can I send CA form by e-mail? Or should I send it as a postal mail? > > > For the time being, your patch is l

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-05 Thread Corinna Vinschen
On Mar 5 19:22, Takashi Yano wrote: > On Mon, 2 Mar 2015 15:27:23 +0100 > Corinna Vinschen wrote: > > > > > As soon as we have your CA, we can discuss this patch further. > > > > > > Can I send CA form by e-mail? Or should I send it as a postal mail? > > > > Only postal so far, sorry. Maybe w

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-05 Thread Takashi Yano
On Mon, 2 Mar 2015 15:27:23 +0100 Corinna Vinschen wrote: > > > As soon as we have your CA, we can discuss this patch further. > > > > Can I send CA form by e-mail? Or should I send it as a postal mail? > > Only postal so far, sorry. Maybe we can accept signed PDFs via email, > but I only just

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-02 Thread Corinna Vinschen
Hi Takashi, On Mar 2 21:05, Takashi Yano wrote: > On Sat, 28 Feb 2015 14:59:47 +0100 > Corinna Vinschen wrote: > > > As soon as we have your CA, we can discuss this patch further. > > Can I send CA form by e-mail? Or should I send it as a postal mail? Only postal so far, sorry. Maybe we can

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-03-02 Thread Takashi Yano
On Sat, 28 Feb 2015 14:59:47 +0100 Corinna Vinschen wrote: > As soon as we have your CA, we can discuss this patch further. Can I send CA form by e-mail? Or should I send it as a postal mail? > For the time being, your patch is lacking a ChangeLog entry. I scanned > your patch a bit, and it lo

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

2015-02-28 Thread Corinna Vinschen
Hi Takashi, On Feb 28 14:36, Takashi Yano wrote: > Package: cygwin > Version: 1.7.34-6 It's terribly nice of you creating patches for Cygwin, and I'm really looking forward to include patches, but... there's a small problem. If you want to provide non-trivial patches (<= 10 lines) for the Cygwin