Hi Corinna, On Mon, 23 Mar 2015 11:08:23 +0100 Corinna Vinschen <corinna-cyg...@cygwin.com> wrote:
> With this out of the way, I'm just looking through your patch and it > looks good to me. I have only a few minor style nits: > > + rc ++; > > No space between the variable and the increment operator, please. > > + if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp > ()->column == 0) > > Please try to keep lines <= 80 chars: > > + if ((get_ttyp ()->ti.c_oflag & ONOCR) > + && get_ttyp ()->column == 0) Thank you for checking my patch. > However, due to the changes in fhandler_tty.cc, this patch doesn't > apply cleanly anymore. Any chance you could resend it (ideally to the > cygwin-patches ML) diff'ed against git HEAD? I will post a revised patch to cygwin-patches ML soon. Thank you in advance. -- Takashi Yano <takashi.y...@nifty.ne.jp> -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
