Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Ok, so now you need to teach the consumers like NFS to de-interleave the >cookies from the dirents, which isn't all that straight forward because >the dirents are all various sizes. Not a hard problem to solve, but I >don't see what the net gain

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Putting the cookie into the dirent means either changing the size of the dirent struct and breaking the userland ABI (almost as bad as ch

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Poul-Henning Kamp wrote: >> In message <[EMAIL PROTECTED]>, Scott Long writes: >> >> >>>Putting the cookie into the dirent means either changing the size of the >>>dirent struct and breaking the userland ABI (almost as bad as changing >>>the siz

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Putting the cookie into the dirent means either changing the size of the dirent struct and breaking the userland ABI (almost as bad as changing the size of stat, but not quite), or making a 'kdirent' struct and then ma

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Gordon Bergling
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 * Thus spake Simon L. Nielsen ([EMAIL PROTECTED]): > On 2005.11.10 14:04:06 +0100, Gordon Bergling wrote: > > * Thus spake Doug White ([EMAIL PROTECTED]): > > > dwhite 2005-11-09 22:03:50 UTC > > > > > > FreeBSD src repository > > > > > > Mo

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Putting the cookie into the dirent means either changing the size of the >dirent struct and breaking the userland ABI (almost as bad as changing >the size of stat, but not quite), or making a 'kdirent' struct and then >manually shifting and copyi

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Scott Long
Doug White wrote: On Wed, 9 Nov 2005, Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Doug White writes : This is a workaround for a complicated issue involving VFS cookies and devfs. The PR and patch have the details. The ultimate fix requires architectural changes and clarificati

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Simon L. Nielsen
On 2005.11.10 14:04:06 +0100, Gordon Bergling wrote: > Hi, > > * Thus spake Doug White ([EMAIL PROTECTED]): > > dwhite 2005-11-09 22:03:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern vfs_subr.c > > sys/fs/devfs devfs_vnops.c > >

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Gordon Bergling
Hi, * Thus spake Doug White ([EMAIL PROTECTED]): > dwhite 2005-11-09 22:03:50 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > sys/fs/devfs devfs_vnops.c > Log: > This is a workaround for a complicated issue involving VFS cooki

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Bruce Evans writes: The reason it is not in dirent is that UFS/FFS uses dirent as the layout in directories as a microoptimization. >>> >>> I think the reason is exactly the opposite. >> >> Care to elaborate ? > >I think ffs is older than the current `stru

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Bruce Evans
On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Bruce Evans writes: On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: I don't think I've seen any other proposals than to put it in dirent where it rightfully belongs. The reason it is not in dirent is that UFS/FFS use

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: > >> I don't think I've seen any other proposals than to put it in >> dirent where it rightfully belongs. >> >> The reason it is not in dirent is that UFS/FFS uses dirent as the >> layout in directori

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Bruce Evans
On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: I don't think I've seen any other proposals than to put it in dirent where it rightfully belongs. The reason it is not in dirent is that UFS/FFS uses dirent as the layout in directories as a microoptimization. I think the reason is exactly the opp

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Doug White writes: >> The proper fix is to put the cookie in the dirent and abandon the >> microoptimization that UFS/FFS stores struct dirent directly on >> the disk. > >It would be nice if you guys could sit down and figure out just which >"proper fix" you want im

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Doug White
On Wed, 9 Nov 2005, Poul-Henning Kamp wrote: > In message <[EMAIL PROTECTED]>, Doug White writes > : > > > This is a workaround for a complicated issue involving VFS cookies and > > devfs. > > The PR and patch have the details. The ultimate fix requires architectural > > changes and clarificat

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Mike Silbersack
On Wed, 9 Nov 2005, Doug White wrote: dwhite 2005-11-09 22:03:50 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c sys/fs/devfs devfs_vnops.c Log: This is a workaround for a complicated issue involving VFS cookies and devfs. The PR and patch ha

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Doug White writes : > This is a workaround for a complicated issue involving VFS cookies and devfs. > The PR and patch have the details. The ultimate fix requires architectural > changes and clarifications to the VFS API, [...] The proper fix is to put the cooki

cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Doug White
dwhite 2005-11-09 22:03:50 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c sys/fs/devfs devfs_vnops.c Log: This is a workaround for a complicated issue involving VFS cookies and devfs. The PR and patch have the details. The ultimate fix