Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-27 Thread Julian Elischer
David O'Brien wrote: On Wed, Feb 27, 2008 at 11:23:44AM +0100, Dag-Erling Smrgrav wrote: "David O'Brien" <[EMAIL PROTECTED]> writes: Uggg!! Very sorry about that - I was using GENERIC so I could keep an up to date bootable kernel between the commits. GENERIC was broken as well, unionfs is bui

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-27 Thread David O'Brien
On Wed, Feb 27, 2008 at 11:23:44AM +0100, Dag-Erling Smrgrav wrote: > "David O'Brien" <[EMAIL PROTECTED]> writes: > > Uggg!! Very sorry about that - I was using GENERIC so I could keep an up > > to date bootable kernel between the commits. > > GENERIC was broken as well, unionfs is built as a mod

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-27 Thread Dag-Erling Smørgrav
"David O'Brien" <[EMAIL PROTECTED]> writes: > Uggg!! Very sorry about that - I was using GENERIC so I could keep an up > to date bootable kernel between the commits. GENERIC was broken as well, unionfs is built as a module. DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED]

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c src/sys/sys mount.h vnode.h src/sys/ufs/ufs quota.h

2008-02-26 Thread David O'Brien
On Tue, Feb 26, 2008 at 06:25:51PM +, Robert Watson wrote: > To be specific, it's about code on the order of the following -- in the > include file: > vfs_quotactl_t nnpfs_quotactl; > > In the .c file here nnpfs_quotactl is implemented: > int > nnpfs_quotactl(struct mount *mp, int cmd,

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c src/sys/sys mount.h vnode.h src/sys/ufs/ufs quota

2008-02-26 Thread Robert Watson
On Tue, 26 Feb 2008, David E. O'Brien wrote: Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/smbfs smbfs_vfsops.c sys/kern vfs_default.c vfs_vnops.c sys/sys mount.h vnode.h

cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c src/sys/sys mount.h vnode.h src/sys/ufs/ufs quota.h ufs

2008-02-26 Thread David E. O'Brien
obrien 2008-02-26 18:19:49 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/smbfs smbfs_vfsops.c sys/kern vfs_default.c vfs_vnops.c sys/sys

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-26 Thread David O'Brien
On Tue, Feb 26, 2008 at 01:29:57PM +, Robert Watson wrote: > On Tue, 26 Feb 2008, Dag-Erling Sm?rgrav wrote: >> Umm, OK, I didn't spot that. It's unfortunate that David didn't change >> our own file system code to match (or even build LINT, which would have >> shown him the problem), so that

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-26 Thread Dag-Erling Smørgrav
Robert Watson <[EMAIL PROTECTED]> writes: > I'm fine with us discussing how committed we are to VFS being a KPI we > don't break in -STABLE branches, but I'm not fine with the claim that > the KPI wasn't broken by this change. If pushed on the breaking the > KPI point, I would come down on the sid

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c v

2008-02-26 Thread Robert Watson
On Tue, 26 Feb 2008, Dag-Erling Smørgrav wrote: Robert Watson <[EMAIL PROTECTED]> writes: Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: No, it changes neither the API nor the ABI. It replaces caddr_t (which is typedef'd to char *) with void *, and those two are compatible types. I'm sorry,

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-26 Thread Dag-Erling Smørgrav
Robert Watson <[EMAIL PROTECTED]> writes: > Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > > No, it changes neither the API nor the ABI. It replaces caddr_t > > (which is typedef'd to char *) with void *, and those two are > > compatible types. > I'm sorry, but I disagree. The case you failed

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c v

2008-02-26 Thread Robert Watson
On Mon, 25 Feb 2008, Dag-Erling Smørgrav wrote: No, it changes neither the API nor the ABI. It replaces caddr_t (which is typedef'd to char *) with void *, and those two are compatible types. I'm sorry, but I disagree. The case you failed to test involves a function pointer typedef. Here's

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c

2008-02-26 Thread Robert Watson
On Mon, 25 Feb 2008, Kris Kennaway wrote: David E. O'Brien wrote: obrien 2008-02-25 08:55:02 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/smbfs smbfs_vfsops.c sys/ufs/

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-25 Thread Dag-Erling Smørgrav
Kris Kennaway <[EMAIL PROTECTED]> writes: > David E. O'Brien <[EMAIL PROTECTED]> writes: > > [...] > > MFC: Eradicate caddr_t from the VFS API. > Does this change the KAPI on a stable branch? No, it changes neither the API nor the ABI. It replaces caddr_t (which is typedef'd to char *) with voi

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-25 Thread David O'Brien
On Mon, Feb 25, 2008 at 02:43:17AM -0800, David O'Brien (@FreeBSD) wrote: > On Mon, Feb 25, 2008 at 11:35:51AM +0100, Kris Kennaway wrote: > > David E. O'Brien wrote: > >> obrien 2008-02-25 08:55:02 UTC > >> FreeBSD src repository > >> Modified files:(Branch: RELENG_6) > >> sys

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-25 Thread Kris Kennaway
David O'Brien wrote: On Mon, Feb 25, 2008 at 11:35:51AM +0100, Kris Kennaway wrote: David E. O'Brien wrote: obrien 2008-02-25 08:55:02 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vn

2008-02-25 Thread David O'Brien
On Mon, Feb 25, 2008 at 11:35:51AM +0100, Kris Kennaway wrote: > David E. O'Brien wrote: >> obrien 2008-02-25 08:55:02 UTC >> FreeBSD src repository >> Modified files:(Branch: RELENG_6) >> sys/fs/nullfsnull_vfsops.c sys/fs/nwfs >> nwfs_vfsops.c sys/fs/

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops

2008-02-25 Thread Kris Kennaway
David E. O'Brien wrote: obrien 2008-02-25 08:55:02 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/smbfs smbfs_vfsops.c sys/ufs/ufs quota.h ufs_quota.c

cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vnode_

2008-02-25 Thread David E. O'Brien
obrien 2008-02-25 08:55:02 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/smbfs smbfs_vfsops.c sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c sys/kern

cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/kern kern_lock.c vfs_subr.c src/sys/nfs4client nfs4_vfsops.c src/sys/nfsclient nfs_vfsops.c

2008-02-08 Thread Attilio Rao
attilio 2008-02-08 21:45:47 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c sys/kern kern_lock.c vfs_subr.c sys/nfs4client nfs4_vfsops.c sys/nfsclientnfs_vfsops.c Log: Conver all explicit instances to VOP_ISLO

cvs commit: src/sys/fs/nullfs null_vfsops.c

2007-05-27 Thread Robert Watson
rwatson 2007-05-27 13:10:17 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c Log: Rather than entering the debugger via kdb_enter() in the event the root vnode is unexpectedly locked under NULLFS_DEBUG in nullfs and then returning EDEADLK, panic.

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-06-17 Thread Craig Rodrigues
rodrigc 2006-06-17 18:17:26 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c Log: MFC: 1.78, 1.79 Remove incorrect null_checkexp() routine. This will allow the NFS server to call vfs_stdcheckexp() on the exported null

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-05-28 Thread Craig Rodrigues
rodrigc 2006-05-28 22:45:52 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c Log: Remove incorrect null_checkexp() routine. This will allow the NFS server to call vfs_stdcheckexp() on the exported nullfs filesystem, not the underlying filesystem

Re: cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-05-28 Thread Scott Long
Craig Rodrigues wrote: rodrigc 2006-05-28 20:09:18 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c Log: Modify MNT_UPDATE behavior for nullfs so that it does not return EOPNOTSUPP if an "export" parameter was passed in. This should allow null

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-05-28 Thread Craig Rodrigues
rodrigc 2006-05-28 20:09:18 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c Log: Modify MNT_UPDATE behavior for nullfs so that it does not return EOPNOTSUPP if an "export" parameter was passed in. This should allow nullfs mounts to be NFS exporte

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-03-12 Thread Jeff Roberson
jeff2006-03-13 03:05:21 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c Log: MFC Revs 1.77, 1.76, 1.73 VFS SMP fixes, stack api, softupdates fixes. Sponsored by: Isilon Systems, Inc. Approved by:re (scottl

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-02-14 Thread John Baldwin
jhb 2006-02-14 23:15:16 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/fs/nullfsnull_vfsops.c Log: MFC: Correctly set the MPSAFE flag based on the lower vnode's mount. Approved by:re (scottl) Revision ChangesPath 1.72.2.2

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-02-10 Thread John Baldwin
jhb 2006-02-10 18:06:49 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c Log: Correctly set MNTK_MPSAFE flag from the lower vnode's mount rather than always turning it on along with any flags set in the lower mount. Tested by: kris R

cvs commit: src/sys/fs/nullfs null_vfsops.c

2006-02-07 Thread Jeff Roberson
jeff2006-02-07 11:31:33 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c Log: - No need to WANTPARENT when we're just going to vrele it in a deadlock prone way later. Reported by:kkenn MFC After: 3 days Revision Changes

cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/gnu/fs/xfs/FreeBSD xfs_mountops.c src/sys/kern vfs_default.c vfs_vnops.c vnode_if.src

2005-12-13 Thread Dag-Erling Smorgrav
des 2005-12-14 00:49:52 UTC FreeBSD src repository Modified files: sys/fs/nullfsnull_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/smbfs smbfs_vfsops.c sys/gnu/fs/xfs/FreeBSD xfs_mountops.c sys/kern vfs_default.c vfs_vnops.c vno