Re: cvs commit: src/sys/kern vfs_subr.c

2007-03-27 Thread Alfred Perlstein
I'm not sure if it helps, but I recall that PPC memory barriers were pretty much useless except the strongest ones. * Marcel Moolenaar <[EMAIL PROTECTED]> [070327 09:38] wrote: > > On Mar 27, 2007, at 12:43 AM, Kris Kennaway wrote: > > >On Tue, Mar 27, 2007 at 05:29:41AM +, Marcel Moolenaa

Re: cvs commit: src/sys/kern vfs_subr.c

2007-03-27 Thread Kris Kennaway
On Tue, Mar 27, 2007 at 09:36:56AM -0700, Marcel Moolenaar wrote: > > On Mar 27, 2007, at 12:43 AM, Kris Kennaway wrote: > > >On Tue, Mar 27, 2007 at 05:29:41AM +, Marcel Moolenaar wrote: > >>marcel 2007-03-27 05:29:41 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >>

Re: cvs commit: src/sys/kern vfs_subr.c

2007-03-27 Thread Marcel Moolenaar
On Mar 27, 2007, at 12:43 AM, Kris Kennaway wrote: On Tue, Mar 27, 2007 at 05:29:41AM +, Marcel Moolenaar wrote: marcel 2007-03-27 05:29:41 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: PowerPC is the only architecture with mpsafe_vfs=0.

Re: cvs commit: src/sys/kern vfs_subr.c

2007-03-26 Thread Kris Kennaway
On Tue, Mar 27, 2007 at 05:29:41AM +, Marcel Moolenaar wrote: > marcel 2007-03-27 05:29:41 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > Log: > PowerPC is the only architecture with mpsafe_vfs=0. This is now > broken. Rudimentary te

Re: cvs commit: src/sys/kern vfs_subr.c

2006-09-05 Thread Ruslan Ermilov
On Mon, Sep 04, 2006 at 10:15:44PM +, Pawel Jakub Dawidek wrote: > pjd 2006-09-04 22:15:44 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > Log: > Add 'show vnode ' DDB command. > > Revision ChangesPath > 1.682 +18 -2

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-27 Thread Yar Tikhiy
On Thu, May 25, 2006 at 11:23:43PM +0400, Gleb Smirnoff wrote: > On Thu, May 25, 2006 at 10:26:03AM -0400, Stephan Uphoff wrote: > S> Gleb Smirnoff wrote: > S> >On Thu, May 25, 2006 at 01:00:36AM +, Stephan Uphoff wrote: > S> >S> ups 2006-05-25 01:00:36 UTC > S> >S> > S> >S> FreeBSD

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-26 Thread Ken Smith
On Thu, 2006-05-25 at 13:19 -0400, Stephan Uphoff wrote: > Ooopppsss! > > Thanks for the trace. > I just checked in a fix. Thanks for the fast action. It seems to have worked just fine, I can log in on sledge without panic-ing it today. :-) --

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-25 Thread John Baldwin
On Thursday 25 May 2006 15:23, Gleb Smirnoff wrote: > On Thu, May 25, 2006 at 10:26:03AM -0400, Stephan Uphoff wrote: > S> Gleb Smirnoff wrote: > S> >On Thu, May 25, 2006 at 01:00:36AM +, Stephan Uphoff wrote: > S> >S> ups 2006-05-25 01:00:36 UTC > S> >S> > S> >S> FreeBSD src reposit

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-25 Thread Gleb Smirnoff
On Thu, May 25, 2006 at 10:26:03AM -0400, Stephan Uphoff wrote: S> Gleb Smirnoff wrote: S> >On Thu, May 25, 2006 at 01:00:36AM +, Stephan Uphoff wrote: S> >S> ups 2006-05-25 01:00:36 UTC S> >S> S> >S> FreeBSD src repository S> >S> S> >S> Modified files: S> >S> sys/kern

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-25 Thread Stephan Uphoff
Ken Smith wrote: On Thu, 2006-05-25 at 01:00 +, Stephan Uphoff wrote: ups 2006-05-25 01:00:36 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c sys/nfsclientnfs_bio.c sys/fs/smbfs smbfs_io.c sys/fs/nwfs nwf

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-25 Thread Ken Smith
On Thu, 2006-05-25 at 01:00 +, Stephan Uphoff wrote: > ups 2006-05-25 01:00:36 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > sys/nfsclientnfs_bio.c > sys/fs/smbfs smbfs_io.c > sys/fs/nwfs nwfs_io.

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-25 Thread Stephan Uphoff
Gleb Smirnoff wrote: On Thu, May 25, 2006 at 01:00:36AM +, Stephan Uphoff wrote: S> ups 2006-05-25 01:00:36 UTC S> S> FreeBSD src repository S> S> Modified files: S> sys/kern vfs_subr.c S> sys/nfsclientnfs_bio.c S> sys/fs/smbfs smbfs_io.

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/fs/smbfs smbfs_io.c src/sys/fs/nwfs nwfs_io.c

2006-05-25 Thread Gleb Smirnoff
On Thu, May 25, 2006 at 01:00:36AM +, Stephan Uphoff wrote: S> ups 2006-05-25 01:00:36 UTC S> S> FreeBSD src repository S> S> Modified files: S> sys/kern vfs_subr.c S> sys/nfsclientnfs_bio.c S> sys/fs/smbfs smbfs_io.c S> sys/fs/nwfs

Re: cvs commit: src/sys/kern vfs_subr.c

2006-04-04 Thread John Baldwin
On Tuesday 04 April 2006 02:46, Jeff Roberson wrote: > jeff2006-04-04 06:46:10 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > Log: >- VFS_LOCK_GIANT when recycling a vnode via getnewvnode. We may be > recycling for an unrelated

Re: cvs commit: src/sys/kern vfs_subr.c

2006-01-28 Thread Kris Kennaway
On Sat, Jan 28, 2006 at 11:26:24AM +0100, Pawel Jakub Dawidek wrote: > On Sat, Jan 28, 2006 at 03:06:35AM +, Kris Kennaway wrote: > +> kris2006-01-28 03:06:35 UTC > +> > +> FreeBSD src repository > +> > +> Modified files: > +> sys/kern vfs_subr.c > +> Log: > +>

Re: cvs commit: src/sys/kern vfs_subr.c

2006-01-28 Thread Pawel Jakub Dawidek
On Sat, Jan 28, 2006 at 03:06:35AM +, Kris Kennaway wrote: +> kris2006-01-28 03:06:35 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/kern vfs_subr.c +> Log: +> Back out r1.653; it turns out that the race (or at least the printf) is +> actually

Re: cvs commit: src/sys/kern vfs_subr.c

2005-12-29 Thread Pawel Jakub Dawidek
On Thu, Dec 29, 2005 at 10:52:09PM +, Pawel Jakub Dawidek wrote: +> pjd 2005-12-29 22:52:09 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/kern vfs_subr.c +> Log: +> Print a warning when we miss vinactive() call, because of race in vget(). +>

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Ok, so now you need to teach the consumers like NFS to de-interleave the >cookies from the dirents, which isn't all that straight forward because >the dirents are all various sizes. Not a hard problem to solve, but I >don't see what the net gain

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Putting the cookie into the dirent means either changing the size of the dirent struct and breaking the userland ABI (almost as bad as ch

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Poul-Henning Kamp wrote: >> In message <[EMAIL PROTECTED]>, Scott Long writes: >> >> >>>Putting the cookie into the dirent means either changing the size of the >>>dirent struct and breaking the userland ABI (almost as bad as changing >>>the siz

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Putting the cookie into the dirent means either changing the size of the dirent struct and breaking the userland ABI (almost as bad as changing the size of stat, but not quite), or making a 'kdirent' struct and then ma

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Gordon Bergling
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 * Thus spake Simon L. Nielsen ([EMAIL PROTECTED]): > On 2005.11.10 14:04:06 +0100, Gordon Bergling wrote: > > * Thus spake Doug White ([EMAIL PROTECTED]): > > > dwhite 2005-11-09 22:03:50 UTC > > > > > > FreeBSD src repository > > > > > > Mo

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Putting the cookie into the dirent means either changing the size of the >dirent struct and breaking the userland ABI (almost as bad as changing >the size of stat, but not quite), or making a 'kdirent' struct and then >manually shifting and copyi

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Scott Long
Doug White wrote: On Wed, 9 Nov 2005, Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Doug White writes : This is a workaround for a complicated issue involving VFS cookies and devfs. The PR and patch have the details. The ultimate fix requires architectural changes and clarificati

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Simon L. Nielsen
On 2005.11.10 14:04:06 +0100, Gordon Bergling wrote: > Hi, > > * Thus spake Doug White ([EMAIL PROTECTED]): > > dwhite 2005-11-09 22:03:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern vfs_subr.c > > sys/fs/devfs devfs_vnops.c > >

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Gordon Bergling
Hi, * Thus spake Doug White ([EMAIL PROTECTED]): > dwhite 2005-11-09 22:03:50 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > sys/fs/devfs devfs_vnops.c > Log: > This is a workaround for a complicated issue involving VFS cooki

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Bruce Evans writes: The reason it is not in dirent is that UFS/FFS uses dirent as the layout in directories as a microoptimization. >>> >>> I think the reason is exactly the opposite. >> >> Care to elaborate ? > >I think ffs is older than the current `stru

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Bruce Evans
On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Bruce Evans writes: On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: I don't think I've seen any other proposals than to put it in dirent where it rightfully belongs. The reason it is not in dirent is that UFS/FFS use

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-10 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: > >> I don't think I've seen any other proposals than to put it in >> dirent where it rightfully belongs. >> >> The reason it is not in dirent is that UFS/FFS uses dirent as the >> layout in directori

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Bruce Evans
On Thu, 10 Nov 2005, Poul-Henning Kamp wrote: I don't think I've seen any other proposals than to put it in dirent where it rightfully belongs. The reason it is not in dirent is that UFS/FFS uses dirent as the layout in directories as a microoptimization. I think the reason is exactly the opp

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Doug White writes: >> The proper fix is to put the cookie in the dirent and abandon the >> microoptimization that UFS/FFS stores struct dirent directly on >> the disk. > >It would be nice if you guys could sit down and figure out just which >"proper fix" you want im

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Doug White
On Wed, 9 Nov 2005, Poul-Henning Kamp wrote: > In message <[EMAIL PROTECTED]>, Doug White writes > : > > > This is a workaround for a complicated issue involving VFS cookies and > > devfs. > > The PR and patch have the details. The ultimate fix requires architectural > > changes and clarificat

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Mike Silbersack
On Wed, 9 Nov 2005, Doug White wrote: dwhite 2005-11-09 22:03:50 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c sys/fs/devfs devfs_vnops.c Log: This is a workaround for a complicated issue involving VFS cookies and devfs. The PR and patch ha

Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c

2005-11-09 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Doug White writes : > This is a workaround for a complicated issue involving VFS cookies and devfs. > The PR and patch have the details. The ultimate fix requires architectural > changes and clarifications to the VFS API, [...] The proper fix is to put the cooki