Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/geom geom_disk.c

2007-02-21 Thread Jung-uk Kim
On Wednesday 21 February 2007 02:45 am, Nick Hibma wrote: > n_hibma 2007-02-21 07:45:02 UTC > > FreeBSD src repository > > Modified files: > sys/cam/scsi scsi_da.c > sys/geom geom_disk.c > Log: > Reduce the noise when plugging in (USB) mass storage devices, >

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread mjacob
Nothing. I just thought I was suggesting something in-between what we have now and a pure ascii mechanism like hints that requires in-kernel parsing. You are. With mucho respect I would have to say that it doesn't interest me all that much. ___ cv

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Scott Long
Sam Leffler wrote: [EMAIL PROTECTED] wrote: If you just do a module, all you're doing is moving compiled code from one place to another. IMO. My thought was if it's split into a module then you can have alternative modules available at the loader prompt/menu to fallback to. Also if it's split

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Sam Leffler
[EMAIL PROTECTED] wrote: >>> If you just do a module, all you're doing is moving compiled code from >>> one place to another. IMO. >> >> My thought was if it's split into a module then you can have alternative >> modules available at the loader prompt/menu to fallback to. Also if >> it's split out

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread mjacob
If you just do a module, all you're doing is moving compiled code from one place to another. IMO. My thought was if it's split into a module then you can have alternative modules available at the loader prompt/menu to fallback to. Also if it's split out we can probably auto-generate it. umm,

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Scott Long
[EMAIL PROTECTED] wrote: */ -{T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*", +{T_DIRECT, SIP_MEDIA_REMOVABLE, "EM732X", "MP3 Player*", "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE }, }; Thanks. a) It'd be nice if we could move quirks to some sysctl or

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Sam Leffler
[EMAIL PROTECTED] wrote: > >>> >>> a) It'd be nice if we could move quirks to some sysctl or hints format >>> to get out of this tail chasing business. >>> >>> >> There are other databases besides quirks that'd be good to make more >> flexible. Wonder if splitting them into modules would be an >>

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread mjacob
a) It'd be nice if we could move quirks to some sysctl or hints format to get out of this tail chasing business. There are other databases besides quirks that'd be good to make more flexible. Wonder if splitting them into modules would be an improvement? Not as good as a sysctl or a hint b

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Sam Leffler
[EMAIL PROTECTED] wrote: > > >>> */ >>> -{T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*", >>> +{T_DIRECT, SIP_MEDIA_REMOVABLE, "EM732X", "MP3 Player*", >>> "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE >>> }, >>> }; >> >> Thanks. > > a) It'd be nice if we coul

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Nate Lawson <[EMAIL PROTECTED]> writes: : M. Warner Losh wrote: : > In message: <[EMAIL PROTECTED]> : > Nate Lawson <[EMAIL PROTECTED]> writes: : > : M. Warner Losh wrote: : > : > In message: <[EMAIL PROTECTED]> : > : > Nate Lawson

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread mjacob
*/ - {T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*", + {T_DIRECT, SIP_MEDIA_REMOVABLE, "EM732X", "MP3 Player*", "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE }, }; Thanks. a) It'd be nice if we could move quirks to some sysct

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Nate Lawson
Warner Losh wrote: imp 2007-01-23 17:29:31 UTC FreeBSD src repository Modified files: sys/cam/scsi scsi_da.c Log: Use the more specific 'EM732X' designation rather than * to disable sync cache commands, per request from [EMAIL PROTECTED] Revision Changes

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Nate Lawson
M. Warner Losh wrote: In message: <[EMAIL PROTECTED]> Nate Lawson <[EMAIL PROTECTED]> writes: : M. Warner Losh wrote: : > In message: <[EMAIL PROTECTED]> : > Nate Lawson <[EMAIL PROTECTED]> writes: : > : Warner Losh wrote: : > : > imp 2007-01-22 04:34:03 UTC : > :

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Nate Lawson <[EMAIL PROTECTED]> writes: : M. Warner Losh wrote: : > In message: <[EMAIL PROTECTED]> : > Nate Lawson <[EMAIL PROTECTED]> writes: : > : Warner Losh wrote: : > : > imp 2007-01-22 04:34:03 UTC : > : > : > : > FreeBSD src

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Nate Lawson
M. Warner Losh wrote: In message: <[EMAIL PROTECTED]> Nate Lawson <[EMAIL PROTECTED]> writes: : Warner Losh wrote: : > imp 2007-01-22 04:34:03 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/cam/scsi scsi_da.c : > Log: : > Add quirk f

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread Dag-Erling Smørgrav
"M. Warner Losh" <[EMAIL PROTECTED]> writes: > Nate Lawson <[EMAIL PROTECTED]> writes: > > Um, this matches every device that has "MP3 Player" somewhere in it. > > Are you sure it doesn't have a vendor string? > See the PR for details and suggest something better. Off the top of my head, "EM732X"

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-23 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Nate Lawson <[EMAIL PROTECTED]> writes: : Warner Losh wrote: : > imp 2007-01-22 04:34:03 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/cam/scsi scsi_da.c : > Log: : > Add quirk for EasyMP3 EM732X usb 2.0

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2007-01-22 Thread Nate Lawson
Warner Losh wrote: imp 2007-01-22 04:34:03 UTC FreeBSD src repository Modified files: sys/cam/scsi scsi_da.c Log: Add quirk for EasyMP3 EM732X usb 2.0 flash mp3 player. (It appears that the quirk proceedures link has disappeared and that this PR complied with i

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2006-09-16 Thread mjacob
On Sat, 16 Sep 2006, Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Matt Jacob writes : mjacob 2006-09-16 21:21:07 UTC FreeBSD src repository Modified files: sys/cam/scsi scsi_da.c Log: Don't allow attachment of disks that could cause GEOM to panic. The corre

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2006-09-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Matt Jacob writes : >mjacob 2006-09-16 21:21:07 UTC > > FreeBSD src repository > > Modified files: >sys/cam/scsi scsi_da.c > Log: > Don't allow attachment of disks that could cause GEOM to panic. The correct commit message would have been:

Re: cvs commit: src/sys/cam/scsi scsi_da.c

2006-03-18 Thread Nate Lawson
Joerg Wunsch wrote: joerg 2006-03-18 21:13:15 UTC FreeBSD src repository Modified files: sys/cam/scsi scsi_da.c Log: Add reference to PR to TOSHIBA TransMemory quirk entry. Revision ChangesPath 1.189 +1 -0 src/sys/cam/scsi/scsi_da.c Thank you.

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Nate Lawson
Florent Thoumie wrote: On Tuesday 31 January 2006 02:00, Nate Lawson wrote: Florent Thoumie wrote: It seems a lot of devices are concerned by the sync cache problem, would it be harmful to just remove this part of the code or could there be a way to detect if the device supports it or not? W

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Florent Thoumie
On Tuesday 31 January 2006 02:00, Nate Lawson wrote: > Florent Thoumie wrote: > > On Tuesday 31 January 2006 01:24, Nate Lawson wrote: > >>I'm not concerned about the revision. I'm concerned about the vendor > >>(Generic*) and device name (STORAGE DEVICE*). Why are the *'s needed? > > > > Seemed

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Nate Lawson
Florent Thoumie wrote: On Tuesday 31 January 2006 01:24, Nate Lawson wrote: I'm not concerned about the revision. I'm concerned about the vendor (Generic*) and device name (STORAGE DEVICE*). Why are the *'s needed? Seemed common practice reading the other entries. No, that's definitely not

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Florent Thoumie
On Tuesday 31 January 2006 01:24, Nate Lawson wrote: > Florent Thoumie wrote: > > On Tuesday 31 January 2006 00:48, Nate Lawson wrote: > >>Florent Thoumie wrote: > >>>flz 2006-01-30 20:27:44 UTC > >>> > >>> FreeBSD src repository (ports committer) > >>> > >>> Modified files: > >>>sys/

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Nate Lawson
Florent Thoumie wrote: On Tuesday 31 January 2006 00:48, Nate Lawson wrote: Florent Thoumie wrote: flz 2006-01-30 20:27:44 UTC FreeBSD src repository (ports committer) Modified files: sys/cam/scsi scsi_da.c sys/dev/usb umass.c usbdevs Log: - Add a scsi_da.

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Florent Thoumie
On Tuesday 31 January 2006 00:48, Nate Lawson wrote: > Florent Thoumie wrote: > > flz 2006-01-30 20:27:44 UTC > > > > FreeBSD src repository (ports committer) > > > > Modified files: > > sys/cam/scsi scsi_da.c > > sys/dev/usb umass.c usbdevs > > Log: > > - A

Re: cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

2006-01-30 Thread Nate Lawson
Florent Thoumie wrote: flz 2006-01-30 20:27:44 UTC FreeBSD src repository (ports committer) Modified files: sys/cam/scsi scsi_da.c sys/dev/usb umass.c usbdevs Log: - Add a scsi_da.c and a umass.c quirk for Genesys 6-in-1 Card Reader. --- src/sys/ca