Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-20 Thread Dan Fandrich
On Sun, Jul 20, 2014 at 12:38:59PM -0400, dev wrote: > On July 14, 2014 at 1:55 PM Daniel Stenberg wrote: > > On Mon, 14 Jul 2014, Dan Fandrich wrote: > > > > > I have a patch ready to to set _POSIX_PTHREAD_SEMANTICS for Solaris > > > very > > > similar to Mischa Salle's suggestion, and his endors

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-20 Thread dev
On July 16, 2014 at 2:03 PM Tor Arntsen wrote: > On 16 July 2014 17:28, David Woodhouse wrote: > > > Do these autobuilds have GSSAPI support? I suspect not -- Solaris > > appears > > to ship with a krb5-config that doesn't understand 'krb5-config > > gssapi'. > > My Solaris box (same as my two

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-20 Thread dev
On July 14, 2014 at 1:55 PM Daniel Stenberg wrote: > On Mon, 14 Jul 2014, Dan Fandrich wrote: > > > I have a patch ready to to set _POSIX_PTHREAD_SEMANTICS for Solaris > > very > > similar to Mischa Salle's suggestion, and his endorsement of that > > approach > > is a positive sign. If I commit

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-17 Thread David Woodhouse
On Tue, 2014-07-15 at 10:30 +0200, Tor Arntsen wrote: > On 15 July 2014 00:00, Dan Fandrich wrote: > > > I missed your message before I committed the change, but curl isn't using > > any > > of those functions outside getpwuid_r, which confirms that that was the > > right > > approach. And if w

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-16 Thread Tor Arntsen
On 16 July 2014 17:28, David Woodhouse wrote: > Do these autobuilds have GSSAPI support? I suspect not -- Solaris appears > to ship with a krb5-config that doesn't understand 'krb5-config gssapi'. My Solaris box (same as my two Solaris autobuilds) seems to suppor it: $ krb5-config --cflags --li

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-15 Thread Tor Arntsen
On 15 July 2014 00:00, Dan Fandrich wrote: > I missed your message before I committed the change, but curl isn't using any > of those functions outside getpwuid_r, which confirms that that was the right > approach. And if we start using any of the other ones in the future, we can > rest assured t

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Dan Fandrich
On Mon, Jul 14, 2014 at 11:45:06AM +0200, Tor Arntsen wrote: > I did a very quick scan of the Solaris header files, > _POSIX_PTHREAD_SEMANTICS has a lot of overlap with _POSIX_C_SOURCE > but the latter definitely has more impact. From what I could gather > with the minutes I had available this morn

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Daniel Stenberg
On Mon, 14 Jul 2014, Dan Fandrich wrote: I have a patch ready to to set _POSIX_PTHREAD_SEMANTICS for Solaris very similar to Mischa Salle's suggestion, and his endorsement of that approach is a positive sign. If I commit it now, we'll still have a full day of autobuilds to check for Solaris pr

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Dan Fandrich
On Mon, Jul 14, 2014 at 07:18:22PM +0200, Daniel Stenberg wrote: > On Mon, 14 Jul 2014, Dan Fandrich wrote: > > >Problem is, this change broke curl compiles out-of-the-box for > >Solaris. We need to do something by the time of this release. > > My gut says we back out that particular commit for t

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Daniel Stenberg
On Mon, 14 Jul 2014, Dan Fandrich wrote: Problem is, this change broke curl compiles out-of-the-box for Solaris. We need to do something by the time of this release. My gut says we back out that particular commit for the release, then we merge it again post-release with some _POSIX_PTHREAD_SE

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Tor Arntsen
On 14 July 2014 10:28, Dan Fandrich wrote: > I a bit worried that setting > _POSIX_C_SOURCE automatically on Solaris will cause too many other changes. > Setting _POSIX_PTHREAD_SEMANTICS sounds like it would be more isolated to > what's needed in this case, and therefore safer. I did a very quick

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Mischa Salle
Hi, just to mention that for a piece of code I maintain, which also uses getpwnam_r() and getpwuid_r(), I have been using #ifdef __sun # define _POSIX_PTHREAD_SEMANTICS1 #endif which works fine. Note that Solaris manpages are not always 100% accurate with what is needed. It's usually best to a

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-14 Thread Dan Fandrich
On Sun, Jul 13, 2014 at 03:05:04PM +0200, Tor Arntsen wrote: > On 13 July 2014 09:33, Dan Fandrich wrote: > > The Solaris builds failed overnight because their default getpwuid_r uses > > four > > arguments instead of the POSIX standard 5. They do provide a > > POSIX-conformant > > version if yo

Re: getpwuid_r on Solaris and _POSIX_PTHREAD_SEMANTICS

2014-07-13 Thread Tor Arntsen
On 13 July 2014 09:33, Dan Fandrich wrote: > The Solaris builds failed overnight because their default getpwuid_r uses four > arguments instead of the POSIX standard 5. They do provide a POSIX-conformant > version if you compile with the macro _POSIX_PTHREAD_SEMANTICS set. We could > do > a getna