Thanks for confirming. The proposal in PR 6193 looks good to me.
Thanks,
Niranjan.
From: Daniel Stenberg
Date: Monday, November 9, 2020 at 2:51 PM
To: Hasabnis, Niranjan via curl-library
Cc: Hasabnis, Niranjan , Gottschlich, Justin
Subject: Re: Potential confusion in http_proxy.c and a
On Mon, 9 Nov 2020, Hasabnis, Niranjan via curl-library wrote:
We believe that using “if (s->keepon > 1)” would eliminate this confusion
and capture the intended semantics precisely.
I think you've pointed out code that could be written clearer, yes. But I
think an even better improvement to
Hello CURL developers,
My name is Niranjan and I work at Intel. We were recently analyzing various
open-source GitHub repositories for idiosyncratic programming patterns. We came
across “if (s->keepon > TRUE)” pattern at line 360 in lib/http_proxy.c, and we
believe that this pattern is a bit co
