Thanks for confirming. The proposal in PR 6193 looks good to me. Thanks, Niranjan.
From: Daniel Stenberg <dan...@haxx.se> Date: Monday, November 9, 2020 at 2:51 PM To: Hasabnis, Niranjan via curl-library <curl-library@cool.haxx.se> Cc: Hasabnis, Niranjan <niranjan.hasab...@intel.com>, Gottschlich, Justin <justin.gottschl...@intel.com> Subject: Re: Potential confusion in http_proxy.c and a recommendation On Mon, 9 Nov 2020, Hasabnis, Niranjan via curl-library wrote: > We believe that using “if (s->keepon > 1)” would eliminate this confusion > and capture the intended semantics precisely. I think you've pointed out code that could be written clearer, yes. But I think an even better improvement to this logic would be to use an enum or defined values that include all three used values as state names. What do you think about my proposal over at: https://github.com/curl/curl/pull/6193
------------------------------------------------------------------- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
