[coreboot] New Defects reported by Coverity Scan for coreboot

2022-05-17 Thread scan-admin--- via coreboot
Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 5 new defect(s) introduced to coreboot found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Re

[coreboot] Re: [RFC] #pragma once

2022-05-17 Thread Felix Held
Hi Martin, To support #pragma once, the compiler tries to identify duplicate encounters with the same file, but the check gcc actually performs to establish the identity of the file is weak. Here's someone who made two copies of the same header with different names, each with a #pragma once,

[coreboot] Re: Please test and review AGESA code

2022-05-17 Thread Martin Roth via coreboot
Arthur, you are not making an argument that any vendor should release their source code as opensource.  I agree that all of this code should be reviewed, but if we complain about code quality and lack of testing for open sourced code, but don't for closed source, that's an argument against any c

[coreboot] Re: Please test and review AGESA code

2022-05-17 Thread Martin Roth via coreboot
May 17, 2022, 11:40 by coreboot@coreboot.org: > Just my opinion, and I'm intentionally replying off list. > Oops.  Or not.  :-/ ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org

[coreboot] Re: Please test and review AGESA code

2022-05-17 Thread Arthur Heymans
Hi I have patches that improve those platforms and wrote code that should make some of the AGESA platforms easier to transition to newer soon to be mandated codepaths and I did so with past codepath mandates with both code and review. My message about moving code from the master branch was more o

[coreboot] Re: Please test and review AGESA code

2022-05-17 Thread Martin Roth via coreboot
Sorry, I guess I'm just sensitive about the topic of removing code, since, as you say, it's been talked about a lot. I obviously do appreciate your work on it. Take care. Martin May 17, 2022, 12:17 by art...@aheymans.xyz: > Hi > I have patches that improve those platforms and wrote code that

[coreboot] Re: [RFC] #pragma once

2022-05-17 Thread Arthur Heymans
Hi Those arguments not to use #pragma once make a lot of sense. Thanks Martin! I've made some good progress on getting boards to build with clang (each x86 board now builds). Clang at least warns about #ifndef and #define lines not being equal so we'd have that check covered. Kind regards Arthur