Hi Those arguments not to use #pragma once make a lot of sense. Thanks Martin!
I've made some good progress on getting boards to build with clang (each x86 board now builds). Clang at least warns about #ifndef and #define lines not being equal so we'd have that check covered. Kind regards Arthur On Tue, 17 May 2022, 15:28 Felix Held, <felix-coreb...@felixheld.de> wrote: > Hi Martin, > > > To support #pragma once, the compiler tries to identify duplicate > encounters with the same file, but the check gcc actually performs to > establish the identity of the file is weak. Here's someone who made two > copies of the same header with different names, each with a #pragma once, > and it screwed up his build. > > Ouch, that isn't what I expected here; especially since multiple files > with the same timestamp are expected when doing a fresh repo checkout. > With this info I agree that we should keep the include guard; definitely > learned something new today. It would be helpful to have this documented > and possibly have some check to make sure that the include guards aren't > broken in some files. > > Regards, > Felix > _______________________________________________ > coreboot mailing list -- coreboot@coreboot.org > To unsubscribe send an email to coreboot-le...@coreboot.org >
_______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
