[coreboot] Question about PR

2020-09-17 Thread bzt
Hi, I'd like to commit a patch to coreboot. I've followed the tutorials on https://doc.coreboot.org/tutorial/part2.html I've set up gerrit account, etc. created a local repo, configured git for submit, set up change-id hook, etc. etc. etc. However at step 4a, "git push", I got an error message fr

[coreboot] Re: Question about PR

2020-09-17 Thread Michal Zygowski
Hi, Please check out also this guide: https://www.coreboot.org/Git#Pushing_changes you need to tell git where to push: `HEAD:refs/for/master`. It seems the guide on https://doc.coreboot.org/tutorial/part2.html is missing one crucial step: `git config remote.origin.push HEAD:refs/for/master` You

[coreboot] Re: Question about PR

2020-09-17 Thread Angel Pons
Hi, On Thu, Sep 17, 2020 at 2:50 PM Michal Zygowski wrote: > > Hi, > > Please check out also this guide: > https://www.coreboot.org/Git#Pushing_changes > > you need to tell git where to push: `HEAD:refs/for/master`. It seems the > guide on https://doc.coreboot.org/tutorial/part2.html is missing o

[coreboot] Optiplex 9010 ACPI bug

2020-09-17 Thread Henkaku
After booting into Linux kacpid is constantly using 100% CPU and ACPI interrupt is firing at ~10k/s. My test environment is Optiplex 9010 with i5-3470 with dual channel DDR3 and an Nvidia GTX1650 installed as DGPU, running Fedora 32. Coreboot logs and Linux dmesg is attached below. Captured with

[coreboot] Re: Optiplex 9010 ACPI bug

2020-09-17 Thread Michal Zygowski
Hi, Thanks for catching this. I will look into it. Most of the ACPI however is not mainboard specific. My setup contains a RADEON GPU and i7-3770 CPU. Best regards, -- Michał Żygowski Firmware Engineer https://3mdeb.com | @3mdeb_com On 17.09.2020 17:33, Henkaku wrote: > After booting into Linu

[coreboot] Re: Question about PR

2020-09-17 Thread bzt
Thank you very much! I've tried "git push origin HEAD:refs/for/master" but didn't work. I've decided to start everything over, cloned the repo again, etc. I was able to push this time, however it is not clear why, since the two configurations are identical, look: $ diff coreboot-old/.git/config c

[coreboot] Re: Question about PR

2020-09-17 Thread Tim Wawrzynczak via coreboot
No worries, Gerrit uses the 'Change-Id' line to distinguish between different PRs/patches. Did you remove the Change-Id line when editing the commit? Cheers, -Tim On Thu, Sep 17, 2020 at 12:15 PM bzt wrote: > Thank you very much! > > I've tried "git push origin HEAD:refs/for/master" but didn't w