Withdrawn: 8323760: clarify specification of Map::putIfAbsent return value

2024-05-22 Thread duke
On Tue, 16 Jan 2024 07:40:44 GMT, John Hendrikx wrote: > Update the documentation for `@return` tag of `putIfAbsent` to match the main > description. `putIfAbsent` uses the same wording as `put` for its `@return` > tag, but that is incorrect. `putIfAbsent` never returns the **previous** > val

Withdrawn: 8324573: HashMap::putAll add notes for conservative resizing

2024-06-07 Thread duke
On Wed, 24 Jan 2024 00:26:09 GMT, Joshua Cao wrote: > Add notes for `HashMap::putAll()` conservative resizing. > > Note: everything below this line is from the original change. After > discussion, we decided to keep the conservative resizing, but we should add > an `@implNote` for the decision

Withdrawn: 8329532: Add an internal MemoryLayout transformer

2024-06-11 Thread duke
On Tue, 2 Apr 2024 15:04:40 GMT, Per Minborg wrote: > This PR proposes to add an internal layout transformer that could be used to > transform MemoryLayout entities. For example, it would be possible to convert > a struct layout to use network order ((big-endian) instead of native byte > order

Withdrawn: 8315487: Security Providers Filter

2024-06-19 Thread duke
On Fri, 1 Sep 2023 15:13:46 GMT, Martin Balao wrote: > In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of

Withdrawn: 8329760: Add indexOf(Predicate filter) to java.util.List interface

2024-06-20 Thread duke
On Fri, 5 Apr 2024 00:00:58 GMT, Evemose wrote: > **Subject** > Addition of Predicate-based `indexOf` and `lastIndexOf` methods to > `java.util.List` > > **Motivation** > The motivation behind this proposal is to enhance the functionality of the > `List` interface by providing a more flexible

Withdrawn: 8327791: Optimization for new BigDecimal(String)

2024-06-22 Thread duke
On Sun, 10 Mar 2024 16:11:12 GMT, Shaojin Wen wrote: > The current BigDecimal(String) constructor calls String#toCharArray, which > has a memory allocation. > > > public BigDecimal(String val) { > this(val.toCharArray(), 0, val.length()); // allocate char[] > } > > > When the length is g

Withdrawn: 8310994: Add JFR event for selection operations

2024-06-25 Thread duke
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote: > Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at jdk.

Re: RFR: 8335252: Reduce size of j.u.Formatter.Conversion#isValid [v4]

2024-06-28 Thread duke
On Fri, 28 Jun 2024 12:46:49 GMT, Shaojin Wen wrote: >> Currently, the java.util.Formatter$Conversion::isValid method is implemented >> based on switch, which cannot be inlined because codeSize > 325. This >> problem can be avoided by implementing it with ImmutableBitSetPredicate. >> >> use `-

Withdrawn: 8263261: Extend String::translateEscapes to support unicode escapes

2024-07-02 Thread duke
On Thu, 18 Jan 2024 18:50:56 GMT, Jim Laskey wrote: > Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage,

Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v3]

2024-07-02 Thread duke
On Tue, 23 Jan 2024 13:04:43 GMT, SendaoYan wrote: >> 8323640: [TESTBUG]testMemoryFailCount in >> jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail >> because OOM killed > > SendaoYan has updated the pull request incrementally with one additional > commit since the last rev

Withdrawn: 8325438: Add exhaustive tests for Math.round intrinsics

2024-07-02 Thread duke
On Wed, 7 Feb 2024 16:07:02 GMT, Hamlin Li wrote: > HI, > Can you have a look at this patch adding some tests for Math.round > instrinsics? > Thanks! > > ### FYI: > During the development of RoundVF/RoundF, we faced the issues which were only > spotted by running test exhaustively against 32/6

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v4]

2024-07-03 Thread duke
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HTM

Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread duke
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros @wenshao Your change (at version a98bd05c857d0a04dfad471dd28f905be1345376) is now ready to be sponsored by a Committer. ---

Re: RFR: 8330954: since-checker - Fix remaining @ since tags in java.base [v7]

2024-07-04 Thread duke
On Fri, 28 Jun 2024 11:11:51 GMT, Nizar Benalla wrote: >> Please review this PR that aims to add all the remaining needed `@since` >> tags in `java.base`, and group them into a single fix. >> This is related to #18934 and my work around the `@since` checker feature. >> Explicit `@since` tags are

Withdrawn: 8324651: Compiler Implementation for Derived Record Creation (Preview)

2024-07-04 Thread duke
On Wed, 27 Mar 2024 10:24:51 GMT, Jan Lahoda wrote: > This is a patch for javac, that adds the Derived Record Creation expressions. > The current draft specification for the feature is: > https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html > > The curr

Withdrawn: 8322332: Add API to access ZipEntry.extraAttributes

2024-07-08 Thread duke
On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan wrote: > Add API to access ZipEntry.extraAttributes This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19204

Re: RFR: 8325525: Create jtreg test case for JDK-8325203 [v4]

2024-07-10 Thread duke
On Tue, 9 Jul 2024 16:12:58 GMT, Vanitha B P wrote: >> Created jtreg test case for >> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue. >> >> The JpackageTest created tests that the child process started from the app >> launched by jpackage launcher is not automatically termina

Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder

2024-07-11 Thread duke
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > still returns

Re: RFR: 8333749: Consolidate ConstantDesc conversion in java.base [v6]

2024-07-11 Thread duke
On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang wrote: >> In java.base, especially in bytecode generators, we have many different >> methods converting known valid Class and MethodType into ClassDesc and >> MethodTypeDesc. These conversions should be consolidated into the same >> utility method fo

Re: RFR: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated [v2]

2024-07-11 Thread duke
On Fri, 10 May 2024 04:55:21 GMT, Chen Liang wrote: >> GenerateJLIClassesHelper has been making wrong assumptions about Invoker's >> LambdaForm method type parameters. Since they are distinct from those of >> Linkers, they are now tracked and generated separately. It seems that no >> proper in

Re: RFR: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API [v2]

2024-07-11 Thread duke
On Sun, 12 May 2024 02:42:32 GMT, Chen Liang wrote: >> Summary of the changes: >> - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps; >> they are exclusively used by jdeps in sources, and they are not used in any >> tests too. This will ease the removal of `com.sun.tools.

Re: RFR: 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull [v6]

2024-07-11 Thread duke
On Wed, 29 May 2024 19:27:17 GMT, Chen Liang wrote: >> I propose to add type-checked ConstantPool.entryByIndex and >> ClassReader.readEntryOrNull taking an extra Class parameter, which throws >> ConstantPoolException instead of ClassCastException on type mismatch, which >> can happen to malfor

Re: RFR: 8332109: Convert remaining tests using com.sun.tools.classfile to ClassFile API

2024-07-11 Thread duke
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote: > Some tests are not migrated to the ClassFile API in previous migrations. > > - Some are simple oversights that didn't remove usages of > com.sun.tools.classfile; > - The CallerSensitive ones used an old utility, replaced by CF API-based ne

Re: RFR: 8323707: Adjust Classfile API's type arg model to better represent the embodied type [v5]

2024-07-11 Thread duke
On Wed, 1 May 2024 22:39:05 GMT, Chen Liang wrote: >> API changes as discussed on the mailing list: >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html >> >> Additional questions: >> 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE` > > Chen Liang has upda

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread duke
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

Re: RFR: 8335802: Improve startup speed HexFormat uses boolean instead of enum [v2]

2024-07-12 Thread duke
On Wed, 10 Jul 2024 22:02:12 GMT, Shaojin Wen wrote: >> The current HexFormat defines an Enum to represent LowerCase and UpperCase >> >> >> class HexFormat { >> private enum Case { >> LOWERCASE, >> UPPERCASE >> } >> } >> >> >> This will cause the JVM to load one more c

Re: RFR: 8332249: Micro-optimize Method.hashCode [v2]

2024-07-12 Thread duke
On Mon, 3 Jun 2024 18:00:35 GMT, Sean Gwizdak wrote: >> Improve the speed of Method.hashCode by caching the hashcode on first use. >> I've seen an application where Method.hashCode is a hot path, and this is a >> fairly simple speedup. The memory overhead is low. >> >> This addresses issue >

Re: RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2]

2024-07-15 Thread duke
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote: >> Hi all, >> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java` >> doesn't receive jvm options from jtreg. >> I think it's necessory to receive jvm options from jtreg. >> Fix solution similar to >> [JDK-8157850](https://

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-17 Thread duke
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. > Maybe

Withdrawn: 8331196: vector api: Remove unnecessary index check in Byte/ShortVector.fromArray/fromArray0Template

2024-07-17 Thread duke
On Fri, 26 Apr 2024 14:06:02 GMT, Hamlin Li wrote: > Hi, > Can you help to review this simple patch? > Some index check in Byte/ShortVector.fromArray/fromArray0Template seems not > necessary, could be removed. > Thanks This pull request has been closed without being integrated. -

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread duke
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. > Maybe

Withdrawn: 8331342: Convert Base64 tests to JUnit

2024-07-19 Thread duke
On Tue, 21 May 2024 22:56:45 GMT, Justin Lu wrote: > Please review this test-only clean up PR which converts the java.util.Base64 > tests to run under JUnit. > > In general, this allows for the tests to run independently, separates the > data providers from the tests, as well being able to uti

Re: RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-19 Thread duke
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote: > The StringBuilder.repeat method was added in JDK 21, which can be used to > make some minor optimizations to existing code, including > DateTimeFormatterBuilder @wenshao Your change (at version db3027b03030304dbec990c943eff0f037363e37) is

Re: RFR: 8336706: Optimize LocalDate.toString with StringBuilder.repeat

2024-07-19 Thread duke
On Thu, 18 Jul 2024 05:21:36 GMT, Shaojin Wen wrote: > class LocalDate { > public String toString() { > if (absYear < 1000) { > if (yearValue < 0) { > buf.append(yearValue - 1).deleteCharAt(1); > } else { > buf.append(yearVal

Withdrawn: 8327858: Improve spliterator and forEach for single-element immutable collections

2024-07-21 Thread duke
On Wed, 20 Sep 2023 04:52:31 GMT, Chen Liang wrote: > Please review this patch that: > 1. Implemented `forEach` to optimize for 1 or 2 element collections. > 2. Implemented `spliterator` to optimize for a single element. > > The default implementations for multiple-element immutable collections

Re: RFR: 8333396: Use StringBuilder internally for java.text.Format.* formatting [v21]

2024-07-21 Thread duke
On Mon, 15 Jul 2024 02:30:54 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v5]

2024-07-22 Thread duke
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote: >> Can I get a review for this change that fixes some broken links in javadoc >> comments? The new docs are hosted >> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). >> >> It's mostly fixing some relative li

Re: RFR: 8336831: Optimize StringConcatHelper.simpleConcat [v7]

2024-07-23 Thread duke
On Tue, 23 Jul 2024 12:56:07 GMT, Shaojin Wen wrote: >> Currently simpleConcat is implemented using mix and prepend, but in this >> simple scenario, it can be implemented in a simpler way and can improve >> performance. > > Shaojin Wen has updated the pull request incrementally with one additio

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-24 Thread duke
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-24 Thread duke
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8337168: Optimize LocalDateTime.toString

2024-07-25 Thread duke
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote: > The current LocalDateTime.toString implementation concatenates the toString > results of date and time, which can be passed to StringBuilder to reduce > additional object allocation and improve performance. @wenshao Your change (at versio

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-26 Thread duke
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote: >> Integer.stringSize and Long.stringSize are used not only in java.lang, but >> also in other places. We put stringSize in DecimalDigits to reduce duplicate >> code and the use of JLA. > > Shaojin Wen has updated the pull request incremental

Re: RFR: 8337168: Optimize LocalDateTime.toString [v4]

2024-07-26 Thread duke
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote: >> The current LocalDateTime.toString implementation concatenates the toString >> results of date and time, which can be passed to StringBuilder to reduce >> additional object allocation and improve performance. > > Shaojin Wen has updated th

Re: RFR: 8337245: Fix wrong comment of StringConcatHelper

2024-07-27 Thread duke
On Fri, 26 Jul 2024 00:00:49 GMT, Shaojin Wen wrote: > 8337245: Fix wrong comment of StringConcatHelper @wenshao Your change (at version d453e6c2837cf7d8802f7fea624324361e085edf) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/20344#iss

Re: RFR: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive [v3]

2024-07-29 Thread duke
On Tue, 30 Jul 2024 05:59:44 GMT, Vanitha B P wrote: >> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently, >> fixed the issue and changes are tested. > > Vanitha B P has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8335638: Calling VarHandle.{access-mode} methods reflectively throws wrong exception [v2]

2024-08-01 Thread duke
On Thu, 4 Jul 2024 06:22:31 GMT, Hannes Greule wrote: >> Similar to how `MethodHandle#invoke(Exact)` methods are already handled, >> this change adds special casing for `VarHandle.{access-mode}` methods. >> >> The exception message is less exact, but I think that's acceptable. > > Hannes Greule

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v50]

2024-08-03 Thread duke
On Thu, 1 Aug 2024 10:16:59 GMT, fabioromano1 wrote: >> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The

Re: RFR: 8337205: Typo in Stack vs Deque Method table in Deque specification

2024-08-07 Thread duke
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote: > This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an > equivalent to Stack's `peek()` method since both of them don't throw when a > collection is empty. This is not the case with the current `getFirst()` > method. > >

Withdrawn: 8326227: Rounding error that may distort computeNextGaussian results

2024-08-08 Thread duke
On Mon, 5 Feb 2024 04:25:16 GMT, Chris Hennick wrote: > This provides a slightly more accurate bounding limit for > `computeNextExponentialSoftCapped` when calling it from > `computeNextGaussian`. This could cause the `while > (computeNextExponentialSoftCapped(rng, limit) < limit)` check in >

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v13]

2024-08-09 Thread duke
On Thu, 6 Oct 2022 06:28:04 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Updated instruc

Withdrawn: 8310843: Reimplement ByteArray and ByteArrayLittleEndian with Unsafe

2024-08-11 Thread duke
On Mon, 10 Jun 2024 02:12:11 GMT, Glavo wrote: > Things have changed since https://github.com/openjdk/jdk/pull/14636 was > closed, so let me reopen it. > > https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE > caused a startup regression. In order to not have any more

Re: RFR: 8332842: Optimize empty CopyOnWriteArrayList allocations [v4]

2024-08-14 Thread duke
On Thu, 20 Jun 2024 19:17:25 GMT, jengebr wrote: >> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless >> cloning of Object[0] instances. This cloning is intended to prevent callers >> from changing array contents, but many `CopyOnWriteArrayList`s are allocated >> to s

Re: RFR: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment [v4]

2024-08-14 Thread duke
On Fri, 26 Jul 2024 06:29:05 GMT, SendaoYan wrote: >> Hi all, >> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails >> on rpm build mock environment. The `df -h` command return fail `df: cannot >> read table of mounted file systems: No such file or directory` on the rpm

Re: RFR: 8336856: Efficient hidden class-based string concatenation strategy [v55]

2024-08-15 Thread duke
On Tue, 13 Aug 2024 16:34:18 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with two additional > commits since the last revision

Re: RFR: 8338409: Use record to simplify code

2024-08-15 Thread duke
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote: > j.u.Formatter$FixedString can be refactored to simplify the code using Record @wenshao Your change (at version c7ce3c724183ad3b4a09a9fac1d7411fdd8e) is now ready to be sponsored by a Committer. - PR Comment: https://git.op

Withdrawn: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-08-19 Thread duke
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote: > WIP > > This changeset contains hsdis for Windows/gcc Port. It supports both the > binutils and capstone backends, though the LLVM backend is left out due to > compatibility issues encountered during the build. Currently, which gcc > di

Withdrawn: 8329596: Add test for virtual threads invoking synchronized native methods

2024-08-19 Thread duke
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote: > This is a test-only addition to add a test for virtual threads invoking a > synchronized native method and invoking a native method that enter/exits a > monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo > for so

Re: RFR: 8338532: Speed up the ClassFile API MethodTypeDesc#ofDescriptor [v3]

2024-08-21 Thread duke
On Tue, 20 Aug 2024 12:39:14 GMT, Shaojin Wen wrote: >> The current implementation of ofDescriptor puts return type and parameter >> types together in an ArrayList, and then splits them into return type and >> array of parameter types. This ArrayList creation is unnecessary, >> considering mos

Withdrawn: 8333265: De-duplicate method references in java.util.stream.FindOps

2024-08-21 Thread duke
On Thu, 30 May 2024 12:50:36 GMT, Claes Redestad wrote: > Extracting duplicate method references to static field reduce proxy class > spinning and loading. In this case 2 less classes loaded when using > `findAny()` on each type of stream. This pull request has been closed without being integr

Re: RFR: 8338936: StringConcatFactory optimize the construction of MethodType and MethodTypeDesc [v2]

2024-08-26 Thread duke
On Sun, 25 Aug 2024 21:40:14 GMT, Shaojin Wen wrote: >> optimize the construction of MethodType and MethodTypeDesc to reduce memory >> allocate > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > use MethodTypeDescImpl.ofValida

Withdrawn: 8335478: Add notes for Error handling in Method.invoke and Constructor.newInstance

2024-08-26 Thread duke
On Mon, 1 Jul 2024 21:48:44 GMT, Chen Liang wrote: > `Method.invoke` and `Constructor.newInstance` wraps `Error` in > `InvocationTargetException`, which is bug-prone for users. Worse, this is > only ambiguously mentioned in the API specification. > > This patch proposes to explicitly mention t

Re: RFR: 8337832: Optimize datetime toString

2024-08-27 Thread duke
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote: > Similar to PR #20321, this improves performance by providing a method that > passes in a StringBuilder to avoid unnecessary object allocation. @wenshao Your change (at version 9d7cc54c449d4e12d0eb30c103e8aa3aaf206b6d) is now ready to be s

Re: RFR: 8339168: Optimize ClassFile Util slotSize

2024-08-29 Thread duke
On Wed, 28 Aug 2024 13:12:35 GMT, Shaojin Wen wrote: > A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot @wenshao Your change (at version 3c58fab74c9f78b7f3008c4f6fa32a7aab79f053) is now ready to be sponsored by a Committer. -

Re: RFR: 8339196: Optimize BufWriterImpl#writeU1/U2/Int/Long

2024-08-29 Thread duke
On Wed, 28 Aug 2024 13:16:03 GMT, Shaojin Wen wrote: > A small optimization makes BufWriterImpl's writeU1/U2/Int/Long methods more > C2-friendly and improves performance. @wenshao Your change (at version cd1140c1782255a5a1fcaaac89a37d21bf32582b) is now ready to be sponsored by a Committer. -

Withdrawn: 8333377: Migrate Generic Signature parsing to ClassFile API

2024-08-29 Thread duke
On Fri, 17 May 2024 12:01:23 GMT, Chen Liang wrote: > Core reflection's generic signature parsing uses an ancient library with > outdated visitor pattern on a tree model and contains unnecessary > boilerplates. This is a duplication of ClassFile API's signature model. We > should just move to

Re: RFR: 8339401: Optimize ClassFile load and store instructions [v2]

2024-09-03 Thread duke
On Mon, 2 Sep 2024 14:50:33 GMT, Shaojin Wen wrote: >> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size >> greater than 325, break it into multiple small methods and call them >> directly in DirectCodeBuilder > > Shaojin Wen has updated the pull request incrementally

Withdrawn: 8293017: Improve hash calculation parallelism in jmod/jlink

2022-10-24 Thread duke
On Mon, 29 Aug 2022 08:55:06 GMT, Aleksey Shipilev wrote: > `jmod`/`jlink` are executed during build time to produce the `jmod` and the > base modules image. On slow hardware (Raspberry Pi -class, for example) > and/or slow VMs (debug, interpreter-only, for example) this takes a while. > Profi

Withdrawn: 8291966: SwitchBootstrap.typeSwitch could be faster

2022-10-27 Thread duke
On Fri, 5 Aug 2022 16:12:08 GMT, Jan Lahoda wrote: > The pattern matching switches are using a bootstrap method > `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically, > for a switch like: > > switch (obj) { > case String s when s.isEmpty() -> {} > case String s

Withdrawn: 8289711: Add container configuration data to mbeans

2022-10-27 Thread duke
On Tue, 5 Jul 2022 04:21:55 GMT, xpbob wrote: > Container configuration information is useful for troubleshooting > problems,Exposing information in MBeans is ideal for monitoring, jConsole, > and other scenarios. > Results the following > ![图片](https://user-images.githubusercontent.com/7837910

Withdrawn: 8291915: jpackage: use multiple Features in MSI installer

2022-10-28 Thread duke
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

Withdrawn: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo

2022-10-28 Thread duke
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG wrote: > This PR-*draft* is **work in progress** and an invitation to discuss a > possible solution for issue > [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not > yet* intended for a final review. > > As proposed in JDK-

Withdrawn: 8291916: Unexpected output on Windows command prompt

2022-11-06 Thread duke
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi wrote: > To support Windows command prompt's codepage, following charsets should be > moved from jdk.charsets module to java.base module. > > - IBM860 > - IBM861 > - IBM863 > - IBM864 > - IBM865 > - IBM869 This pull request has been closed wi

Withdrawn: 8286212: Cgroup v1 initialization causes NPE on some systems

2022-11-07 Thread duke
On Tue, 10 May 2022 12:29:10 GMT, Severin Gehwolf wrote: > Please review this change to the cgroup v1 subsystem which makes it more > resilient on some of the stranger systems. Unfortunately, I wasn't able to > re-create a similar system as the reporter. The idea of using the longest > substri

Withdrawn: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-11-16 Thread duke
On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > > --S

Withdrawn: 8292937: Improve performance of some read operations of RandomAccessFile

2022-11-23 Thread duke
On Thu, 25 Aug 2022 17:14:20 GMT, Sergey Tsypanov wrote: > Currently some operations of RandomAccessFile are implemented with multiple > read() invocations: > > public final int readInt() throws IOException { > int ch1 = this.read(); > int ch2 = this.read(); > int ch3 = this.read();

Withdrawn: 8279361: Error in documentation of third Stream.reduce method

2022-11-28 Thread duke
On Wed, 28 Sep 2022 15:36:50 GMT, Viktor Klang wrote: > This JavaDoc change attempts to shine some light on the `combiner`-function > as it relates to the third variant of `Stream.reduce` since it according to > the bug submission in JBS can be confusing that the `combiner` is not > mentioned

Withdrawn: 8289834: Add SBCS and DBCS Only EBCDIC charsets

2022-11-28 Thread duke
On Wed, 6 Jul 2022 14:05:39 GMT, Ichiroh Takiguchi wrote: > OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and > DBCS Only charsets. > |Charset|Mix|SBCS|DBCS| > | -- | -- | -- | -- | > | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 | > | Korean | Cp933 | Cp833 | Cp

Withdrawn: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder()

2023-01-19 Thread duke
On Wed, 17 Aug 2022 11:23:57 GMT, Sergey Tsypanov wrote: > We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance is > constructed without comparator. This allows to squash two branches in > `TreeMap.get()` into one. > > P.S. I think the comment of `TreeMap.getEntryUsingCom

Withdrawn: JDK-8297688: libjli leaks memory related to options handling

2023-01-23 Thread duke
On Mon, 28 Nov 2022 03:23:01 GMT, Justin King wrote: > Fix memory leaks by making `AddOption` unconditionally duplicate passed in > strings, taking ownership. Callers using dynamic memory free their storage > after calling `AddOption`. This ensures no memory is dropped on the floor. > This als

Withdrawn: 8296546: Add @spec tags to API

2023-01-27 Thread duke
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

Withdrawn: 8291917: Windows - Improve error messages when the C Runtime Libraries or jvm.dll cannot be loaded

2023-01-31 Thread duke
On Thu, 4 Aug 2022 16:26:19 GMT, Julian Waters wrote: > Please review a small patch for dumping the failure reason when the MSVCRT > libraries or the Java Virtual Machine fails to load on Windows, which can > provide invaluable insight when debugging related launcher issues. > > See https://bu

Withdrawn: 8297632: InputStream.transferTo() method should specify what the return value should be when the number of bytes transfered is larger than Long.MAX_VALUE

2023-02-02 Thread duke
On Tue, 29 Nov 2022 00:56:58 GMT, Brian Burkhalter wrote: > `java.io.InputStream::transferTo` could conceivably return a negative value > if the count of bytes transferred overflows a `long`. Modify the method to > limit the number of bytes transferred to `Long.MAX_VALUE` per invocation. This

Withdrawn: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available

2023-02-03 Thread duke
On Thu, 14 Apr 2022 01:40:50 GMT, Brian Burkhalter wrote: > Modify native multi-byte read-write code used by the `java.io` classes to > limit the size of the allocated native buffer thereby decreasing off-heap > memory footprint and increasing throughput. This pull request has been closed with

Withdrawn: 8298638: Cleanup of unix java_md.c for better re-exec handling

2023-02-10 Thread duke
On Tue, 13 Dec 2022 09:32:11 GMT, Dmitry Samersoff wrote: > Move "unix" java_md.c cleanup, which is the prerequisites for the fix for > JDK-8293806 (PR https://github.com/openjdk/jdk/pull/11538), to a separate PR. > > @AlanBateman, @dholmes-ora please, take a look to the changes. This pull re

Withdrawn: JDK-8295756 Improve NonLocalRegistry Manual Test Process

2023-03-01 Thread duke
On Fri, 21 Oct 2022 21:45:30 GMT, Bill Huang wrote: > The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to i

Withdrawn: 8203035: Implement equals() and hashCode() for Throwable

2023-03-15 Thread duke
On Sat, 10 Dec 2022 18:11:30 GMT, Victor Toni wrote: > Being able to compare instances of Throwable allows simple detection of > exceptions raised by the same circumstances. Comparison allows for reduction > of excessive logging e.g. in hotspots without requiring custom code to > compare Throw

Withdrawn: 8301569: list mode of jmod and jimage cannot be used normally in turkish locale

2023-03-30 Thread duke
On Sun, 29 Jan 2023 15:37:28 GMT, Glavo wrote: > When the default Locale is `tr`, the jmod and jimage commands have the > following problems: > > * The jmod command does not correctly recognize the `list` mode typed in > lowercase; > * The jimage command cannot obtain the help information of t

Withdrawn: JDK-8301621: libzip should use pread instead of lseek+read

2023-04-03 Thread duke
On Fri, 3 Feb 2023 19:49:44 GMT, Justin King wrote: > Avoid using `lseek` + `read` in favor of `pread`. For Windows, we can do the > same thing by using `OVERLAPPED`, as we are in synchronous mode we can use > `Offset` and `OffsetHigh` to achieve the same thing. > > Additionally I updated open

Withdrawn: 8300819: -Dfile.encoding=Cp943C option does not work as expected since jdk18

2023-04-14 Thread duke
On Sun, 22 Jan 2023 09:18:37 GMT, Ichiroh Takiguchi wrote: > On jdk17, following testcase works fine on Linux platform. > > Testcase > > $ cat cstest1.java > import java.nio.charset.*; > > public class cstest1 { > public static void main(String[] args) throws Exception { > Charset cs =

Withdrawn: 8298045: Fix hidden but significant trailing whitespace in properties files for core-libs code

2023-04-14 Thread duke
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

Withdrawn: 8302267: [jittester] Improve separation of test generation and execution

2023-04-22 Thread duke
On Mon, 13 Feb 2023 09:55:52 GMT, Evgeny Nikitin wrote: > Please review a set of improvements that should improve working with other > fuzzing generators and usage of JitTesterDriver with tests generated not by > the JITTester: > > - Provide better separation of individual test generation from

Withdrawn: 8301042: Need methods to check null elements in an array or a collection

2023-04-24 Thread duke
On Sat, 28 Jan 2023 23:58:28 GMT, Tingjun Yuan wrote: > Adding the following methods to check the nullity of elements of an array or > a collection: > > > java.util.Arrays: > public static E[] requireNoNulls(E[] array) > public static E[] requireNoNulls(E[] array, String message) > public st

Withdrawn: 8303891: Zip64SizeTest could use a sparse file

2023-05-05 Thread duke
On Thu, 9 Mar 2023 12:06:52 GMT, Eirik Bjorsnos wrote: > This PR suggests we use a sparse file when the Zip64SizeTest writes a ZIP > file with a 5GB entry. > > The size requirement of this test is known to cause problems in some builds, > see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8

Withdrawn: 8302872: Speed up StringLatin1.regionMatchesCI_UTF16

2023-05-09 Thread duke
On Sat, 18 Feb 2023 18:22:49 GMT, Eirik Bjorsnos wrote: > This PR continues the efforts from #12632 to speed up case-insensitive string > matching. > > We now tackle case-insensitive comparison of mixed-coder strings, implemented > in `StringLatin1.regionMatchesCI_UTF16` > > Key insights: >

Withdrawn: 8301220: Return value of toArray() of Сollection types from java.base should be trusted

2023-05-28 Thread duke
On Thu, 26 Jan 2023 06:46:16 GMT, Glavo wrote: > I checked the `java.base` module, and all the `Collection#toArray()` method > of collections be implemented correctly. > > Their return values can be trusted, so many unnecessary array duplication can > be eliminated. This pull request has been

Withdrawn: JDK-8277520: Implement JDK-8 default methods for IdentityHashMap

2022-06-30 Thread duke
On Wed, 24 Nov 2021 05:16:40 GMT, liach wrote: > Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute` > `merge` would throw CME if the functions modified the map itself, and there > are corresponding specification changes. This pull request has been closed without being integ

Withdrawn: 8279986: methods Math::asXExact for safely checked primitive casts

2022-07-20 Thread duke
On Thu, 5 May 2022 10:11:05 GMT, Raffaello Giulietti wrote: > Add a family of "safe" cast methods. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/8548

Withdrawn: 8284638: store skip buffers in InputStream Object

2022-07-25 Thread duke
On Fri, 8 Oct 2021 21:19:36 GMT, XenoAmess wrote: > @jmehrens what about this then? > I think it safe now(actually this mechanism is learned from Reader) This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/5872

Withdrawn: 8279031: Add API note to ToolProvider about being reusable/reentrant

2022-08-02 Thread duke
On Mon, 23 May 2022 08:49:27 GMT, Christian Stein wrote: > This commit adds an API note to ToolProvider about being reusable/reentrant. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/8833

Withdrawn: 8282664: Unroll by hand StringUTF16, StringLatin1, and Arrays polynomial hash loops

2022-08-09 Thread duke
On Fri, 4 Mar 2022 15:54:14 GMT, Ludovic Henry wrote: > Despite the hash value being cached for Strings, computing the hash still > represents a significant CPU usage for applications handling lots of text. > > Even though it would be generally better to do it through an enhancement to > the a

  1   2   3   4   >