On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen <d...@openjdk.org> wrote:

>> class LocalTime {
>>     public String toString() {
>>         // ...
>>                 if (nanoValue % 1000_000 == 0) {
>>                     buf.append(Integer.toString((nanoValue / 1000_000) + 
>> 1000).substring(1));
>>                 } else if (nanoValue % 1000 == 0) {
>>                     buf.append(Integer.toString((nanoValue / 1000) + 
>> 1000_000).substring(1));
>>                 } else {
>>                     buf.append(Integer.toString((nanoValue) + 
>> 1000_000_000).substring(1));
>>                 }
>>        // ...
>>     }
>> }
>> 
>> Currently, LocalTime.toString handles nanos by adding a value and then 
>> subString(1) to fill it with zeros. Using StringBuilder.repeat is more 
>> concise and has better performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright

@wenshao 
Your change (at version d930eb376c3077d449400e438059f372efa26f7f) is now ready 
to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20232#issuecomment-2249009049

Reply via email to