Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v3]

2024-05-22 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v3]

2024-05-22 Thread Doug Lea
On Wed, 22 May 2024 15:45:43 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 36

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v3]

2024-05-22 Thread Doug Lea
On Wed, 22 May 2024 15:51:05 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 36

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v2]

2024-05-22 Thread Doug Lea
On Thu, 16 May 2024 10:29:48 GMT, Sunmisc Unsafe wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > Maybe I don't quite understand, or I don't hav

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v3]

2024-05-22 Thread Doug Lea
On Wed, 22 May 2024 21:23:04 GMT, Sunmisc Unsafe wrote: >> After recheckiing, the best policy is to leave internal queues the same, but >> initialize external queues larger. > > Probably a misplaced post again, but why can't you allocate an array of arrays > where the outer array is 30 > and the

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v4]

2024-05-23 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v5]

2024-05-25 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v6]

2024-05-29 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v7]

2024-05-29 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v7]

2024-05-29 Thread Doug Lea
On Wed, 29 May 2024 13:26:10 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 41

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v7]

2024-05-29 Thread Doug Lea
On Wed, 29 May 2024 14:19:52 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 41

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v8]

2024-05-29 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v7]

2024-05-29 Thread Doug Lea
On Wed, 29 May 2024 14:09:51 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 41

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v9]

2024-05-29 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v10]

2024-05-29 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v11]

2024-05-30 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v12]

2024-05-30 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v13]

2024-05-30 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v14]

2024-05-30 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v15]

2024-05-30 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v16]

2024-05-31 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v17]

2024-05-31 Thread Doug Lea
> This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with large numbers of cores Doug Lea has upda

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v17]

2024-05-31 Thread Doug Lea
On Fri, 31 May 2024 14:04:50 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reconcile changes > > src/java.base/share/classes/java/util/concurrent/ForkJoinP

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v17]

2024-05-31 Thread Doug Lea
On Fri, 31 May 2024 14:08:49 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reconcile changes > > src/java.base/share/classes/java/util/concurrent/ForkJoinP

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode [v17]

2024-06-03 Thread Doug Lea
On Sun, 2 Jun 2024 14:33:45 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reconcile changes > > src/java.base/share/classes/java/util/concurrent/ForkJoinP

Re: RFR: 8332842: Optimize empty CopyOnWriteArrayList allocations

2024-06-03 Thread Doug Lea
On Mon, 3 Jun 2024 16:47:20 GMT, jengebr wrote: > Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless > cloning of Object[0] instances. This cloning is intended to prevent callers > from changing array contents, but many `CopyOnWriteArrayList`s are allocated > to size z

Re: RFR: 8332842: Optimize empty CopyOnWriteArrayList allocations

2024-06-04 Thread Doug Lea
On Tue, 4 Jun 2024 13:03:45 GMT, Viktor Klang wrote: >> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless >> cloning of Object[0] instances. This cloning is intended to prevent callers >> from changing array contents, but many `CopyOnWriteArrayList`s are allocated >>

Integrated: 8322732: ForkJoinPool may underutilize cores in async mode

2024-06-05 Thread Doug Lea
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote: > This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployment

Re: RFR: 8332842: Optimize empty CopyOnWriteArrayList allocations [v3]

2024-06-06 Thread Doug Lea
On Thu, 6 Jun 2024 12:46:36 GMT, jengebr wrote: >> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless >> cloning of Object[0] instances. This cloning is intended to prevent callers >> from changing array contents, but many `CopyOnWriteArrayList`s are allocated >> to si

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v10]

2024-07-02 Thread Doug Lea
On Tue, 2 Jul 2024 17:55:31 GMT, Suryanarayana Garlapati wrote: >> @wborn I think 17 should also be OK modulo deleting 2 lines for pre-21 >> mentioned above. I only checked with 19 though.. > > @DougLea is there any timeline where we can expect the backport of this fix > into jdk17? or any oth

Re: RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity

2024-07-30 Thread Doug Lea
On Tue, 30 Jul 2024 09:24:12 GMT, Viktor Klang wrote: > Removes some of the old wording around the algorithmic complexity of > ConcurrentSkipListSet::size() while still retaining the warning around the > accuracy of the returned result. Yes, thanks for fixing wording that should have been upda

Re: RFR: 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when failing due to a LinkageError or other errors

2024-08-12 Thread Doug Lea
On Mon, 12 Aug 2024 14:02:52 GMT, Alan Bateman wrote: >> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when >> failing due to a LinkageError or other errors > > src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java > line 381: > >> 379:

RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-12 Thread Doug Lea
The Exchanger class uses spin-waits that are hostile to some uses of VirtualThreads. Improving this requires a means of estimating whether there are many VirtualThreads with few carriers, which can be supported by adding a method in class ForkJoinWorkerThread. This enables a reworking of the exc

Re: RFR: 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when failing due to a LinkageError or other errors [v2]

2024-08-12 Thread Doug Lea
On Mon, 12 Aug 2024 16:08:31 GMT, Viktor Klang wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Catching both Error and RuntimeException > > src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongS

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-13 Thread Doug Lea
On Tue, 13 Aug 2024 11:52:05 GMT, Viktor Klang wrote: >> The Exchanger class uses spin-waits that are hostile to some uses of >> VirtualThreads. Improving this requires a means of estimating whether there >> are many VirtualThreads with few carriers, which can be supported by adding >> a metho

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Doug Lea
On Thu, 15 Aug 2024 15:41:21 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 858: >> >>> 856: * usages of ForkJoinTasks ignore interrupt status when executing >>> 857: * or awaiting completion. Otherwise, reporting task results or >>>

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Doug Lea
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote: >> This PR fixes a few trivial grammar issues and typos in documentation. >> >> The main issue is the use of the word "timeout". To my mind, timeout, a >> duration, is not the same as deadline, which is a point in time, an instant, >> which

Re: RFR: 8338398: Trivially fix grammar and typos [v2]

2024-08-16 Thread Doug Lea
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote: >> This PR fixes a few trivial grammar issues and typos in documentation. >> >> The main issue is the use of the word "timeout". To my mind, timeout, a >> duration, is not the same as deadline, which is a point in time, an instant, >> which

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-20 Thread Doug Lea
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a &g

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads [v2]

2024-08-21 Thread Doug Lea
the possible expense of revealing too much > about current VT implementation Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commi

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-21 Thread Doug Lea
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a &g

Integrated: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-21 Thread Doug Lea
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a &g

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Doug Lea
On Tue, 20 Aug 2024 18:52:23 GMT, Viktor Klang wrote: > Unfortunately there is no good, deterministic reproducer which can be used as > a regression test at this point in time. I think this is the most straightforward way to address. It doesn't need doc change -- there are other cases where b

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Doug Lea
On Wed, 21 Aug 2024 11:10:22 GMT, Alan Bateman wrote: >> Unfortunately there is no good, deterministic reproducer which can be used >> as a regression test at this point in time. > > src/java.base/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java > line 533: > >> 531: */

Re: RFR: JDK-8297605 DelayQueue javadoc is confusing

2023-02-23 Thread Doug Lea
On Thu, 23 Feb 2023 15:36:48 GMT, Viktor Klang wrote: > Clarifies the distinction between expiration of the head of DelayQueue and > how it relates to `poll`, `take`, and `peek`. See discussion on > https://bugs.openjdk.org/browse/JDK-8297605 > > @DougLea If possible, please weigh in on whethe

Re: RFR: JDK-8297605 DelayQueue javadoc is confusing [v2]

2023-02-27 Thread Doug Lea
On Fri, 24 Feb 2023 16:08:57 GMT, Viktor Klang wrote: >> Clarifies the distinction between expiration of the head of DelayQueue and >> how it relates to `poll`, `take`, and `peek`. See discussion on >> https://bugs.openjdk.org/browse/JDK-8297605 >> >> @DougLea If possible, please weigh in on w

Re: RFR: 8297605: DelayQueue javadoc is confusing

2023-03-02 Thread Doug Lea
On Thu, 2 Mar 2023 20:00:56 GMT, Martin Buchholz wrote: > Inviting @DougLea and @viktorklang-ora to review. > > As usual, I couldn't resist more fiddling. > - Added missing tests for take, remove(), remove(Object). > - Improved DelayQueueTest's testing infrastructure > - added more test assert

Re: RFR: JDK-8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out [v3]

2023-03-23 Thread Doug Lea
On Thu, 23 Mar 2023 14:13:14 GMT, Viktor Klang wrote: >> Improves the stability of the memory leak test for CompletableFuture timeout >> cancellation by both reducing the count by 50% (which should still be above >> threshold to trigger given the ample margin set initially) as well as >> exten

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died

2022-07-11 Thread Doug Lea
On Fri, 8 Jul 2022 11:44:53 GMT, Doug Lea wrote: > 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with > java.lang.Exception: Reference Handler thread died Thanks to @AlanBateman for suggesting to disable possibly misleading stack traces in pre-allocated exceptions; now upda

RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died

2022-07-11 Thread Doug Lea
8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died - Commit messages: - Also update Xcomp problem list - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8066859 - Address review comments - Disable filli

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died

2022-07-11 Thread Doug Lea
On Mon, 11 Jul 2022 04:10:49 GMT, David Holmes wrote: >> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with >> java.lang.Exception: Reference Handler thread died > > src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java > line 296: > >> 294:

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v2]

2022-07-13 Thread Doug Lea
> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with > java.lang.Exception: Reference Handler thread died Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Don't bother creating static exceptions ---

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v2]

2022-07-13 Thread Doug Lea
On Tue, 12 Jul 2022 15:03:46 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Don't bother creating static exceptions > > test/jdk/ProblemList.txt line 498:

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v2]

2022-07-13 Thread Doug Lea
On Mon, 11 Jul 2022 04:18:20 GMT, David Holmes wrote: >> src/java.base/share/classes/java/util/concurrent/locks/LockSupport.java line >> 463: >> >>> 461: * Preallocated exceptions thrown if acquiring or releasing locks >>> 462: * when OutOfMemory. >>> 463: */ >> >> I don't see

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v3]

2022-07-13 Thread Doug Lea
> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with > java.lang.Exception: Reference Handler thread died Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Unspecialize catch to allow OOME - Changes:

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v4]

2022-07-13 Thread Doug Lea
> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with > java.lang.Exception: Reference Handler thread died Doug Lea has updated the pull request incrementally with one additional commit since the last revision: copyright header - Changes: - all:

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v3]

2022-07-13 Thread Doug Lea
On Wed, 13 Jul 2022 14:32:35 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unspecialize catch to allow OOME > > test/jdk/java/util/concurrent/locks/Lock/OOMEInAQS.j

Integrated: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died

2022-07-13 Thread Doug Lea
On Fri, 8 Jul 2022 11:44:53 GMT, Doug Lea wrote: > 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with > java.lang.Exception: Reference Handler thread died This pull request has now been integrated. Changeset: 53580455 Author: Doug Lea URL: https://git.openjdk.o

RFR: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"

2022-07-14 Thread Doug Lea
This test now conforms to jtreg rules about not using System.exit to cover untested OutOfMemoryErrors - Commit messages: - Avoid System.exit in jtreg tests Changes: https://git.openjdk.org/jdk/pull/9491/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9491&range=00 Issue:

Re: RFR: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0" [v2]

2022-07-14 Thread Doug Lea
> This test now conforms to jtreg rules about not using System.exit to cover > untested OutOfMemoryErrors Doug Lea has updated the pull request incrementally with one additional commit since the last revision: try/lock() style - Changes: - all: https://git.openjdk.o

Re: RFR: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0" [v2]

2022-07-14 Thread Doug Lea
On Thu, 14 Jul 2022 13:29:50 GMT, David Holmes wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> try/lock() style > > test/jdk/java/util/concurrent/locks/Lock/OOME

Integrated: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"

2022-07-14 Thread Doug Lea
On Thu, 14 Jul 2022 11:57:37 GMT, Doug Lea wrote: > This test now conforms to jtreg rules about not using System.exit to cover > untested OutOfMemoryErrors This pull request has now been integrated. Changeset: 890bcedd Author: Doug Lea URL: https://git.openjdk.org/jdk/

RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Doug Lea
8292969: This small change in signal propagation rules improves utilization when entry queues are resized, - Commit messages: - Merge remote-tracking branch 'refs/remotes/origin/JDK-8292969' into JDK-8292969 - Merge branch 'openjdk:master' into JDK-8292969 - Update @preturn javad

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Doug Lea
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, Thanks. replaced with: * @return the next prevSrc value to use, or negative if none found Thanks. I keep forgetting the re

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Doug Lea
On Mon, 26 Sep 2022 13:21:23 GMT, Aleksey Shipilev wrote: >> 8292969: This small change in signal propagation rules improves utilization >> when entry queues are resized, > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842: > >> 1840: signalW

Integrated: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-27 Thread Doug Lea
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, This pull request has now been integrated. Changeset: bc12e955 Author: Doug Lea URL: https://git.openjdk.org/jdk/

RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"

2023-06-05 Thread Doug Lea
Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" and related issues. This is a major ForkJoin update (and hard to review -- sorry) that finally addresses incompatibilities between ExecutorService and ForkJoinPool (w

RFR: 8301341: LinkedTransferQueue does not respect timeout for poll()

2023-06-05 Thread Doug Lea
This now uses Thread.isVirtual to distinguish spin vs immediate block cases, enabling re-introduction of spin control from the previous version, removing anomalies like this one. - Commit messages: - Use Thread.isVirtual to distinguish spin vs immediate block cases Changes: https:

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v2]

2023-06-29 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v3]

2023-06-29 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v3]

2023-06-30 Thread Doug Lea
On Fri, 30 Jun 2023 12:54:37 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Overhaul LTQ and SQ to use common blocking and matching mechanics > > src/java.base/shar

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v4]

2023-06-30 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v3]

2023-06-30 Thread Doug Lea
On Fri, 30 Jun 2023 13:00:27 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java >> line 115: >> >>> 113: * indicating whether to act as some form of offer, put, poll, >>> 114: * take, or trans

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v5]

2023-06-30 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v6]

2023-07-13 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v7]

2023-07-19 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v8]

2023-07-20 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v6]

2023-07-20 Thread Doug Lea
On Mon, 17 Jul 2023 14:45:57 GMT, Andrey Turbanov wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains seven

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v8]

2023-07-20 Thread Doug Lea
On Thu, 20 Jul 2023 10:26:03 GMT, Doug Lea wrote: >> This update addresses performance issues across both LinkedTransferQueue and >> SynchronousQueue by creating a common basis for implementation across them >> (mainly in LinkedTransferQueue). Pasting from internal doc summ

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v5]

2023-07-20 Thread Doug Lea
On Fri, 7 Jul 2023 13:45:25 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix inverted test assert; improve internal documentation; simplify code > > src/jav

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v8]

2023-07-21 Thread Doug Lea
On Fri, 21 Jul 2023 09:30:53 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> nitpicks > > src/java.base/share/classes/java/util/concurrent/LinkedTransferQue

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v8]

2023-07-21 Thread Doug Lea
On Fri, 21 Jul 2023 10:55:19 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java >> line 446: >> >>> 444: Thread.onSpinWait(); >>> 445: else >>> 446:

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v9]

2023-07-21 Thread Doug Lea
a dummy node, while also reducing retries under heavy > * contention and misorderings, and relaxing some accesses, > * requiring accommodation in many places (as well as > * adjustments in WhiteBox tests). Doug Lea has updated the pull request incrementally

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v9]

2023-07-21 Thread Doug Lea
On Fri, 21 Jul 2023 13:53:57 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/Linked

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v9]

2023-07-21 Thread Doug Lea
On Fri, 21 Jul 2023 14:00:06 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/Linked

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v10]

2023-07-21 Thread Doug Lea
a dummy node, while also reducing retries under heavy > * contention and misorderings, and relaxing some accesses, > * requiring accommodation in many places (as well as > * adjustments in WhiteBox tests). Doug Lea has updated the pull request with a new target base

Integrated: 8301341: LinkedTransferQueue does not respect timeout for poll()

2023-07-22 Thread Doug Lea
On Mon, 5 Jun 2023 18:52:00 GMT, Doug Lea wrote: > This update addresses performance issues across both LinkedTransferQueue and > SynchronousQueue by creating a common basis for implementation across them > (mainly in LinkedTransferQueue). Pasting from internal doc summary of

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted"

2023-07-25 Thread Doug Lea
On Sat, 3 Jun 2023 14:08:02 GMT, Doug Lea wrote: > Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) tha

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v2]

2023-08-07 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull reque

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v3]

2023-08-09 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull reque

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v10]

2023-08-10 Thread Doug Lea
On Sun, 6 Aug 2023 12:23:54 GMT, Wouter Born wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 13 additional

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v4]

2023-08-14 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull reque

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v4]

2023-08-16 Thread Doug Lea
On Tue, 15 Aug 2023 14:19:29 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 45

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v4]

2023-08-17 Thread Doug Lea
On Wed, 16 Aug 2023 10:33:58 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 442: >> >>> 440: * queues are at odd indices. Worker phase ids masked with SMASK >>> 441: * match their index. Shared (submissi

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v5]

2023-08-17 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull re

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v4]

2023-08-17 Thread Doug Lea
On Thu, 17 Aug 2023 09:50:49 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 45

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v6]

2023-08-17 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull reque

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v7]

2023-08-17 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull re

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v8]

2023-08-17 Thread Doug Lea
ensure consistent data structures and actions without requiring global > synchronization or locking on every task execution that would massively > degrade performance. The previous lack of a solution to this was the main > reason for these incompatibilities. Doug Lea has updated the pull re

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v4]

2023-08-19 Thread Doug Lea
On Thu, 17 Aug 2023 15:25:49 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 45

  1   2   3   4   >