This patch expands the use of a hash table for secondary superclasses
to the interpreter, C1, and runtime. It also adds a C2 implementation
of hashed lookup in cases where the superclass isn't known at compile
time.
HotSpot shared runtime
--
Building hashed secondary tables is
On Fri, 12 Jul 2024 09:40:45 GMT, Roman Kennke wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update arguments.cpp
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 343:
>
>> 341: const R
On Thu, 11 Jul 2024 23:47:51 GMT, Vladimir Ivanov wrote:
>> src/hotspot/share/oops/klass.cpp line 284:
>>
>>> 282: // which doesn't zero out the memory before calling the constructor.
>>> 283: Klass::Klass(KlassKind kind) : _kind(kind),
>>> 284:_bitmap(SECONDARY_S
On Fri, 5 Jul 2024 22:37:34 GMT, Vladimir Ivanov wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
>> time.
>>
>> HotSpo
On Wed, 17 Jul 2024 18:54:32 GMT, Vladimir Ivanov wrote:
>> Now it starts to sound concerning... `Klass::set_secondary_supers()`
>> initializes both `_secondary_supers` and `_bitmap` which implies that
>> `Klass::is_subtype_of()` may be called on not yet initialized Klass. It
>> that's the cas
On Thu, 11 Jul 2024 23:22:19 GMT, Vladimir Ivanov wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1433:
>>
>>> 1431:
>>> 1432: // Don't check secondary_super_cache
>>> 1433: if (super_check_offset.is_register()
>>
>> Do you see any effects from this particular change?
>>
On Thu, 11 Jul 2024 23:39:11 GMT, Vladimir Ivanov wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
>> time.
>>
>> HotSp
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
>
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> simplicity over
On Thu, 11 Jul 2024 22:53:42 GMT, Vladimir Ivanov wrote:
>> src/hotspot/share/oops/instanceKlass.cpp line 1410:
>>
>>> 1408: return nullptr;
>>> 1409: } else if (num_extra_slots == 0) {
>>> 1410: if (num_extra_slots == 0 && interfaces->length() <= 1) {
>>
>> Since `secondary_supers` a
On Fri, 5 Jul 2024 22:30:09 GMT, Vladimir Ivanov wrote:
>> Andrew Haley has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Review feedback
>> - Review feedback
>> - Review feedback
>> -
On Thu, 11 Jul 2024 23:07:43 GMT, Vladimir Ivanov wrote:
>> Andrew Haley has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Review feedback
>> - Review feedback
>> - Review feedback
>> -
On Thu, 18 Jul 2024 20:11:03 GMT, Vladimir Ivanov wrote:
> Alternatively, `Klass::is_subtype_of()` can unconditionally perform linear
> search over secondary_supers array.
>
> Even though I very much like to see table lookup written in C++ (accompanying
> heavily optimized platform-specific Ma
On Mon, 22 Jul 2024 15:03:12 GMT, Andrew Haley wrote:
>> Alternatively, `Klass::is_subtype_of()` can unconditionally perform linear
>> search over secondary_supers array.
>>
>> Even though I very much like to see table lookup written in C++
>> (accompany
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> simplicity over absolut
On Thu, 11 Jul 2024 23:57:27 GMT, Vladimir Ivanov wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review comments
>> - Review comments
>
> src/hotspot/cpu/x86/macroAss
On Mon, 22 Jul 2024 16:50:47 GMT, Andrew Haley wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> si
On Tue, 23 Jul 2024 19:14:57 GMT, Vladimir Ivanov wrote:
> > Also also, Klass::is_subtype_of() is used for C1 runtime.
>
> Can you elaborate, please?
Sorry, that was rather vague. In C1-compiled code, the Java method
`Class::isInstance(Object)`calls `Klass::is_subtype_of()`.
In general, I fi
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> si
On Tue, 23 Jul 2024 19:00:02 GMT, Vladimir Ivanov wrote:
> What happens when users include `klass.hpp`, but not `klass.inline.hpp`? How
> does it affect generated code?
>
> I suspect that `Klass::search_secondary_supers()` won't be inlinined in such
> case.
That is true. I can't tell from thi
On Wed, 24 Jul 2024 14:29:09 GMT, Andrew Haley wrote:
> I suspect that Klass::search_secondary_supers() won't be inlinined in such
> case.
That's true, but it's true of every other function in that file. Is it not
deliberate?
-
PR Review Comment: https://git
On Wed, 24 Jul 2024 15:51:26 GMT, Andrew Haley wrote:
>>> What happens when users include `klass.hpp`, but not `klass.inline.hpp`?
>>> How does it affect generated code?
>>>
>>> I suspect that `Klass::search_secondary_supers()` won't be inlinined in
&g
On Wed, 24 Jul 2024 19:09:06 GMT, Vladimir Ivanov wrote:
>>> > Also also, Klass::is_subtype_of() is used for C1 runtime.
>>>
>>> Can you elaborate, please?
>>
>> Sorry, that was rather vague. In C1-compiled code, the Java method
>> `Class::isInstance(Object)`calls `Klass::is_subtype_of()`.
>>
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> simplicity over absol
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> simplicity over abso
On Thu, 25 Jul 2024 16:05:49 GMT, Andrew Haley wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
this code is only used for generating stubs, and it seemed to me
> ridiculous to have stubs calling other stubs.
>
> I've followed the guidance from @iwanowww not to obsess too much about
> the performance of C1-compiled secondary supers lookups, and to prefer
> sim
On Thu, 25 Jul 2024 23:31:21 GMT, Vladimir Ivanov wrote:
> Thanks! The patch looks good, except there was one failure observed during
> testing with the latest patch [1]. It does look related to the latest changes
> you did in
> [54050a5](https://github.com/openjdk/jdk/pull/19989/commits/54050
On Fri, 26 Jul 2024 18:39:27 GMT, Vladimir Ivanov wrote:
> Oh, it comes as a surprise to me... I was under impression that the first
> thing hand-coded assembly variants do is check for `bitmap !=
> SECONDARY_SUPERS_BITMAP_FULL`. At least, it was my recollection from working
> on [JDK-8180450]
On Tue, 27 Aug 2024 05:24:34 GMT, Jatin Bhateja wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.tanh() using libm
>>
>> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
>> -- | -- | -- | --
>> MathBench.tanhDouble | 70900 | 95618 | 1.35x
>
> src/
On 8/27/24 12:13, Jatin Bhateja wrote:
Hi @vamsi-parasa , Kindly also add a JMH micro benchmark, I did a first
run and see around 4% performance drop with attached micro on Sapphire
Rapids.
[test.txt](https://github.com/user-attachments/files/16761142/test.txt)
If I had to guess, that's beca
On Tue, 27 Aug 2024 22:23:44 GMT, Srinivas Vamsi Parasa
wrote:
>> I agree, this is all rather obscure. Ideally the same names that are used in
>> wherever this comes from.
>>
>> Where does the algorithm come from? What are its accuracy guarantees?
>>
>> In addition, given the rarity of hyperb
On Mon, 14 Nov 2022 08:28:04 GMT, Thomas Stuefe wrote:
> unfortunately, your patch will make backporting more difficult. We cannot
> downport it to older releases compiled with older compilers. But since it
> touches a lot of files it will sit smack in the middle of patch sequences,
> requirin
JEP 429 implementation.
-
Commit messages:
- Update StressStackOverflow
- Release _scopedValueCache after use
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Update src/java.base/share/classes/jdk/internal/vm/ScopedValueContainer.java
- Renam
On Fri, 4 Nov 2022 23:17:32 GMT, Dean Long wrote:
>> JEP 429 implementation.
>
> src/hotspot/share/prims/jvm.cpp line 1410:
>
>> 1408: loc = 3;
>> 1409: } else if (method == resolver.thread_run_method) {
>> 1410: loc = 2;
>
> This depends on how javac numbers locals, right? It
On Thu, 10 Nov 2022 17:42:38 GMT, Andrew Haley wrote:
>> src/hotspot/share/prims/jvm.cpp line 1410:
>>
>>> 1408: loc = 3;
>>> 1409: } else if (method == resolver.thread_run_method) {
>>> 1410: loc = 2;
>>
>> This depends
On Thu, 3 Nov 2022 11:50:17 GMT, ExE Boss wrote:
>> JEP 429 implementation.
>
> src/java.base/share/classes/java/lang/Thread.java line 1610:
>
>> 1608: ensureMaterializedForStackWalk(bindings);
>> 1609: task.run();
>> 1610: Reference.reachabilityFence(bindings
On Mon, 14 Nov 2022 17:34:31 GMT, Alan Bateman wrote:
>> JEP 429 implementation.
>
> src/java.base/share/classes/java/lang/VirtualThread.java line 318:
>
>> 316: }
>> 317: }
>> 318: @Hidden
>
> Can we rename this to runWith(Runnable, Object) in both Thread and
> VirtualThread t
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
line 475:
> 473: // ??? Do we want to search cache for this? In most cases we
> don't expect
> 474
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Update test
- Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/p
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/4bd44
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/442a0
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing serviceability tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing serviceability tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
Co-authored-by: Maurizio Cimadamore
<54672762+mc
On Tue, 15 Nov 2022 20:11:36 GMT, Alan Bateman wrote:
> I'd prefer to keep this as is because it's too much to use "threads" or
> mention inheritance in the first paragraph.
I agree.
-
PR: https://git.openjdk.org/jdk/pull/10952
On Tue, 15 Nov 2022 18:35:06 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/cl
On Tue, 15 Nov 2022 21:28:29 GMT, Maurizio Cimadamore
wrote:
>> This comment is on orElse but I suspect you are suggesting that get() be
>> changed to return Optional. I think we'll need to get more feedback/usage of
>> this API before re-visiting that.
>
> Yes, my comment was really on `get`
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
Co-authored-by: Maurizio Cimadamore
<54672762+mc
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Oops
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/222ddcbc..2a2b0
On Wed, 16 Nov 2022 11:38:10 GMT, Maurizio Cimadamore
wrote:
>> Mm, but this is the type of the value of the `ScopedValue` instance.
>> So, the type of the scoped value is `ScopedValue`, the type of the value
>> is `T`, is it not?
>
> Right - there's "scoped value" which is the holder, and "val
On Tue, 15 Nov 2022 19:15:21 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/cl
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Javadoc changes.
- ProblemList.txt cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.
On Fri, 4 Nov 2022 09:50:10 GMT, Andrew Haley wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
>> line 481:
>>
>>> 479: }
>>> 480: */
>>> 481: return findBinding() != Snapshot.NIL;
>
On Wed, 16 Nov 2022 18:26:15 GMT, Maurizio Cimadamore
wrote:
>> Sorry, I don't understand what you want.
>
> There is a "bare" reference to `ScopedValue`. Should it be `{@code
> ScopedValue}` or `{@link ScopedValue}` ?
Ahh, OK.
-
PR: https://git.openjdk.org/jdk/pull/10952
On Thu, 17 Nov 2022 16:53:13 GMT, Paul Sandoz wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Javadoc changes.
>> - ProblemList.txt cleanup
>
> src/hotspot/share/utilitie
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/280cd
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Reviewer feedback
- Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/
On Thu, 17 Nov 2022 18:58:11 GMT, Andrew Haley wrote:
>> src/hotspot/share/utilities/exceptions.cpp line 166:
>>
>>> 164: // Remove the ScopedValue cache in case we got a virtual machine
>>> 165: // Error while we were trying to manipulate ScopedValue
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/StructuredTaskScope.java
Co-authored-by: Alan Bateman
-
Chan
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Reviewer feedback
-
Changes:
On Wed, 16 Nov 2022 19:04:29 GMT, Andrew Haley wrote:
>> Probably so, yes. I'll have a look at that along with caching failure.
>
> So I just did the experiment of caching failures and the result of
> `isBound()`.
>
> This test:
>
>
> @Benchmark
>
On Thu, 17 Nov 2022 20:18:42 GMT, Paul Sandoz wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Javadoc changes.
>> - ProblemList.txt cleanup
>
> src/jdk.incubator.co
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Reviewer feedback
- Reviewer feedback Javadoc fixes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: ht
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Add ensureMaterializedForStackWalk kludge for AArch64
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: ht
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Fix bad merge.
-
Changes:
- all: https://gi
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Remove incorrect assertion.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update src/hotspot/cpu/aarch64/aarch64.ad
Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.github.com>
-
Changes:
- a
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/lang/Thread.java
Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.github.com>
-
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with three additional
commits since the last revision:
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Update src/java.base/share/classes/java/lang/Virtu
On Fri, 18 Nov 2022 17:31:30 GMT, Alan Bateman wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Reviewer feedback
>> - Reviewer feedback Javadoc fixes
>
> src/java.base/shar
On Wed, 16 Nov 2022 13:13:59 GMT, Alan Bateman wrote:
>> Note that `ScopedValue` can currently be bound to `null`, but by using
>> `Optional`, there would be no way to differentiate an unbound `ScopedValue`
>> from one bound to `null`.
>
>> Note that `ScopedValue` can currently be bound to `nul
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update src/hotspot/share/classfile/vmSymbols.hpp
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: ht
On Tue, 22 Nov 2022 17:34:22 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Merge branch 'JDK-828' of https://github.com/the
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Feedback from reviewers
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/fi
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
javadoc
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/7ac61ba2..8c526
On Fri, 18 Nov 2022 15:19:35 GMT, Alan Bateman wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reviewer feedback
>
> src/java.base/share/classes/java/lang/Thread.jav
> JEP 429 implementation.
Andrew Haley has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 52 commits:
- Merge master
- javadoc
- Feedback from reviewers
- Update src/hotspot/share/classfile/vmSymbols.hpp
- Merge branch 'JDK
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
Co-authored-by: Paul Sandoz
- Update
On Wed, 23 Nov 2022 19:16:23 GMT, Paul Sandoz wrote:
> Looks good (just some last minor comments). I did not focus on the tests, nor
> too closely at all of the HotSpot changes.
>
> Something for future investigation perhaps (if not already thought about):
> consider using a persistent map, a
On Wed, 23 Nov 2022 18:49:07 GMT, Paul Sandoz wrote:
>> Andrew Haley has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 52 commits:
>>
>> - Merge master
>> - javadoc
>> - Feedback from revi
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Fix merge
-
Changes:
- all: https://git.op
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/3a6f8
On Wed, 23 Nov 2022 18:47:28 GMT, Paul Sandoz wrote:
>> Andrew Haley has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 52 commits:
>>
>> - Merge master
>> - javadoc
>> - Feedback from revi
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
Co-authored-by: Paul Sandoz
-
Changes:
-
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with five additional
commits since the last revision:
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Update
src/jdk.incubator.concurrent/share/classes/
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/15db2a30..90378
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/903780d6..1b3c3
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Unused variable
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/1b3c3
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unused variable
src/jdk.incubator.concurrent/share/classes/jdk
On Wed, 30 Nov 2022 21:34:59 GMT, Dean Long wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused variable
>
> src/hotspot/cpu/aarch64/aarch64.ad line 3635:
>
>> 3633:
On Wed, 30 Nov 2022 21:39:40 GMT, Dean Long wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused variable
>
> src/hotspot/share/classfile/javaClasses.cpp line 1731:
>
&
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Feedback from reviewers
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/fi
On Wed, 30 Nov 2022 21:47:47 GMT, Dean Long wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused variable
>
> src/hotspot/share/prims/jvm.cpp line 1385:
>
>> 1383: vf
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Feedback from reviewers
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/fi
> JEP 429 implementation.
Andrew Haley has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 69 commits:
- Merge https://github.com/openjdk/jdk into JDK-828
- Feedback from reviewers
- Feedback from reviewers
- Unused varia
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Add comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/702d7
> JEP 429 implementation.
Andrew Haley has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 71 commits:
- Merge from JDK mainline
- Add comment
- Merge https://github.com/openjdk/jdk into JDK-828
- Feedback from review
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
This pull request has now been integrated.
Changeset: 221e1a42
Author: Andrew Haley
Committer: Alan Bateman
URL:
https://git.openjdk.org/jdk/commit/221e1a426070088b819ddc37b7ca77d9d8626eb4
St
1 - 100 of 248 matches
Mail list logo