On Thu, 11 Jul 2024 23:57:27 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review comments
>> - Review comments
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 4810:
>
>> 4808: Label*
>> L_success,
>> 4809: Label*
>> L_failure) {
>> 4810: // NB! Callers may assume that, when temp2_reg is a valid register,
>
> Oh, that's a subtle point... Can we make it more evident at call sites?
Done. I think the only code that still depends on it is the C2 pattern that
uses check_klass_subtype_slow_path_linear in x86_32.ad and x86_64.ad.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19989#discussion_r1686845837
