On Tue, 26 Nov 2024 20:55:03 GMT, Roger Riggs wrote:
> The `java.lang.Sytem.security` field no longer exists; remove it from the
> filterMap.
Copyright should be updated.
-
PR Review: https://git.openjdk.org/jdk/pull/22400#pullrequestreview-2462675428
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote:
>> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
>> `Runnable`, which is consumed by a `Consumer` (instantiated within
>> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
>> number of
On Tue, 26 Nov 2024 20:55:03 GMT, Roger Riggs wrote:
> The `java.lang.Sytem.security` field no longer exists; remove it from the
> filterMap.
Marked as reviewed by mchung (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22400#pullrequestreview-2462735401
On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang wrote:
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote:
>> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
>> `Runnable`, which is consumed by a `Consumer` (instantiated within
>> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
>> number of
On Sun, 24 Nov 2024 03:26:18 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch sharpens the return types of various internal methods. This helps
>> the compiler to have better information when the corresponding methods are
>> not inlined.
>>
>> Please take a look and leave your reviews, thanks
On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang wrote:
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these
On Tue, 19 Nov 2024 20:35:01 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copy debuginfo
>
> make/modules/java.desktop/lib/ClientLibraries.gmk line 180:
>
>> 178: deflate.o Defl
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Tue, 26 Nov 2024 15:02:20 GMT, Raffaello Giulietti
wrote:
> OK. But for the sake of completeness, I would add at least one test case for
> an overflowing `workingScale`.
I'm afraid it's not possible to produce such a test case, with the current
implementation of `BigInteger`.
Indeed, `work
On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs wrote:
>> SM removal for internal implementation classes:
>> java.lang.CharacterName
>> java.lang.ref.Finalizer
>> jdk.internal.icu.impl.ICUBinary
>> jdk.internal.misc.ExtendedMapMode
>
> Roger Riggs has updated the pull request incre
On Fri, 22 Nov 2024 22:13:00 GMT, Roger Riggs wrote:
> Updates to the java.xml module following the SecurityManager removal.
> Refactor to remove doPrivilege calls
> Refactor to eliminate dead code assuming getSecurityManager() == null
> Refactor to drop use of AccessControlContext
> Remove (mos
On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs wrote:
> SM removal for internal implementation classes:
> java.lang.CharacterName
> java.lang.ref.Finalizer
> jdk.internal.icu.impl.ICUBinary
> jdk.internal.misc.ExtendedMapMode
This pull request has now been integrated.
Changeset:
On Tue, 26 Nov 2024 17:04:49 GMT, fabioromano1 wrote:
>> OK.
>> But for the sake of completeness, I would add at least one test case for an
>> overflowing `workingScale`.
>>
>> Other than that, the PR is then in good shape for approval.
>
>> OK. But for the sake of completeness, I would add at
On Wed, 20 Nov 2024 00:37:25 GMT, Calvin Cheung wrote:
> Currently, when retrieving a ClassFileStream during runtime, we call into the
> zip library to retrieve the stream based only on a class name. This doesn't
> work well if the class is in a multi-release jar under a versioned directory
>
On Tue, 26 Nov 2024 04:06:22 GMT, David Holmes wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove assert in filemap.cpp
>
> Marked as reviewed by dholmes (Reviewer).
Thanks @dholmes-ora, @iklam, @liach, @Alan
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Tue, 26 Nov 2024 15:32:43 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/buildjdk-spec.gmk.template line 80:
>>
>>> 78: CXXFLAGS_JDKEXE := @OPENJDK_BUILD_CXXFLAGS_JDKEXE@
>>> 79: LDFLAGS_JDKEXE := @OPENJDK_BUILD_LDFLAGS_JDKEXE@
>>> 80: LDFLAGS_STATIC_JDK := @OPENJDK_BUILD_LDFLAGS_STATIC_JDK@
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Mon, 25 Nov 2024 12:26:37 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java
>> line 144:
>>
>>> 142: }
>>> 143:
>>> 144: private NativeMemorySegmentImpl reinterpretInternal(Class
>>> callerClass, long newSize, MemorySessionIm
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
On Tue, 26 Nov 2024 06:55:21 GMT, Alan Bateman wrote:
> I think you can simplify this more by allocating with Unsafe and use the
> DirectByteBuffer(int, long) constructor.
Changed as suggested in 1d7588a.
-
PR Comment: https://git.openjdk.org/jdk/pull/22339#issuecomment-2501357138
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8344882: Remove local field "temporary" by using an alternat
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8344882: If the buffer is a slice, free it's parent's addres
On Tue, 26 Nov 2024 18:14:22 GMT, Joe Wang wrote:
>> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>>
>> Tests:
>> Updated the config test with the new settings.
>>
>> Removed obsolete tests Bug6309988.java and
>> Bug4674384_MAX_OCCURS_Test.java, and files used by
On Tue, 26 Nov 2024 18:14:29 GMT, Mandy Chung wrote:
> For jlink to detect if the current runtime is patched, have you tried
> `ModuleBootstrap.patcher().hasPatches()` which I think it's an alternative to
> avoid introducing this system property.
I'm considering to drop this PR and filter reso
On Tue, 26 Nov 2024 18:53:58 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
> Hi,
>
> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just
> the revert of the backout.
>
> Regarding the related issues:
>
> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
> [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix
On Fri, 15 Nov 2024 22:17:10 GMT, Chen Liang wrote:
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when
On Fri, 15 Nov 2024 22:17:10 GMT, Chen Liang wrote:
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when
Please consider this cleanup PR which makes the now package-protected
`ModuleDescriptor` constructor private.
This constructor is only accessed by the class itself via JavaLangModuleAccess.
Making it private would express the intent of this class as being
non-subclassable.
Marking this class f
The `java.lang.Sytem.security` field no longer exists; remove it from the
filterMap.
-
Commit messages:
- 8344555: SM cleanup - drop reflection filter of System.security field
Changes: https://git.openjdk.org/jdk/pull/22400/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2
> The `java.lang.Sytem.security` field no longer exists; remove it from the
> filterMap.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22400/files
On Tue, 26 Nov 2024 18:53:58 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
On Tue, 26 Nov 2024 22:38:14 GMT, Roger Riggs wrote:
>> The `java.lang.Sytem.security` field no longer exists; remove it from the
>> filterMap.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
Marked as rev
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang wrote:
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Mon, 25 Nov 2024 19:55:46 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
On Tue, 26 Nov 2024 06:55:21 GMT, Alan Bateman wrote:
> the DirectByteBuffer(int, long) constructor
I think you intend the constructor which is now
private Direct$Type$Buffer(long addr, long cap) {
at line 172 in the latest commit.
-
PR Comment: https://git.openjdk.org/jdk/pu
On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang wrote:
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still unfixed.
>
> @liach proposed the idea of changing th
On Tue, 26 Nov 2024 17:31:38 GMT, Raffaello Giulietti
wrote:
>>> I don't get your point. Here's an example:
>>>
>>> ```
>>> BigDecimal.ONE.sqrt(new MathContext(2_000_000_000, RoundingMode.UP))
>>> | Exception java.lang.ArithmeticException: Overflow
>>> |at BigDecimal.sqrt (BigDecimal.j
On Fri, 22 Nov 2024 17:04:38 GMT, Severin Gehwolf wrote:
>> Please review this simple patch which adds a new external system property
>> `jdk.patched` when the runtime has been patched with the `--patch-module`
>> switch. This is useful for two reasons: 1) it allows one to determine at
>> run-
On Mon, 25 Nov 2024 15:27:13 GMT, Per Minborg wrote:
> This PR proposes adding a _JDK-internal_ method for calculating hash codes
> for content in a `MemorySegment`.
>
> The internal method uses a polynomial 32-bit hash function equivalent to
> `Arrays::hashCode`. The new method is almost two
On Tue, 26 Nov 2024 13:55:10 GMT, Viktor Klang wrote:
>> This PR proposes adding a _JDK-internal_ method for calculating hash codes
>> for content in a `MemorySegment`.
>>
>> The internal method uses a polynomial 32-bit hash function equivalent to
>> `Arrays::hashCode`. The new method is almos
On Mon, 25 Nov 2024 17:19:41 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which adds a utility API in the test libraries to
>> assert whether a file is currently open.
>>
>> Several OpenJDK tests currently rely on approximations to check this,
>> including deletion (fails only on Wind
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still unfixed.
>
> @liach proposed the idea of changing th
This applies the same kinds of recovery on OOME (by spinning) and JVM
Exceptions (by cancelling) seen in AQS.
-
Commit messages:
- Add fall-back on OOME, cancel on JVM exceptions
Changes: https://git.openjdk.org/jdk/pull/22396/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&p
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these tests. These tests
> verified legacy properties. Th
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Fri, 22 Nov 2024 17:04:38 GMT, Severin Gehwolf wrote:
>> Please review this simple patch which adds a new external system property
>> `jdk.patched` when the runtime has been patched with the `--patch-module`
>> switch. This is useful for two reasons: 1) it allows one to determine at
>> run-
> Hi,
>
> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just
> the revert of the backout.
>
> Regarding the related issues:
>
> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
> [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix
On Fri, 8 Nov 2024 23:17:35 GMT, Sandhya Viswanathan
wrote:
>> I have adapted the patch in accordance with
>> https://github.com/openjdk/jdk/pull/20634, I moved the index wrapping into
>> C2 instead of making it a separate step as I think it seems clearer. Also, I
>> think in the future we ca
On Tue, 29 Oct 2024 20:27:20 GMT, Paul Sandoz wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> [vectorapi] Refactor VectorShuffle implementation
>
> src/jdk.incubator.vector/share/classes/
On Tue, 15 Oct 2024 16:25:04 GMT, Emanuel Peter wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> [vectorapi] Refactor VectorShuffle implementation
>
> src/hotspot/share/opto/vectornode.hpp
On Tue, 26 Nov 2024 18:14:22 GMT, Joe Wang wrote:
>> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>>
>> Tests:
>> Updated the config test with the new settings.
>>
>> Removed obsolete tests Bug6309988.java and
>> Bug4674384_MAX_OCCURS_Test.java, and files used by
On Mon, 25 Nov 2024 19:36:04 GMT, fabioromano1 wrote:
>> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
>> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>>
>> The main steps of the algorithm are as follows:
>> first argument reduce the value to an i
On Tue, 26 Nov 2024 14:08:23 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added tests for exact results path
>
> test/jdk/java/math/BigDecimal/SquareRootTests.java line 200:
>
>> 198:
On Tue, 26 Nov 2024 14:51:44 GMT, fabioromano1 wrote:
>> test/jdk/java/math/BigDecimal/SquareRootTests.java line 200:
>>
>>> 198: // mc.roundingMode != RoundingMode.UNNECESSARY &&
>>> mc.precision == 0
>>> 199: try {
>>> 200: result = BigDecimal.TEN.sqrt(
On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs wrote:
>> SM removal for internal implementation classes:
>> java.lang.CharacterName
>> java.lang.ref.Finalizer
>> jdk.internal.icu.impl.ICUBinary
>> jdk.internal.misc.ExtendedMapMode
>
> Roger Riggs has updated the pull request incre
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8344882: Make allocate+free be only in Util
-
On Tue, 26 Nov 2024 15:40:13 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.desktop/lib/ClientLibraries.gmk line 166:
>>
>>> 164: jfdctflt.o jfdctfst.o jfdctint.o jidctflt.o jidctfst.o
>>> jidctint.o \
>>> 165: jidctred.o jmemmgr.o jmemnobs.o jpegdecoder.o jquant1.o
>>> jq
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Fri, 22 Nov 2024 17:04:38 GMT, Severin Gehwolf wrote:
>> Please review this simple patch which adds a new external system property
>> `jdk.patched` when the runtime has been patched with the `--patch-module`
>> switch. This is useful for two reasons: 1) it allows one to determine at
>> run-
On Tue, 19 Nov 2024 20:21:52 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copy debuginfo
>
> make/autoconf/buildjdk-spec.gmk.template line 80:
>
>> 78: CXXFLAGS_JDKEXE := @OPENJDK_BUILD
On Tue, 19 Nov 2024 20:28:18 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copy debuginfo
>
> make/common/JdkNativeCompilation.gmk line 313:
>
>> 311: # created libraries, and is rea
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Tue, 19 Nov 2024 20:34:31 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copy debuginfo
>
> make/modules/java.desktop/lib/ClientLibraries.gmk line 166:
>
>> 164: jfdctflt.o jfd
On Mon, 25 Nov 2024 23:39:39 GMT, Roger Riggs wrote:
>> SM removal for internal implementation classes:
>> java.lang.CharacterName
>> java.lang.ref.Finalizer
>> jdk.internal.icu.impl.ICUBinary
>> jdk.internal.misc.ExtendedMapMode
>
> Roger Riggs has updated the pull request incre
On Tue, 26 Nov 2024 17:22:41 GMT, Raffaello Giulietti
wrote:
> I don't get your point. Here's an example:
>
> ```
> BigDecimal.ONE.sqrt(new MathContext(2_000_000_000, RoundingMode.UP))
> | Exception java.lang.ArithmeticException: Overflow
> |at BigDecimal.sqrt (BigDecimal.java:2226)
>
On Tue, 26 Nov 2024 17:13:04 GMT, fabioromano1 wrote:
>>> OK. But for the sake of completeness, I would add at least one test case
>>> for an overflowing `workingScale`.
>>
>> I'm afraid it's not possible to produce such a test case, with the current
>> implementation of `BigInteger`.
>> Indee
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
On Mon, 25 Nov 2024 17:19:13 GMT, Roger Riggs wrote:
>> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>>
>> Tests:
>> Updated the config test with the new settings.
>>
>> Removed obsolete tests Bug6309988.java and
>> Bug4674384_MAX_OCCURS_Test.java, and files used
On Tue, 26 Nov 2024 17:27:58 GMT, fabioromano1 wrote:
>> I don't get your point. Here's an example:
>>
>> BigDecimal.ONE.sqrt(new MathContext(2_000_000_000, RoundingMode.UP))
>> | Exception java.lang.ArithmeticException: Overflow
>> |at BigDecimal.sqrt (BigDecimal.java:2226)
>> |
On Fri, 15 Nov 2024 11:12:06 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Inflater.java line 719:
>>
>>> 717: */
>>> 718: @Override
>>> 719: public void close() {
>>
>> Ditto, should this be `final` to be clear about what should be overridden to
>> perform
On Tue, 26 Nov 2024 16:13:46 GMT, Sean Mullan wrote:
>> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>>
>> Tests:
>> Updated the config test with the new settings.
>>
>> Removed obsolete tests Bug6309988.java and
>> Bug4674384_MAX_OCCURS_Test.java, and files used
The comment provided in `store(Writer, String)` is added in addition to
the date comment:
if (comments != null) {
writeComments(bw, comments);
}
writeDateComment(bw);
The system property can be used to replace the date with a constant, but
a) it's not possib
On Tue, 26 Nov 2024 17:36:40 GMT, Alan Bateman wrote:
>> Done.
>
> Inflater/Deflater date from JDK 1.1 so I think there is some risk to adding a
> final no-arg close method. I understand that a corpus analysis has been done,
> and the intention of making it final is for subclasses to know which
On Wed, 27 Nov 2024 01:27:15 GMT, Alexey Semenyuk wrote:
>> Switched jpackage unit tests to use JUnit5.
>> Got rid of dependencies on the "hamcrest".
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelate
On Wed, 27 Nov 2024 06:26:17 GMT, Jaikiran Pai wrote:
>> Inflater/Deflater date from JDK 1.1 so I think there is some risk to adding
>> a final no-arg close method. I understand that a corpus analysis has been
>> done, and the intention of making it final is for subclasses to know which
>> met
Hello Rob,
On 27/11/24 12:52 am, Rob Spoor wrote:
The comment provided in `store(Writer, String)` is added in addition
to the date comment:
if (comments != null) {
writeComments(bw, comments);
}
writeDateComment(bw);
The system property can be used to repla
On Sat, 23 Nov 2024 16:29:10 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch sharpens the return types of various internal methods. This helps
> the compiler to have better information when the corresponding methods are
> not inlined.
>
> Please take a look and leave your reviews, thanks a lot.
On Fri, 15 Nov 2024 22:17:10 GMT, Chen Liang wrote:
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when
On Tue, 26 Nov 2024 20:41:05 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits si
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when reflecting native methods, even if their overrides may
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a trailing
> `@`. W
On Thu, 26 Sep 2024 13:30:07 GMT, David M. Lloyd wrote:
> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
> `Runnable`, which is consumed by a `Consumer` (instantiated within
> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
> number of lam
On Tue, 26 Nov 2024 22:38:14 GMT, Roger Riggs wrote:
>> The `java.lang.Sytem.security` field no longer exists; remove it from the
>> filterMap.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
Marked as rev
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a trailing
> `@`. W
On Tue, 26 Nov 2024 06:56:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change that proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8344908?
>>
>> With this change, the URLClassPath will no longer propagate the
>> `IllegalArgumentException` thro
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote:
>> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
>> `Runnable`, which is consumed by a `Consumer` (instantiated within
>> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
>> number of
On Fri, 1 Nov 2024 16:13:57 GMT, Brian Burkhalter wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
> Switched jpackage unit tests to use JUnit5.
> Got rid of dependencies on the "hamcrest".
Alexey Semenyuk has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contai
On Thu, 21 Nov 2024 23:53:59 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a trailing
> `@`. When this special case now is removed, some streamlining
On Wed, 27 Nov 2024 01:43:34 GMT, Alex Menkov wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/NativeLibraries.c
>>
>> Co-authored-by: Alex Menkov <69548902+alexmen...@
On Mon, 25 Nov 2024 14:42:14 GMT, Per Minborg wrote:
> This PR proposes to fix some tests that fails on big-endian platforms.
This pull request has now been integrated.
Changeset: 4e68d665
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/4e68d665bef8d13adb499a803c2f68b704e
1 - 100 of 119 matches
Mail list logo
