On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang <jo...@openjdk.org> wrote:
> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>
> Tests:
> Updated the config test with the new settings.
>
> Removed obsolete tests Bug6309988.java and
> Bug4674384_MAX_OCCURS_Test.java, and files used by these tests. These tests
> verified legacy properties. They came into the JDK from the JAXP and SJSXP
> standalone libraries. Improvements were made before the integration into the
> JDK via for example, SJSXP Issue 30. Though the issue tracker is no longer
> accessible, the tests, e.g. IssueTracker30, are in the JAXP test suite.
Looks fine
test/jaxp/javax/xml/jaxp/unittest/common/config/ImplProperties.java line 31:
> 29: public class ImplProperties {
> 30: // JDK Implementation Specific Properties, refer to module description
> 31: public static final String[] PROPERTY_KEYS = {
This test would be easier to maintain if the Properties were defined as an
enum, each with its related values.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22337#pullrequestreview-2459057099
PR Review Comment: https://git.openjdk.org/jdk/pull/22337#discussion_r1856991296
