Poking the thread in case you are able to answer my previous question
Viktor.
Also, another question -- I posted this thread to Reddit, and some good
discussion has already started. Can you or someone else answer some of the
questions that have popped up there?
https://old.reddit.com/r/java/comme
On Mon, 18 Nov 2024 21:05:41 GMT, Magnus Ihse Bursie wrote:
> I think it makes sense to include the version. I have no strong opinions on
> the format. Is the extract in the PR description updated with the latest
> version changes?
Yes, the description is updated with the output, and I've also
On Sat, 16 Nov 2024 00:03:18 GMT, Brent Christian wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> prev is not needed
>
> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 239:
>
>> 237:
On Tue, 19 Nov 2024 00:58:18 GMT, Brent Christian wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop --add-exports from the test
>
> test/jdk/jdk/internal/ref/Cleaner/CleanableListTest.java line 46:
>
>> 44:
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
Please review this trivial cleanup of an unused import of `AccessControlContext
` in `JavaLangAccess`.
This was left over after #22035 removed
`JavaLangAccess::newThreadWithAcc(Runnable, AccessControlContext)`.
Verification: `make images` succeeds.
-
Commit messages:
- Remove le
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Mon, 18 Nov 2024 15:22:59 GMT, Christian Stein wrote:
> Please review this improvement to the manual page covering the usage of
> wildcards in `java`'s argfiles.
> [...] I think this sentence can be removed altogether, given that this
> semantic is already explained a few sentences above by
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
Can I please get a review of this change which proposes to remove
SecurityManager related API usages from `URLClassLoader` and its related
`URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
The `URLClassLoader.getPermissions()` method will need additional changes but
th
> Can I please get a review of this change which proposes to remove
> SecurityManager related API usages from `URLClassLoader` and its related
> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>
> The `URLClassLoader.getPermissions()` method will need additional chang
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Tue, 12 Nov 2024 15:30:23 GMT, Alan Bateman wrote:
>> `shortVersionString` changed to `conciseVersionString` in:
>> https://github.com/openjdk/jdk/pull/21411/commits/e9e9ad4bdd0a11244cb1ef84fdeea036e94718c7
>
>> The idea behind printing the short version is to identify what tool is
>> speakin
On Mon, 18 Nov 2024 14:21:29 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 2248:
>>
>>> 2246: }
>>> 2247: }
>>> 2248: } else { // mc.roundingMode == RoundingMode.UP ||
>>> mc
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Tue, 19 Nov 2024 11:54:41 GMT, Alan Bateman wrote:
> Okay but hardly worth doing as JLA is changed very frequently so any unused
> imports will be quickly removed.
Thanks Alan. I'll go ahead and integrate this now, but I'm taking note of your
point for any future changes in similar contexts
On Mon, 18 Nov 2024 13:21:25 GMT, Alexey Semenyuk wrote:
> Simple typo fix.
>
> Old view:
> https://github.com/openjdk/jdk/blob/dfddbcaab886b9baa731cd748bb7f547e1903b64/src/jdk.jpackage/share/man/jpackage.md
>
> New view:
> https://github.com/alexeysemenyukoracle/jdk/blob/JDK-8336087/src/jdk.
On Mon, 18 Nov 2024 18:31:09 GMT, Alexey Semenyuk wrote:
> Move child classes of "jdk.jpackage.test.Functional" class to
> "jdk.jpackage.internal.util.function" package.
> Split "jdk.jpackage.internal.IOUtils" class in "PathUtils", "FileUtils",
> "XmlUtils" classes in "jdk.jpackage.internal.uti
On Mon, 18 Nov 2024 13:41:49 GMT, Alexey Semenyuk wrote:
> Support using jpackage l10n keys instead of string values when examining
> jpackage error output.
This pull request has now been integrated.
Changeset: 0714114f
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit
On Tue, 19 Nov 2024 14:44:40 GMT, fabioromano1 wrote:
>> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
>> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>>
>> The main steps of the algorithm are as follows:
>> first argument reduce the value to an i
On Tue, 19 Nov 2024 08:09:38 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Tue, 19 Nov 2024 16:52:44 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concu
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken
> and can NOT be repaired due to
On Tue, 19 Nov 2024 16:45:47 GMT, Hannes Greule wrote:
>> In fact, another solution I have contemplated is to update
>> `JavaLangInvokeAccess` implementations. 4 methods in it,
>> `unreflectConstructor`, `unreflectField`, `findVirtual`, and `findStatic`,
>> are exclusively used by core reflect
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
src/java.prefs/share/classes/java/util/prefs/Preferences.java line 248:
> 246: }
> 247: }
> 248: return fact
On Mon, 18 Nov 2024 15:12:12 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
Now that JEP 486 has been integrated, `java.security.jgss` and
`jdk.security.jgss` module dependencies on `System.getSecurityManager` and
`AccessController.doPrivileged*` can be removed.
There is an undocumented property named "sun.security.krb5.autodeducerealm"
that can probably be removed as
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Mon, 14 Oct 2024 15:32:41 GMT, Bhavana Kilambi wrote:
> Hi Jatin, could you also include the idealization tests here -
> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and
> ConvF2HFIdealizationTests.java in this PR?
Hi @Bhavana-Kilambi ,
I am in process of refining
On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun
On Tue, 19 Nov 2024 16:54:04 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concu
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
src/java.prefs/share/classes/java/util/prefs/Preferences.java line 40:
> 38: import java.util.ServiceConfigurationError;
> 39:
> 40: //
Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes in
the tests. Replace them with stubs.
Stop referencing IOUtils class from XmlUtils and PathUtils classes.
-
Commit messages:
- Minor improvements
- Make IOUtils class package-private
- Bugfix & cleanup
On Tue, 19 Nov 2024 12:54:18 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
Bad merge fix
-
Commit messages:
- 8344550: Compilation error of jpackage test JPackageStringBundle.java source
Changes: https://git.openjdk.org/jdk/pull/22241/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22241&range=00
Issue: https://bugs.openjdk.org/browse/JDK-834455
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- Remove more unnecessary @SuppressWarnings annotations.
- Merge branc
On Tue, 19 Nov 2024 12:41:46 GMT, Sandhya Viswanathan
wrote:
>> ISA supports multiple flavors, the current scheme is in line with the wiring
>> of inputs done before matching.
>
> You could save some reg/reg movs with 231 flavor.
It will depend on the live ranges of the three inputs.
On Tue, 19 Nov 2024 15:50:07 GMT, Alexey Semenyuk wrote:
> Bad merge fix
This pull request has now been integrated.
Changeset: 7f672eb2
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/7f672eb266b76a9310dcf108f72adf2469e63dee
Stats: 3 lines in 1 file changed: 1 ins
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Hi Brent,
There looks to be a lot of commented out code that should be removed as part of
your PR?
src/java.prefs/unix/classes/java/ut
On Tue, 19 Nov 2024 19:22:44 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Fri, 15 Nov 2024 12:17:47 GMT, Lance Andersen wrote:
>> Stuart in one of his review comments in this PR had noted that:
>>
>>> I think the class specification needs to be clearer about the positioning
>>> of end() and close(). The end() method has done the real work of "closing"
>>> since t
On Fri, 15 Nov 2024 11:15:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
Fix `ResourceEditor` class to handle long paths.
Based on https://github.com/openjdk/jdk/pull/9384 PR.
This repairs app image building on Windows if the path to jpackage temp
directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken and
can NOT be repaired due to WiX's limitat
On Thu, 14 Nov 2024 04:40:37 GMT, Alexey Semenyuk wrote:
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI
On Tue, 19 Nov 2024 19:22:44 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken
> and can NOT be repaired due to
On Thu, 14 Nov 2024 18:24:59 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Tue, 19 Nov 2024 06:47:17 GMT, David Holmes wrote:
> I wonder if we can assert we are in a safepoint-safe state when doing so?
I think we can do this. I've prototyped this here:
https://github.com/openjdk/jdk/compare/pr/21742...JornVernee:jdk:SafeFrameAnchor+assert
This catches the issue fi
On Tue, 19 Nov 2024 10:48:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
Please review this follow-up PR to improve `java`'s manpage section about
wildcards in argument files: the confusing sentence is now removed.
This is a cleanup of commit
https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
-
Commit messages:
- 8344540: Re
On Tue, 19 Nov 2024 12:42:18 GMT, Jaikiran Pai wrote:
>> The new comment isn't quite right, it should say "concat the URLs to the
>> resource in the modules and the class path".
>
>> concat the URLs to the resource in the modules and the class path
>
> Did you mean "concat the URLs of the "
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Sun, 17 Nov 2024 15:33:02 GMT, Doug Lea wrote:
>> This addresses tendencies in previous update to increase fencing, scanning,
>> and signalling that can increase contention, and slow down performance
>> especially on ARM platforms. It also uses more ARM-friendly constructions to
>> reduce o
On Fri, 15 Nov 2024 22:17:10 GMT, Chen Liang wrote:
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
src/java.prefs/share/classes/java/util/prefs/AbstractPreferences.java line 1059:
> 1057: * preference tree.
> 1058: */
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Fri, 25 Oct 2024 04:46:52 GMT, Jatin Bhateja wrote:
>> Hi Jatin, could you also include the idealization tests here -
>> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and
>> ConvF2HFIdealizationTests.java in this PR?
>
>> Hi Jatin, could you also include the idealiza
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Mon, 18 Nov 2024 23:11:20 GMT, Sandhya Viswanathan
wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Det
On Tue, 19 Nov 2024 08:43:06 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/x86.ad line 11015:
>>
>>> 11013: ins_encode %{
>>> 11014: int vlen_enc = vector_length_encoding(this);
>>> 11015: __ evfmadd132ph($dst$$XMMRegister, $src2$$XMMRegister,
>>> $src1$$XMMRegister, vlen_enc);
>>
On Wed, 16 Oct 2024 14:19:40 GMT, Bhavana Kilambi wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detectio
On Tue, 19 Nov 2024 00:29:42 GMT, Sandhya Viswanathan
wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Det
On Tue, 19 Nov 2024 19:02:09 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 2253:
>>
>>> 2251:
>>> 2252: case UP, CEILING -> {
>>> 2253: BigInteger[] sqrtRem =
>>> workingInt.sqrtAndRemainder();
>>
>> Can't th
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Tue, 19 Nov 2024 19:19:51 GMT, Brent Christian wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> co
Hi All,
This patch adds C2 compiler support for various Float16 operations added by
[PR#22128](https://github.com/openjdk/jdk/pull/22128)
Following is the summary of changes included with this patch:-
1. Detection of various Float16 operations through inline expansion or pattern
folding ideali
On Tue, 19 Nov 2024 08:09:38 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
> This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
> JDK providers, and contains the following changes:
> - The following two properties are removed:
> - `com.sun.jndi.ldap.object.trustURLCodebase`
> - `com.sun.jndi.rmi.object.trustURLCodebase`
> - JNDIs object
On Tue, 19 Nov 2024 19:26:03 GMT, Aleksey Shipilev wrote:
> > With SM removal, there is a doPrivileged call in Cleaner.java. Should that
> > be handled separately from this PR?
>
> Since this is not related to the problem at hand, I'd prefer to keep it out
> of this PR.
Actually, I wonder if
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Thu, 17 Oct 2024 21:35:40 GMT, Paul Sandoz wrote:
> > Before the work in this PR proceeds, I think the java.lang ->
> > jdk.incubator.vector move of Float16 should occur first. This will allow
> > leaner reviews and better API separation. I can get an updated PR of the
> > move prepared wit
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
This pull request has now been integrated.
Changeset: 81e43114
Author:Brian Burkhalter
URL:
https://git.openjdk.org/j
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
One more comment removal; fix 1 indent
-
Changes:
- all: https://
On Tue, 19 Nov 2024 19:18:12 GMT, Lance Andersen wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line
> 63:
>
>> 61: //};
>> 62: //AccessCont
On Tue, 19 Nov 2024 22:31:28 GMT, Alexey Semenyuk wrote:
> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
> in the tests. Replace them with stubs.
>
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
@sashamatveev ptal
-
PR Comment
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
A few classes need updated copyrights.
-
PR Comment: https://git.openjdk.org/jdk/pull/22252#issuecomment-2486583493
On Mon, 14 Oct 2024 16:42:24 GMT, Paul Sandoz wrote:
> We should move the `Float16` class to `jdk.incubator.vector` and relevant
> intrinsic stuff to `jdk.internal.vm.vector`, and we don't need the changes to
> `BigDecimal` and `BigInteger`.
To expand on that point, a few weeks back I took a l
On Tue, 19 Nov 2024 19:53:45 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Fri, 25 Oct 2024 04:46:52 GMT, Jatin Bhateja wrote:
>> Hi Jatin, could you also include the idealization tests here -
>> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and
>> ConvF2HFIdealizationTests.java in this PR?
>
>> Hi Jatin, could you also include the idealiza
On Tue, 19 Nov 2024 18:43:46 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct remainder checking
>
> src/java.base/share/classes/java/math/BigDecimal.java line 2200:
>
>> 2198:
On Fri, 15 Nov 2024 13:25:01 GMT, Alexey Semenyuk wrote:
> The implementation may change, but the name of the function should remain the
> same.
That certainly makes sense. I changed setWinEnableUTF8 to
setWinRunWithEnglishOutput as you suggested.
> I'd run suppress the output of "chcp" comma
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
> the English message "No Instance(s) Available." is output on localized
> windows platforms.
>
> I have referred to the following for how
On Wed, 20 Nov 2024 03:13:23 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 487:
>
>> 485:
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Mon, 18 Nov 2024 19:22:33 GMT, Roger Riggs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rev
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
remove commented code + other review feedback
-
Changes:
- all: h
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
> the English message "No Instance(s) Available." is output on localized
> windows platforms.
>
> I have referred to the following for how
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
> the English message "No Instance(s) Available." is output on localized
> windows platforms.
>
> I have referred to the following for how
On Tue, 19 Nov 2024 19:53:45 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Tue, 19 Nov 2024 23:16:38 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> One more co
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Fri, 15 Nov 2024 14:20:00 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 344:
>
>> 342: c
On Fri, 15 Nov 2024 14:23:36 GMT, Alexey Semenyuk wrote:
> I'm not sure "65001" is the right choice if the request is to get the output
> in English. Would "437" or "850" be more appropriate arguments for the "chcp"
> command?
After receiving your comment, I ran the chcp command on Windows Ser
On Wed, 20 Nov 2024 03:16:47 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 344:
>
>> 342: private L
On Wed, 20 Nov 2024 04:22:48 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the encoding is UTF8 and that
>> the English message "No Instance(s) Available." is output on localized
>> win
1 - 100 of 162 matches
Mail list logo
